From 8c532efd5f02f7a7e5ea322a07ddcf49d130a8ec Mon Sep 17 00:00:00 2001 From: Frederic Guillot Date: Sat, 17 Oct 2015 10:09:03 -0400 Subject: Run php-cs-fixer on the code base --- app/Action/TaskEmail.php | 1 - app/Api/Action.php | 9 +- app/Api/Auth.php | 6 +- app/Api/Base.php | 3 +- app/Api/Category.php | 4 +- app/Api/Comment.php | 4 +- app/Api/File.php | 4 +- app/Api/Link.php | 4 +- app/Api/Me.php | 2 +- app/Api/Project.php | 4 +- app/Api/Subtask.php | 4 +- app/Api/Task.php | 2 +- app/Api/User.php | 4 +- app/Auth/Ldap.php | 23 +- app/Auth/RememberMe.php | 2 - app/Console/LocaleComparator.php | 3 +- app/Console/LocaleSync.php | 6 +- app/Controller/Action.php | 6 +- app/Controller/App.php | 3 +- app/Controller/Auth.php | 1 - app/Controller/Base.php | 3 - app/Controller/Board.php | 13 +- app/Controller/Calendar.php | 7 +- app/Controller/Category.php | 8 +- app/Controller/Column.php | 11 +- app/Controller/Comment.php | 11 +- app/Controller/Config.php | 4 +- app/Controller/Currency.php | 7 +- app/Controller/Customfilter.php | 6 +- app/Controller/Doc.php | 2 +- app/Controller/File.php | 13 +- app/Controller/Gantt.php | 10 +- app/Controller/Ical.php | 3 +- app/Controller/Link.php | 10 +- app/Controller/Oauth.php | 12 +- app/Controller/Project.php | 42 +-- app/Controller/Projectuser.php | 3 +- app/Controller/Search.php | 1 - app/Controller/Subtask.php | 12 +- app/Controller/Swimlane.php | 13 +- app/Controller/Task.php | 1 - app/Controller/TaskImport.php | 3 +- app/Controller/Taskcreation.php | 7 +- app/Controller/Taskduplication.php | 11 +- app/Controller/Tasklink.php | 7 +- app/Controller/Taskmodification.php | 36 +- app/Controller/Taskstatus.php | 1 - app/Controller/Timer.php | 3 +- app/Controller/Twofactor.php | 10 +- app/Controller/User.php | 24 +- app/Controller/UserImport.php | 3 +- app/Controller/Webhook.php | 2 +- app/Core/Csv.php | 6 +- app/Core/DateParser.php | 3 +- app/Core/HttpClient.php | 3 +- app/Core/Lexer.php | 3 - app/Core/Mail/Client.php | 2 +- app/Core/Mail/Transport/Mail.php | 4 +- app/Core/Markdown.php | 1 - app/Core/OAuth2.php | 1 - app/Core/Paginator.php | 6 +- app/Core/Plugin/Base.php | 2 +- app/Core/Plugin/Loader.php | 4 +- app/Core/Request.php | 7 +- app/Core/Response.php | 3 +- app/Core/Router.php | 10 +- app/Core/Security.php | 5 +- app/Core/Template.php | 3 +- app/Core/Tool.php | 14 +- app/Core/Translator.php | 3 +- app/Formatter/ProjectGanttFormatter.php | 4 +- app/Formatter/TaskFilterICalendarFormatter.php | 2 - app/Helper/App.php | 3 +- app/Helper/Dt.php | 6 +- app/Helper/File.php | 4 +- app/Helper/Form.php | 10 +- app/Helper/Subtask.php | 1 - app/Integration/BitbucketWebhook.php | 4 +- app/Integration/GithubWebhook.php | 6 - app/Integration/GitlabWebhook.php | 1 - app/Integration/HipchatWebhook.php | 1 - app/Integration/Jabber.php | 5 +- app/Integration/SlackWebhook.php | 1 - app/Library/password.php | 431 +++++++++++------------ app/Model/Action.php | 8 +- app/Model/Authentication.php | 11 +- app/Model/Base.php | 2 +- app/Model/Board.php | 8 +- app/Model/Category.php | 2 - app/Model/Color.php | 3 +- app/Model/File.php | 15 +- app/Model/LastLogin.php | 1 - app/Model/Link.php | 1 - app/Model/NotificationType.php | 2 +- app/Model/ProjectActivity.php | 6 +- app/Model/ProjectAnalytic.php | 2 - app/Model/ProjectDailyColumnStats.php | 4 +- app/Model/ProjectDailyStats.php | 2 +- app/Model/ProjectPermission.php | 5 +- app/Model/Subtask.php | 3 - app/Model/SubtaskTimeTracking.php | 1 - app/Model/Swimlane.php | 7 +- app/Model/TaskAnalytic.php | 1 - app/Model/TaskCreation.php | 1 - app/Model/TaskDuplication.php | 3 - app/Model/TaskFilter.php | 20 +- app/Model/TaskImport.php | 6 +- app/Model/TaskLink.php | 1 - app/Model/TaskModification.php | 3 +- app/Model/TaskPermission.php | 3 +- app/Model/TaskPosition.php | 12 +- app/Model/User.php | 10 +- app/Model/UserImport.php | 6 +- app/Model/UserNotification.php | 6 +- app/Model/Webhook.php | 4 +- app/Notification/Mail.php | 1 - app/Schema/Mysql.php | 1 - app/Schema/Postgres.php | 13 +- app/Schema/Sqlite.php | 13 +- app/ServiceProvider/ClassProvider.php | 8 +- app/ServiceProvider/DatabaseProvider.php | 3 +- app/Subscriber/ProjectActivitySubscriber.php | 1 - app/Subscriber/RecurringTaskSubscriber.php | 4 +- app/Subscriber/SubtaskTimeTrackingSubscriber.php | 4 +- app/Subscriber/TransitionSubscriber.php | 2 +- app/Template/board/tooltip_files.php | 2 +- app/Template/board/tooltip_tasklinks.php | 2 +- app/Template/config/plugins.php | 2 +- app/Template/header.php | 2 +- app/Template/project/filters.php | 2 +- app/Template/task/changes.php | 10 +- app/Template/user/last.php | 2 +- app/Template/user/sessions.php | 2 +- app/common.php | 1 - doc/coding-standards.markdown | 2 +- tests/functionals/ApiTest.php | 8 +- tests/functionals/UserApiTest.php | 6 +- tests/units/Action/TaskEmailTest.php | 2 +- tests/units/Base.php | 3 +- tests/units/Core/Plugin/HookTest.php | 10 +- tests/units/Integration/BitbucketWebhookTest.php | 6 +- tests/units/Locale/LocaleTest.php | 12 +- tests/units/Model/SubtaskTest.php | 2 +- tests/units/Model/TaskCreationTest.php | 10 +- tests/units/Model/TaskDuplicationTest.php | 8 +- tests/units/Model/TaskExportTest.php | 1 - tests/units/Model/TaskPositionTest.php | 2 - 147 files changed, 476 insertions(+), 783 deletions(-) diff --git a/app/Action/TaskEmail.php b/app/Action/TaskEmail.php index 355a49d8..7fb76c4c 100644 --- a/app/Action/TaskEmail.php +++ b/app/Action/TaskEmail.php @@ -67,7 +67,6 @@ class TaskEmail extends Base $user = $this->user->getById($this->getParam('user_id')); if (! empty($user['email'])) { - $task = $this->taskFinder->getDetails($data['task_id']); $this->emailClient->send( diff --git a/app/Api/Action.php b/app/Api/Action.php index eab20a6c..0ae91f10 100644 --- a/app/Api/Action.php +++ b/app/Api/Action.php @@ -35,10 +35,9 @@ class Action extends \Kanboard\Core\Base $actions = $this->action->getAllByProject($project_id); foreach ($actions as $index => $action) { - $params = array(); - foreach($action['params'] as $param) { + foreach ($action['params'] as $param) { $params[$param['name']] = $param['value']; } @@ -57,7 +56,7 @@ class Action extends \Kanboard\Core\Base 'params' => $params, ); - list($valid,) = $this->action->validateCreation($values); + list($valid, ) = $this->action->validateCreation($values); if (! $valid) { return false; @@ -80,14 +79,14 @@ class Action extends \Kanboard\Core\Base $required_params = $action->getActionRequiredParameters(); // Check missing parameters - foreach($required_params as $param => $value) { + foreach ($required_params as $param => $value) { if (! isset($params[$param])) { return false; } } // Check extra parameters - foreach($params as $param => $value) { + foreach ($params as $param => $value) { if (! isset($required_params[$param])) { return false; } diff --git a/app/Api/Auth.php b/app/Api/Auth.php index b741694b..b3627e4b 100644 --- a/app/Api/Auth.php +++ b/app/Api/Auth.php @@ -29,11 +29,9 @@ class Auth extends Base if ($username !== 'jsonrpc' && ! $this->authentication->hasCaptcha($username) && $this->authentication->authenticate($username, $password)) { $this->checkProcedurePermission(true, $method); $this->userSession->refresh($this->user->getByUsername($username)); - } - else if ($username === 'jsonrpc' && $password === $this->config->get('api_token')) { + } elseif ($username === 'jsonrpc' && $password === $this->config->get('api_token')) { $this->checkProcedurePermission(false, $method); - } - else { + } else { throw new AuthenticationFailure('Wrong credentials'); } } diff --git a/app/Api/Base.php b/app/Api/Base.php index 152ceeab..82397b20 100644 --- a/app/Api/Base.php +++ b/app/Api/Base.php @@ -50,8 +50,7 @@ abstract class Base extends \Kanboard\Core\Base if ($is_user && ! $is_both_procedure && ! $is_user_procedure) { throw new AccessDeniedException('Permission denied'); - } - else if (! $is_user && ! $is_both_procedure && $is_user_procedure) { + } elseif (! $is_user && ! $is_both_procedure && $is_user_procedure) { throw new AccessDeniedException('Permission denied'); } diff --git a/app/Api/Category.php b/app/Api/Category.php index 3e5b3a34..458eaef6 100644 --- a/app/Api/Category.php +++ b/app/Api/Category.php @@ -32,7 +32,7 @@ class Category extends \Kanboard\Core\Base 'name' => $name, ); - list($valid,) = $this->category->validateCreation($values); + list($valid, ) = $this->category->validateCreation($values); return $valid ? $this->category->create($values) : false; } @@ -43,7 +43,7 @@ class Category extends \Kanboard\Core\Base 'name' => $name, ); - list($valid,) = $this->category->validateModification($values); + list($valid, ) = $this->category->validateModification($values); return $valid && $this->category->update($values); } } diff --git a/app/Api/Comment.php b/app/Api/Comment.php index a13c36d4..26b632e9 100644 --- a/app/Api/Comment.php +++ b/app/Api/Comment.php @@ -33,7 +33,7 @@ class Comment extends \Kanboard\Core\Base 'comment' => $content, ); - list($valid,) = $this->comment->validateCreation($values); + list($valid, ) = $this->comment->validateCreation($values); return $valid ? $this->comment->create($values) : false; } @@ -45,7 +45,7 @@ class Comment extends \Kanboard\Core\Base 'comment' => $content, ); - list($valid,) = $this->comment->validateModification($values); + list($valid, ) = $this->comment->validateModification($values); return $valid && $this->comment->update($values); } } diff --git a/app/Api/File.php b/app/Api/File.php index 760ee5ed..be415ecb 100644 --- a/app/Api/File.php +++ b/app/Api/File.php @@ -25,14 +25,12 @@ class File extends \Kanboard\Core\Base public function downloadFile($file_id) { try { - $file = $this->file->getById($file_id); if (! empty($file)) { return base64_encode($this->objectStorage->get($file['path'])); } - } - catch (ObjectStorageException $e) { + } catch (ObjectStorageException $e) { $this->logger->error($e->getMessage()); } diff --git a/app/Api/Link.php b/app/Api/Link.php index 049fcddb..d4df18fe 100644 --- a/app/Api/Link.php +++ b/app/Api/Link.php @@ -72,7 +72,7 @@ class Link extends \Kanboard\Core\Base 'opposite_label' => $opposite_label, ); - list($valid,) = $this->link->validateCreation($values); + list($valid, ) = $this->link->validateCreation($values); return $valid ? $this->link->create($label, $opposite_label) : false; } @@ -93,7 +93,7 @@ class Link extends \Kanboard\Core\Base 'label' => $label, ); - list($valid,) = $this->link->validateModification($values); + list($valid, ) = $this->link->validateModification($values); return $valid && $this->link->update($values); } diff --git a/app/Api/Me.php b/app/Api/Me.php index f4857b58..16ce0aee 100644 --- a/app/Api/Me.php +++ b/app/Api/Me.php @@ -45,7 +45,7 @@ class Me extends Base 'is_private' => 1, ); - list($valid,) = $this->project->validateCreation($values); + list($valid, ) = $this->project->validateCreation($values); return $valid ? $this->project->create($values, $this->userSession->getId(), true) : false; } diff --git a/app/Api/Project.php b/app/Api/Project.php index 4c491ced..f934432d 100644 --- a/app/Api/Project.php +++ b/app/Api/Project.php @@ -69,7 +69,7 @@ class Project extends Base 'description' => $description ); - list($valid,) = $this->project->validateCreation($values); + list($valid, ) = $this->project->validateCreation($values); return $valid ? $this->project->create($values) : false; } @@ -81,7 +81,7 @@ class Project extends Base 'description' => $description ); - list($valid,) = $this->project->validateModification($values); + list($valid, ) = $this->project->validateModification($values); return $valid && $this->project->update($values); } } diff --git a/app/Api/Subtask.php b/app/Api/Subtask.php index 7b526023..7baee3d3 100644 --- a/app/Api/Subtask.php +++ b/app/Api/Subtask.php @@ -36,7 +36,7 @@ class Subtask extends \Kanboard\Core\Base 'status' => $status, ); - list($valid,) = $this->subtask->validateCreation($values); + list($valid, ) = $this->subtask->validateCreation($values); return $valid ? $this->subtask->create($values) : false; } @@ -58,7 +58,7 @@ class Subtask extends \Kanboard\Core\Base } } - list($valid,) = $this->subtask->validateApiModification($values); + list($valid, ) = $this->subtask->validateApiModification($values); return $valid && $this->subtask->update($values); } } diff --git a/app/Api/Task.php b/app/Api/Task.php index 8911c2f1..0dceb209 100644 --- a/app/Api/Task.php +++ b/app/Api/Task.php @@ -91,7 +91,7 @@ class Task extends Base 'reference' => $reference, ); - list($valid,) = $this->taskValidator->validateCreation($values); + list($valid, ) = $this->taskValidator->validateCreation($values); return $valid ? $this->taskCreation->create($values) : false; } diff --git a/app/Api/User.php b/app/Api/User.php index 00d35796..105723d3 100644 --- a/app/Api/User.php +++ b/app/Api/User.php @@ -39,7 +39,7 @@ class User extends \Kanboard\Core\Base 'is_project_admin' => $is_project_admin, ); - list($valid,) = $this->user->validateCreation($values); + list($valid, ) = $this->user->validateCreation($values); return $valid ? $this->user->create($values) : false; } @@ -81,7 +81,7 @@ class User extends \Kanboard\Core\Base } } - list($valid,) = $this->user->validateApiModification($values); + list($valid, ) = $this->user->validateApiModification($values); return $valid && $this->user->update($values); } } diff --git a/app/Auth/Ldap.php b/app/Auth/Ldap.php index 78820d2e..687762d3 100644 --- a/app/Auth/Ldap.php +++ b/app/Auth/Ldap.php @@ -217,7 +217,6 @@ class Ldap extends Base $result = $this->findUser($username, $password); if (is_array($result)) { - $user = $this->user->getByUsername($username); if (! empty($user)) { @@ -226,14 +225,12 @@ class Ldap extends Base if ($user['is_ldap_user'] == 0) { return false; } - } - else { + } else { // We create automatically a new user if ($this->isLdapAccountCreationEnabled() && $this->user->create($result) !== false) { $user = $this->user->getByUsername($username); - } - else { + } else { return false; } } @@ -319,12 +316,10 @@ class Ldap extends Base if ($this->getLdapBindType() === 'user') { $ldap_username = sprintf($this->getLdapUsername(), $username); $ldap_password = $password; - } - else if ($this->getLdapBindType() === 'proxy') { + } elseif ($this->getLdapBindType() === 'proxy') { $ldap_username = $this->getLdapUsername(); $ldap_password = $this->getLdapPassword(); - } - else { + } else { $ldap_username = null; $ldap_password = null; } @@ -486,11 +481,9 @@ class Ldap extends Base { if (! empty($username) && ! empty($email)) { return '(&('.$this->getLdapUserPattern($username).')('.$this->getLdapAccountEmail().'='.$email.'))'; - } - else if (! empty($username)) { + } elseif (! empty($username)) { return $this->getLdapUserPattern($username); - } - else if (! empty($email)) { + } elseif (! empty($email)) { return '('.$this->getLdapAccountEmail().'='.$email.')'; } @@ -508,7 +501,7 @@ class Ldap extends Base */ private function getEntry(array $entries, $key, $default = '') { - return isset($entries[0][$key][0]) ? $entries[0][$key][0] : $default; + return isset($entries[0][$key][0]) ? $entries[0][$key][0] : $default; } /** @@ -522,6 +515,6 @@ class Ldap extends Base */ private function getEntries(array $entries, $key, $default = array()) { - return isset($entries[0][$key]) ? $entries[0][$key] : $default; + return isset($entries[0][$key]) ? $entries[0][$key] : $default; } } diff --git a/app/Auth/RememberMe.php b/app/Auth/RememberMe.php index 6569463d..bba2bda6 100644 --- a/app/Auth/RememberMe.php +++ b/app/Auth/RememberMe.php @@ -88,7 +88,6 @@ class RememberMe extends Base $credentials = $this->readCookie(); if ($credentials !== false) { - $record = $this->find($credentials['token'], $credentials['sequence']); if ($record) { @@ -144,7 +143,6 @@ class RememberMe extends Base $credentials = $this->readCookie(); if ($credentials !== false) { - $this->deleteCookie(); $this->db diff --git a/app/Console/LocaleComparator.php b/app/Console/LocaleComparator.php index fcc3a995..8e5e0904 100644 --- a/app/Console/LocaleComparator.php +++ b/app/Console/LocaleComparator.php @@ -25,7 +25,6 @@ class LocaleComparator extends Base $it->rewind(); while ($it->valid()) { - if (! $it->isDot() && substr($it->key(), -4) === '.php') { $strings = array_merge($strings, $this->search($it->key())); } @@ -72,7 +71,7 @@ class LocaleComparator extends Base $strings = array_merge($strings, $matches[1]); } - array_walk($strings, function(&$value) { + array_walk($strings, function (&$value) { $value = trim($value, "'"); $value = str_replace("\'", "'", $value); }); diff --git a/app/Console/LocaleSync.php b/app/Console/LocaleSync.php index bc3918da..d62b40b5 100644 --- a/app/Console/LocaleSync.php +++ b/app/Console/LocaleSync.php @@ -23,9 +23,7 @@ class LocaleSync extends Base $reference = include $reference_file; foreach (new DirectoryIterator('app/Locale') as $fileInfo) { - if (! $fileInfo->isDot() && $fileInfo->isDir() && $fileInfo->getFilename() !== self::REF_LOCALE) { - $filename = 'app/Locale/'.$fileInfo->getFilename().'/translations.php'; echo $fileInfo->getFilename().' ('.$filename.')'.PHP_EOL; @@ -42,11 +40,9 @@ class LocaleSync extends Base $output .= 'return array('.PHP_EOL; foreach ($reference as $key => $value) { - if (! empty($outdated[$key])) { $output .= " '".str_replace("'", "\'", $key)."' => '".str_replace("'", "\'", $outdated[$key])."',\n"; - } - else { + } else { $output .= " // '".str_replace("'", "\'", $key)."' => '',\n"; } } diff --git a/app/Controller/Action.php b/app/Controller/Action.php index 8e31fb30..37d1c248 100644 --- a/app/Controller/Action.php +++ b/app/Controller/Action.php @@ -115,14 +115,12 @@ class Action extends Base */ private function doCreation(array $project, array $values) { - list($valid,) = $this->action->validateCreation($values); + list($valid, ) = $this->action->validateCreation($values); if ($valid) { - if ($this->action->create($values) !== false) { $this->session->flash(t('Your automatic action have been created successfully.')); - } - else { + } else { $this->session->flashError(t('Unable to create your automatic action.')); } } diff --git a/app/Controller/App.php b/app/Controller/App.php index 3f3f0176..01a74c7a 100644 --- a/app/Controller/App.php +++ b/app/Controller/App.php @@ -236,8 +236,7 @@ class App extends Base // Search by task id or by title if (ctype_digit($search)) { $filter->filterById($search); - } - else { + } else { $filter->filterByTitle($search); } diff --git a/app/Controller/Auth.php b/app/Controller/Auth.php index b40811f4..95ad8d9e 100644 --- a/app/Controller/Auth.php +++ b/app/Controller/Auth.php @@ -43,7 +43,6 @@ class Auth extends Base list($valid, $errors) = $this->authentication->validateForm($values); if ($valid) { - if (! empty($this->session['login_redirect']) && ! filter_var($this->session['login_redirect'], FILTER_VALIDATE_URL)) { $redirect = $this->session['login_redirect']; unset($this->session['login_redirect']); diff --git a/app/Controller/Base.php b/app/Controller/Base.php index 8883a676..1efd4566 100644 --- a/app/Controller/Base.php +++ b/app/Controller/Base.php @@ -60,7 +60,6 @@ abstract class Base extends \Kanboard\Core\Base public function __destruct() { if (DEBUG) { - foreach ($this->container['db']->getLogMessages() as $message) { $this->container['logger']->debug($message); } @@ -123,7 +122,6 @@ abstract class Base extends \Kanboard\Core\Base public function handleAuthentication() { if (! $this->authentication->isAuthenticated()) { - if ($this->request->isAjax()) { $this->response->text('Not Authorized', 401); } @@ -143,7 +141,6 @@ abstract class Base extends \Kanboard\Core\Base $ignore = ($controller === 'twofactor' && in_array($action, array('code', 'check'))) || ($controller === 'auth' && $action === 'logout'); if ($ignore === false && $this->userSession->has2FA() && ! $this->userSession->check2FA()) { - if ($this->request->isAjax()) { $this->response->text('Not Authorized', 401); } diff --git a/app/Controller/Board.php b/app/Controller/Board.php index 06c9a2ff..2d75db89 100644 --- a/app/Controller/Board.php +++ b/app/Controller/Board.php @@ -239,12 +239,11 @@ class Board extends Base { $values = $this->request->getValues(); - list($valid,) = $this->taskValidator->validateAssigneeModification($values); + list($valid, ) = $this->taskValidator->validateAssigneeModification($values); if ($valid && $this->taskModification->update($values)) { $this->session->flash(t('Task updated successfully.')); - } - else { + } else { $this->session->flashError(t('Unable to update your task.')); } @@ -277,12 +276,11 @@ class Board extends Base { $values = $this->request->getValues(); - list($valid,) = $this->taskValidator->validateCategoryModification($values); + list($valid, ) = $this->taskValidator->validateCategoryModification($values); if ($valid && $this->taskModification->update($values)) { $this->session->flash(t('Task updated successfully.')); - } - else { + } else { $this->session->flashError(t('Unable to update your task.')); } @@ -365,8 +363,7 @@ class Board extends Base if ($this->request->isAjax()) { $this->response->html($this->renderBoard($project_id)); - } - else { + } else { $this->response->redirect($this->helper->url->to('board', 'show', array('project_id' => $project_id))); } } diff --git a/app/Controller/Calendar.php b/app/Controller/Calendar.php index 131d87aa..67a402d3 100644 --- a/app/Controller/Calendar.php +++ b/app/Controller/Calendar.php @@ -44,8 +44,7 @@ class Calendar extends Base // Tasks if ($this->config->get('calendar_project_tasks', 'date_started') === 'date_creation') { $events = $filter->copy()->filterByCreationDateRange($start, $end)->setColumns('date_creation', 'date_completed')->format(); - } - else { + } else { $events = $filter->copy()->filterByStartDateRange($start, $end)->setColumns('date_started', 'date_completed')->format(); } @@ -79,8 +78,7 @@ class Calendar extends Base // Tasks if ($this->config->get('calendar_user_tasks', 'date_started') === 'date_creation') { $events = array_merge($events, $filter->copy()->filterByCreationDateRange($start, $end)->setColumns('date_creation', 'date_completed')->format()); - } - else { + } else { $events = array_merge($events, $filter->copy()->filterByStartDateRange($start, $end)->setColumns('date_started', 'date_completed')->format()); } @@ -106,7 +104,6 @@ class Calendar extends Base public function save() { if ($this->request->isAjax() && $this->request->isPost()) { - $values = $this->request->getJson(); $this->taskModification->update(array( diff --git a/app/Controller/Category.php b/app/Controller/Category.php index 065da80b..4aefd9fe 100644 --- a/app/Controller/Category.php +++ b/app/Controller/Category.php @@ -60,12 +60,10 @@ class Category extends Base list($valid, $errors) = $this->category->validateCreation($values); if ($valid) { - if ($this->category->create($values)) { $this->session->flash(t('Your category have been created successfully.')); $this->response->redirect($this->helper->url->to('category', 'index', array('project_id' => $project['id']))); - } - else { + } else { $this->session->flashError(t('Unable to create your category.')); } } @@ -104,12 +102,10 @@ class Category extends Base list($valid, $errors) = $this->category->validateModification($values); if ($valid) { - if ($this->category->update($values)) { $this->session->flash(t('Your category have been updated successfully.')); $this->response->redirect($this->helper->url->to('category', 'index', array('project_id' => $project['id']))); - } - else { + } else { $this->session->flashError(t('Unable to update your category.')); } } diff --git a/app/Controller/Column.php b/app/Controller/Column.php index a07a1fe1..d28fb293 100644 --- a/app/Controller/Column.php +++ b/app/Controller/Column.php @@ -54,12 +54,10 @@ class Column extends Base list($valid, $errors) = $this->board->validateCreation($data); if ($valid) { - if ($this->board->addColumn($project['id'], $data['title'], $data['task_limit'], $data['description'])) { $this->session->flash(t('Board updated successfully.')); $this->response->redirect($this->helper->url->to('column', 'index', array('project_id' => $project['id']))); - } - else { + } else { $this->session->flashError(t('Unable to update this board.')); } } @@ -99,12 +97,10 @@ class Column extends Base list($valid, $errors) = $this->board->validateModification($values); if ($valid) { - if ($this->board->updateColumn($values['id'], $values['title'], $values['task_limit'], $values['description'])) { $this->session->flash(t('Board updated successfully.')); $this->response->redirect($this->helper->url->to('column', 'index', array('project_id' => $project['id']))); - } - else { + } else { $this->session->flashError(t('Unable to update this board.')); } } @@ -160,8 +156,7 @@ class Column extends Base if (! empty($column) && $this->board->removeColumn($column['id'])) { $this->session->flash(t('Column removed successfully.')); - } - else { + } else { $this->session->flashError(t('Unable to remove this column.')); } diff --git a/app/Controller/Comment.php b/app/Controller/Comment.php index 90d9d6df..d6cbbf1e 100644 --- a/app/Controller/Comment.php +++ b/app/Controller/Comment.php @@ -81,11 +81,9 @@ class Comment extends Base list($valid, $errors) = $this->comment->validateCreation($values); if ($valid) { - if ($this->comment->create($values)) { $this->session->flash(t('Comment added successfully.')); - } - else { + } else { $this->session->flashError(t('Unable to create your comment.')); } @@ -132,11 +130,9 @@ class Comment extends Base list($valid, $errors) = $this->comment->validateModification($values); if ($valid) { - if ($this->comment->update($values)) { $this->session->flash(t('Comment updated successfully.')); - } - else { + } else { $this->session->flashError(t('Unable to update your comment.')); } @@ -176,8 +172,7 @@ class Comment extends Base if ($this->comment->remove($comment['id'])) { $this->session->flash(t('Comment removed successfully.')); - } - else { + } else { $this->session->flashError(t('Unable to remove this comment.')); } diff --git a/app/Controller/Config.php b/app/Controller/Config.php index ba3c690a..9a376b36 100644 --- a/app/Controller/Config.php +++ b/app/Controller/Config.php @@ -37,7 +37,6 @@ class Config extends Base private function common($redirect) { if ($this->request->isPost()) { - $values = $this->request->getValues(); switch ($redirect) { @@ -55,8 +54,7 @@ class Config extends Base if ($this->config->save($values)) { $this->config->reload(); $this->session->flash(t('Settings saved successfully.')); - } - else { + } else { $this->session->flashError(t('Unable to save your settings.')); } diff --git a/app/Controller/Currency.php b/app/Controller/Currency.php index d3f9de5f..9d6b0249 100644 --- a/app/Controller/Currency.php +++ b/app/Controller/Currency.php @@ -54,12 +54,10 @@ class Currency extends Base list($valid, $errors) = $this->currency->validate($values); if ($valid) { - if ($this->currency->create($values['currency'], $values['rate'])) { $this->session->flash(t('The currency rate have been added successfully.')); $this->response->redirect($this->helper->url->to('currency', 'index')); - } - else { + } else { $this->session->flashError(t('Unable to add this currency rate.')); } } @@ -79,8 +77,7 @@ class Currency extends Base if ($this->config->save($values)) { $this->config->reload(); $this->session->flash(t('Settings saved successfully.')); - } - else { + } else { $this->session->flashError(t('Unable to save your settings.')); } diff --git a/app/Controller/Customfilter.php b/app/Controller/Customfilter.php index 26e6cc87..a152c668 100644 --- a/app/Controller/Customfilter.php +++ b/app/Controller/Customfilter.php @@ -46,8 +46,7 @@ class Customfilter extends Base if ($this->customFilter->create($values)) { $this->session->flash(t('Your custom filter have been created successfully.')); $this->response->redirect($this->helper->url->to('customfilter', 'index', array('project_id' => $project['id']))); - } - else { + } else { $this->session->flashError(t('Unable to create your custom filter.')); } } @@ -126,8 +125,7 @@ class Customfilter extends Base if ($this->customFilter->update($values)) { $this->session->flash(t('Your custom filter have been updated successfully.')); $this->response->redirect($this->helper->url->to('customfilter', 'index', array('project_id' => $project['id']))); - } - else { + } else { $this->session->flashError(t('Unable to update custom filter.')); } } diff --git a/app/Controller/Doc.php b/app/Controller/Doc.php index 282f5d15..32413048 100644 --- a/app/Controller/Doc.php +++ b/app/Controller/Doc.php @@ -16,7 +16,7 @@ class Doc extends Base { $url = $this->helper->url; $data = file_get_contents($filename); - list($title,) = explode("\n", $data, 2); + list($title, ) = explode("\n", $data, 2); $replaceUrl = function (array $matches) use ($url) { return '('.$url->to('doc', 'show', array('file' => str_replace('.markdown', '', $matches[1]))).')'; diff --git a/app/Controller/File.php b/app/Controller/File.php index 673e2669..3aadf076 100644 --- a/app/Controller/File.php +++ b/app/Controller/File.php @@ -22,7 +22,6 @@ class File extends Base $task = $this->getTask(); if ($this->request->isPost() && $this->file->uploadScreenshot($task['project_id'], $task['id'], $this->request->getValue('screenshot')) !== false) { - $this->session->flash(t('Screenshot uploaded successfully.')); if ($this->request->getStringParam('redirect') === 'board') { @@ -77,7 +76,6 @@ class File extends Base public function download() { try { - $task = $this->getTask(); $file = $this->file->getById($this->request->getIntegerParam('file_id')); @@ -87,8 +85,7 @@ class File extends Base $this->response->forceDownload($file['name']); $this->objectStorage->output($file['path']); - } - catch (ObjectStorageException $e) { + } catch (ObjectStorageException $e) { $this->logger->error($e->getMessage()); } } @@ -119,7 +116,6 @@ class File extends Base public function image() { try { - $task = $this->getTask(); $file = $this->file->getById($this->request->getIntegerParam('file_id')); @@ -129,8 +125,7 @@ class File extends Base $this->response->contentType($this->file->getImageMimeType($file['name'])); $this->objectStorage->output($file['path']); - } - catch (ObjectStorageException $e) { + } catch (ObjectStorageException $e) { $this->logger->error($e->getMessage()); } } @@ -143,7 +138,6 @@ class File extends Base public function thumbnail() { try { - $task = $this->getTask(); $file = $this->file->getById($this->request->getIntegerParam('file_id')); @@ -153,8 +147,7 @@ class File extends Base $this->response->contentType('image/jpeg'); $this->objectStorage->output($this->file->getThumbnailPath($file['path'])); - } - catch (ObjectStorageException $e) { + } catch (ObjectStorageException $e) { $this->logger->error($e->getMessage()); } } diff --git a/app/Controller/Gantt.php b/app/Controller/Gantt.php index dd02626f..24d94f02 100644 --- a/app/Controller/Gantt.php +++ b/app/Controller/Gantt.php @@ -19,8 +19,7 @@ class Gantt extends Base { if ($this->userSession->isAdmin()) { $project_ids = $this->project->getAllIds(); - } - else { + } else { $project_ids = $this->projectPermission->getMemberProjectIds($this->userSession->getId()); } @@ -62,8 +61,7 @@ class Gantt extends Base if ($sorting === 'date') { $filter->getQuery()->asc(TaskModel::TABLE.'.date_started')->asc(TaskModel::TABLE.'.date_creation'); - } - else { + } else { $filter->getQuery()->asc('column_position')->asc(TaskModel::TABLE.'.position'); } @@ -134,14 +132,12 @@ class Gantt extends Base list($valid, $errors) = $this->taskValidator->validateCreation($values); if ($valid) { - $task_id = $this->taskCreation->create($values); if ($task_id !== false) { $this->session->flash(t('Task created successfully.')); $this->response->redirect($this->helper->url->to('gantt', 'project', array('project_id' => $project['id']))); - } - else { + } else { $this->session->flashError(t('Unable to create your task.')); } } diff --git a/app/Controller/Ical.php b/app/Controller/Ical.php index ee2b1518..f8e9e25f 100644 --- a/app/Controller/Ical.php +++ b/app/Controller/Ical.php @@ -89,8 +89,7 @@ class Ical extends Base ->setColumns('date_creation', 'date_completed') ->setCalendar($calendar) ->addDateTimeEvents(); - } - else { + } else { $filter ->copy() ->filterByStartDateRange($start, $end) diff --git a/app/Controller/Link.php b/app/Controller/Link.php index 73cd95f9..0eb3d679 100644 --- a/app/Controller/Link.php +++ b/app/Controller/Link.php @@ -70,12 +70,10 @@ class Link extends Base list($valid, $errors) = $this->link->validateCreation($values); if ($valid) { - if ($this->link->create($values['label'], $values['opposite_label']) !== false) { $this->session->flash(t('Link added successfully.')); $this->response->redirect($this->helper->url->to('link', 'index')); - } - else { + } else { $this->session->flashError(t('Unable to create your link.')); } } @@ -116,8 +114,7 @@ class Link extends Base if ($this->link->update($values)) { $this->session->flash(t('Link updated successfully.')); $this->response->redirect($this->helper->url->to('link', 'index')); - } - else { + } else { $this->session->flashError(t('Unable to update your link.')); } } @@ -152,8 +149,7 @@ class Link extends Base if ($this->link->remove($link['id'])) { $this->session->flash(t('Link removed successfully.')); - } - else { + } else { $this->session->flashError(t('Unable to remove this link.')); } diff --git a/app/Controller/Oauth.php b/app/Controller/Oauth.php index d9fb513b..8c701cf7 100644 --- a/app/Controller/Oauth.php +++ b/app/Controller/Oauth.php @@ -52,8 +52,7 @@ class Oauth extends Base if ($this->authentication->backend($backend)->unlink($this->userSession->getId())) { $this->session->flash(t('Your external account is not linked anymore to your profile.')); - } - else { + } else { $this->session->flashError(t('Unable to unlink your external account.')); } @@ -71,8 +70,7 @@ class Oauth extends Base if (! empty($code)) { $this->step2($backend, $code); - } - else { + } else { $this->response->redirect($this->authentication->backend($backend)->getService()->getAuthorizationUrl()); } } @@ -102,8 +100,7 @@ class Oauth extends Base { if (empty($profile)) { $this->session->flashError(t('External authentication failed')); - } - else { + } else { $this->session->flash(t('Your external account is linked to your profile successfully.')); $this->authentication->backend($backend)->updateUser($this->userSession->getId(), $profile); } @@ -120,8 +117,7 @@ class Oauth extends Base { if (! empty($profile) && $this->authentication->backend($backend)->authenticate($profile['id'])) { $this->response->redirect($this->helper->url->to('app', 'index')); - } - else { + } else { $this->response->html($this->template->layout('auth/index', array( 'errors' => array('login' => t('External authentication failed')), 'values' => array(), diff --git a/app/Controller/Project.php b/app/Controller/Project.php index 5a3edf7a..af01ea77 100644 --- a/app/Controller/Project.php +++ b/app/Controller/Project.php @@ -19,8 +19,7 @@ class Project extends Base { if ($this->userSession->isAdmin()) { $project_ids = $this->project->getAllIds(); - } - else { + } else { $project_ids = $this->projectPermission->getMemberProjectIds($this->userSession->getId()); } @@ -68,13 +67,11 @@ class Project extends Base $switch = $this->request->getStringParam('switch'); if ($switch === 'enable' || $switch === 'disable') { - $this->checkCSRFParam(); if ($this->project->{$switch.'PublicAccess'}($project['id'])) { $this->session->flash(t('Project updated successfully.')); - } - else { + } else { $this->session->flashError(t('Unable to update this project.')); } @@ -145,8 +142,7 @@ class Project extends Base if (! $this->helper->user->isProjectAdministrationAllowed($project['id'])) { unset($values['is_private']); } - } - else if ($project['is_private'] == 1 && ! isset($values['is_private'])) { + } elseif ($project['is_private'] == 1 && ! isset($values['is_private'])) { if ($this->helper->user->isProjectAdministrationAllowed($project['id'])) { $values += array('is_private' => 0); } @@ -155,12 +151,10 @@ class Project extends Base list($valid, $errors) = $this->project->validateModification($values); if ($valid) { - if ($this->project->update($values)) { $this->session->flash(t('Project updated successfully.')); $this->response->redirect($this->helper->url->to('project', 'edit', array('project_id' => $project['id']))); - } - else { + } else { $this->session->flashError(t('Unable to update this project.')); } } @@ -193,14 +187,12 @@ class Project extends Base { $project = $this->getProject(); $values = $this->request->getValues() + array('is_everybody_allowed' => 0); - list($valid,) = $this->projectPermission->validateProjectModification($values); + list($valid, ) = $this->projectPermission->validateProjectModification($values); if ($valid) { - if ($this->project->update($values)) { $this->session->flash(t('Project updated successfully.')); - } - else { + } else { $this->session->flashError(t('Unable to update this project.')); } } @@ -216,14 +208,12 @@ class Project extends Base public function allow() { $values = $this->request->getValues(); - list($valid,) = $this->projectPermission->validateUserModification($values); + list($valid, ) = $this->projectPermission->validateUserModification($values); if ($valid) { - if ($this->projectPermission->addMember($values['project_id'], $values['user_id'])) { $this->session->flash(t('Project updated successfully.')); - } - else { + } else { $this->session->flashError(t('Unable to update this project.')); } } @@ -246,14 +236,12 @@ class Project extends Base 'is_owner' => $this->request->getIntegerParam('is_owner'), ); - list($valid,) = $this->projectPermission->validateUserModification($values); + list($valid, ) = $this->projectPermission->validateUserModification($values); if ($valid) { - if ($this->projectPermission->changeRole($values['project_id'], $values['user_id'], $values['is_owner'])) { $this->session->flash(t('Project updated successfully.')); - } - else { + } else { $this->session->flashError(t('Unable to update this project.')); } } @@ -275,14 +263,12 @@ class Project extends Base 'user_id' => $this->request->getIntegerParam('user_id'), ); - list($valid,) = $this->projectPermission->validateUserModification($values); + list($valid, ) = $this->projectPermission->validateUserModification($values); if ($valid) { - if ($this->projectPermission->revokeMember($values['project_id'], $values['user_id'])) { $this->session->flash(t('Project updated successfully.')); - } - else { + } else { $this->session->flashError(t('Unable to update this project.')); } } @@ -300,7 +286,6 @@ class Project extends Base $project = $this->getProject(); if ($this->request->getStringParam('remove') === 'yes') { - $this->checkCSRFParam(); if ($this->project->remove($project['id'])) { @@ -356,7 +341,6 @@ class Project extends Base $project = $this->getProject(); if ($this->request->getStringParam('disable') === 'yes') { - $this->checkCSRFParam(); if ($this->project->disable($project['id'])) { @@ -384,7 +368,6 @@ class Project extends Base $project = $this->getProject(); if ($this->request->getStringParam('enable') === 'yes') { - $this->checkCSRFParam(); if ($this->project->enable($project['id'])) { @@ -431,7 +414,6 @@ class Project extends Base list($valid, $errors) = $this->project->validateCreation($values); if ($valid) { - $project_id = $this->project->create($values, $this->userSession->getId(), true); if ($project_id > 0) { diff --git a/app/Controller/Projectuser.php b/app/Controller/Projectuser.php index 5729d662..18829b3c 100644 --- a/app/Controller/Projectuser.php +++ b/app/Controller/Projectuser.php @@ -36,8 +36,7 @@ class Projectuser extends Base if ($this->userSession->isAdmin()) { $project_ids = $this->project->getAllIds(); - } - else { + } else { $project_ids = $this->projectPermission->getMemberProjectIds($this->userSession->getId()); } diff --git a/app/Controller/Search.php b/app/Controller/Search.php index 67e2df82..08dda1c8 100644 --- a/app/Controller/Search.php +++ b/app/Controller/Search.php @@ -23,7 +23,6 @@ class Search extends Base ->setDirection('DESC'); if ($search !== '') { - $query = $this ->taskFilter ->search($search) diff --git a/app/Controller/Subtask.php b/app/Controller/Subtask.php index 79b74896..4ef3e74e 100644 --- a/app/Controller/Subtask.php +++ b/app/Controller/Subtask.php @@ -66,11 +66,9 @@ class Subtask extends Base list($valid, $errors) = $this->subtask->validateCreation($values); if ($valid) { - if ($this->subtask->create($values)) { $this->session->flash(t('Sub-task added successfully.')); - } - else { + } else { $this->session->flashError(t('Unable to create your sub-task.')); } @@ -118,11 +116,9 @@ class Subtask extends Base list($valid, $errors) = $this->subtask->validateModification($values); if ($valid) { - if ($this->subtask->update($values)) { $this->session->flash(t('Sub-task updated successfully.')); - } - else { + } else { $this->session->flashError(t('Unable to update your sub-task.')); } @@ -161,8 +157,7 @@ class Subtask extends Base if ($this->subtask->remove($subtask['id'])) { $this->session->flash(t('Sub-task removed successfully.')); - } - else { + } else { $this->session->flashError(t('Unable to remove this sub-task.')); } @@ -183,7 +178,6 @@ class Subtask extends Base $this->subtask->toggleStatus($subtask['id']); if ($redirect === 'board') { - $this->session['has_subtask_inprogress'] = $this->subtask->hasSubtaskInProgress($this->userSession->getId()); $this->response->html($this->template->render('board/tooltip_subtasks', array( diff --git a/app/Controller/Swimlane.php b/app/Controller/Swimlane.php index 69fdf3df..0b29f598 100644 --- a/app/Controller/Swimlane.php +++ b/app/Controller/Swimlane.php @@ -63,12 +63,10 @@ class Swimlane extends Base list($valid, $errors) = $this->swimlane->validateCreation($values); if ($valid) { - if ($this->swimlane->create($values)) { $this->session->flash(t('Your swimlane have been created successfully.')); $this->response->redirect($this->helper->url->to('swimlane', 'index', array('project_id' => $project['id']))); - } - else { + } else { $this->session->flashError(t('Unable to create your swimlane.')); } } @@ -86,15 +84,13 @@ class Swimlane extends Base $project = $this->getProject(); $values = $this->request->getValues() + array('show_default_swimlane' => 0); - list($valid,) = $this->swimlane->validateDefaultModification($values); + list($valid, ) = $this->swimlane->validateDefaultModification($values); if ($valid) { - if ($this->swimlane->updateDefault($values)) { $this->session->flash(t('The default swimlane have been updated successfully.')); $this->response->redirect($this->helper->url->to('swimlane', 'index', array('project_id' => $project['id']))); - } - else { + } else { $this->session->flashError(t('Unable to update this swimlane.')); } } @@ -136,8 +132,7 @@ class Swimlane extends Base if ($this->swimlane->update($values)) { $this->session->flash(t('Swimlane updated successfully.')); $this->response->redirect($this->helper->url->to('swimlane', 'index', array('project_id' => $project['id']))); - } - else { + } else { $this->session->flashError(t('Unable to update this swimlane.')); } } diff --git a/app/Controller/Task.php b/app/Controller/Task.php index ab7a8a9c..894802d8 100644 --- a/app/Controller/Task.php +++ b/app/Controller/Task.php @@ -156,7 +156,6 @@ class Task extends Base } if ($this->request->getStringParam('confirmation') === 'yes') { - $this->checkCSRFParam(); if ($this->task->remove($task['id'])) { diff --git a/app/Controller/TaskImport.php b/app/Controller/TaskImport.php index 387374c5..0e9d2169 100644 --- a/app/Controller/TaskImport.php +++ b/app/Controller/TaskImport.php @@ -53,8 +53,7 @@ class TaskImport extends Base if ($this->taskImport->counter > 0) { $this->session->flash(t('%d task(s) have been imported successfully.', $this->taskImport->counter)); - } - else { + } else { $this->session->flashError(t('Nothing have been imported!')); } diff --git a/app/Controller/Taskcreation.php b/app/Controller/Taskcreation.php index db33a130..e47cd1b7 100644 --- a/app/Controller/Taskcreation.php +++ b/app/Controller/Taskcreation.php @@ -22,7 +22,6 @@ class Taskcreation extends Base $swimlanes_list = $this->swimlane->getList($project['id'], false, true); if (empty($values)) { - $values = array( 'swimlane_id' => $this->request->getIntegerParam('swimlane_id', key($swimlanes_list)), 'column_id' => $this->request->getIntegerParam('column_id'), @@ -62,8 +61,7 @@ class Taskcreation extends Base if ($valid && $this->taskCreation->create($values)) { $this->session->flash(t('Task created successfully.')); $this->afterSave($project, $values); - } - else { + } else { $this->session->flashError(t('Unable to create your task.')); } @@ -79,8 +77,7 @@ class Taskcreation extends Base if (! $this->request->isAjax()) { $this->response->redirect($this->helper->url->to('taskcreation', 'create', $values)); } - } - else { + } else { $this->response->redirect($this->helper->url->to('board', 'show', array('project_id' => $project['id']))); } } diff --git a/app/Controller/Taskduplication.php b/app/Controller/Taskduplication.php index 2eea1567..79f498fc 100644 --- a/app/Controller/Taskduplication.php +++ b/app/Controller/Taskduplication.php @@ -20,7 +20,6 @@ class Taskduplication extends Base $task = $this->getTask(); if ($this->request->getStringParam('confirmation') === 'yes') { - $this->checkCSRFParam(); $task_id = $this->taskDuplication->duplicate($task['id']); @@ -48,9 +47,8 @@ class Taskduplication extends Base $task = $this->getTask(); if ($this->request->isPost()) { - $values = $this->request->getValues(); - list($valid,) = $this->taskValidator->validateProjectModification($values); + list($valid, ) = $this->taskValidator->validateProjectModification($values); if ($valid && $this->taskDuplication->moveToProject($task['id'], $values['project_id'], @@ -58,7 +56,6 @@ class Taskduplication extends Base $values['column_id'], $values['category_id'], $values['owner_id'])) { - $this->session->flash(t('Task updated successfully.')); $this->response->redirect($this->helper->url->to('task', 'show', array('project_id' => $values['project_id'], 'task_id' => $task['id']))); } @@ -79,9 +76,8 @@ class Taskduplication extends Base $task = $this->getTask(); if ($this->request->isPost()) { - $values = $this->request->getValues(); - list($valid,) = $this->taskValidator->validateProjectModification($values); + list($valid, ) = $this->taskValidator->validateProjectModification($values); if ($valid) { $task_id = $this->taskDuplication->duplicateToProject( @@ -125,8 +121,7 @@ class Taskduplication extends Base $values = $this->taskDuplication->checkDestinationProjectValues($task); $values['project_id'] = $dst_project_id; - } - else { + } else { $swimlanes_list = array(); $columns_list = array(); $categories_list = array(); diff --git a/app/Controller/Tasklink.php b/app/Controller/Tasklink.php index c9649cc6..587769ee 100644 --- a/app/Controller/Tasklink.php +++ b/app/Controller/Tasklink.php @@ -72,7 +72,6 @@ class Tasklink extends Base list($valid, $errors) = $this->taskLink->validateCreation($values); if ($valid) { - if ($this->taskLink->create($values['task_id'], $values['opposite_task_id'], $values['link_id'])) { $this->session->flash(t('Link added successfully.')); @@ -129,7 +128,6 @@ class Tasklink extends Base list($valid, $errors) = $this->taskLink->validateModification($values); if ($valid) { - if ($this->taskLink->update($values['id'], $values['task_id'], $values['opposite_task_id'], $values['link_id'])) { $this->session->flash(t('Link updated successfully.')); $this->response->redirect($this->helper->url->to('task', 'show', array('task_id' => $task['id'], 'project_id' => $task['project_id'])).'#links'); @@ -162,15 +160,14 @@ class Tasklink extends Base * * @access public */ - public function remove() + public function remove() { $this->checkCSRFParam(); $task = $this->getTask(); if ($this->taskLink->remove($this->request->getIntegerParam('link_id'))) { $this->session->flash(t('Link removed successfully.')); - } - else { + } else { $this->session->flashError(t('Unable to remove this link.')); } diff --git a/app/Controller/Taskmodification.php b/app/Controller/Taskmodification.php index 6bd2b25e..b1105dcc 100644 --- a/app/Controller/Taskmodification.php +++ b/app/Controller/Taskmodification.php @@ -32,12 +32,11 @@ class Taskmodification extends Base $task = $this->getTask(); $values = $this->request->getValues(); - list($valid,) = $this->taskValidator->validateTimeModification($values); + list($valid, ) = $this->taskValidator->validateTimeModification($values); if ($valid && $this->taskModification->update($values)) { $this->session->flash(t('Task updated successfully.')); - } - else { + } else { $this->session->flashError(t('Unable to update your task.')); } @@ -55,29 +54,24 @@ class Taskmodification extends Base $ajax = $this->request->isAjax() || $this->request->getIntegerParam('ajax'); if ($this->request->isPost()) { - $values = $this->request->getValues(); list($valid, $errors) = $this->taskValidator->validateDescriptionCreation($values); if ($valid) { - if ($this->taskModification->update($values)) { $this->session->flash(t('Task updated successfully.')); - } - else { + } else { $this->session->flashError(t('Unable to update your task.')); } if ($ajax) { $this->response->redirect($this->helper->url->to('board', 'show', array('project_id' => $task['project_id']))); - } - else { + } else { $this->response->redirect($this->helper->url->to('task', 'show', array('project_id' => $task['project_id'], 'task_id' => $task['id']))); } } - } - else { + } else { $values = $task; $errors = array(); } @@ -91,8 +85,7 @@ class Taskmodification extends Base if ($ajax) { $this->response->html($this->template->render('task_modification/edit_description', $params)); - } - else { + } else { $this->response->html($this->taskLayout('task_modification/edit_description', $params)); } } @@ -127,8 +120,7 @@ class Taskmodification extends Base if ($ajax) { $html = $this->template->render('task_modification/edit_task', $params); - } - else { + } else { $html = $this->taskLayout('task_modification/edit_task', $params); } @@ -152,12 +144,10 @@ class Taskmodification extends Base if ($this->request->isAjax()) { $this->response->redirect($this->helper->url->to('board', 'show', array('project_id' => $task['project_id']))); - } - else { + } else { $this->response->redirect($this->helper->url->to('task', 'show', array('project_id' => $task['project_id'], 'task_id' => $task['id']))); } - } - else { + } else { $this->session->flashError(t('Unable to update your task.')); $this->edit($values, $errors); } @@ -173,24 +163,20 @@ class Taskmodification extends Base $task = $this->getTask(); if ($this->request->isPost()) { - $values = $this->request->getValues(); list($valid, $errors) = $this->taskValidator->validateEditRecurrence($values); if ($valid) { - if ($this->taskModification->update($values)) { $this->session->flash(t('Task updated successfully.')); - } - else { + } else { $this->session->flashError(t('Unable to update your task.')); } $this->response->redirect($this->helper->url->to('task', 'show', array('project_id' => $task['project_id'], 'task_id' => $task['id']))); } - } - else { + } else { $values = $task; $errors = array(); } diff --git a/app/Controller/Taskstatus.php b/app/Controller/Taskstatus.php index b38a143f..c0421ea7 100644 --- a/app/Controller/Taskstatus.php +++ b/app/Controller/Taskstatus.php @@ -37,7 +37,6 @@ class Taskstatus extends Base private function changeStatus(array $task, $method, $success_message, $failure_message) { if ($this->request->getStringParam('confirmation') === 'yes') { - $this->checkCSRFParam(); if ($this->taskStatus->$method($task['id'])) { diff --git a/app/Controller/Timer.php b/app/Controller/Timer.php index b2096f9f..0267fcdd 100644 --- a/app/Controller/Timer.php +++ b/app/Controller/Timer.php @@ -24,8 +24,7 @@ class Timer extends Base if ($timer === 'start') { $this->subtaskTimeTracking->logStartTime($subtask_id, $this->userSession->getId()); - } - else if ($timer === 'stop') { + } elseif ($timer === 'stop') { $this->subtaskTimeTracking->logEndTime($subtask_id, $this->userSession->getId()); $this->subtaskTimeTracking->updateTaskTimeTracking($task_id); } diff --git a/app/Controller/Twofactor.php b/app/Controller/Twofactor.php index 029ee048..179241f8 100644 --- a/app/Controller/Twofactor.php +++ b/app/Controller/Twofactor.php @@ -63,8 +63,7 @@ class Twofactor extends User 'twofactor_activated' => 1, 'twofactor_secret' => GoogleAuthenticator::generateRandom(), )); - } - else { + } else { $this->user->update(array( 'id' => $user['id'], 'twofactor_activated' => 0, @@ -94,8 +93,7 @@ class Twofactor extends User if (! empty($values['code']) && $otp->checkTotp(Base32::decode($user['twofactor_secret']), $values['code'])) { $this->session->flash(t('The two factor authentication code is valid.')); - } - else { + } else { $this->session->flashError(t('The two factor authentication code is not valid.')); } @@ -119,8 +117,7 @@ class Twofactor extends User $this->session['2fa_validated'] = true; $this->session->flash(t('The two factor authentication code is valid.')); $this->response->redirect($this->helper->url->to('app', 'index')); - } - else { + } else { $this->session->flashError(t('The two factor authentication code is not valid.')); $this->response->redirect($this->helper->url->to('twofactor', 'code')); } @@ -148,7 +145,6 @@ class Twofactor extends User $user = $this->getUser(); if ($this->request->getStringParam('disable') === 'yes') { - $this->checkCSRFParam(); $this->user->update(array( diff --git a/app/Controller/User.php b/app/Controller/User.php index 7444ed82..85b80d79 100644 --- a/app/Controller/User.php +++ b/app/Controller/User.php @@ -86,7 +86,6 @@ class User extends Base list($valid, $errors) = $this->user->validateCreation($values); if ($valid) { - $project_id = empty($values['project_id']) ? 0 : $values['project_id']; unset($values['project_id']); @@ -101,8 +100,7 @@ class User extends Base $this->session->flash(t('User created successfully.')); $this->response->redirect($this->helper->url->to('user', 'show', array('user_id' => $user_id))); - } - else { + } else { $this->session->flashError(t('Unable to create your user.')); $values['project_id'] = $project_id; } @@ -240,7 +238,6 @@ class User extends Base $switch = $this->request->getStringParam('switch'); if ($switch === 'enable' || $switch === 'disable') { - $this->checkCSRFParam(); if ($this->user->{$switch.'PublicAccess'}($user['id'])) { @@ -270,16 +267,13 @@ class User extends Base $errors = array(); if ($this->request->isPost()) { - $values = $this->request->getValues(); list($valid, $errors) = $this->user->validatePasswordModification($values); if ($valid) { - if ($this->user->update($values)) { $this->session->flash(t('Password modified successfully.')); - } - else { + } else { $this->session->flashError(t('Unable to change the password.')); } @@ -308,13 +302,11 @@ class User extends Base unset($values['password']); if ($this->request->isPost()) { - $values = $this->request->getValues(); if ($this->userSession->isAdmin()) { $values += array('is_admin' => 0, 'is_project_admin' => 0); - } - else { + } else { // Regular users can't be admin if (isset($values['is_admin'])) { unset($values['is_admin']); @@ -328,11 +320,9 @@ class User extends Base list($valid, $errors) = $this->user->validateModification($values); if ($valid) { - if ($this->user->update($values)) { $this->session->flash(t('User updated successfully.')); - } - else { + } else { $this->session->flashError(t('Unable to update your user.')); } @@ -363,16 +353,13 @@ class User extends Base unset($values['password']); if ($this->request->isPost()) { - $values = $this->request->getValues() + array('disable_login_form' => 0, 'is_ldap_user' => 0); list($valid, $errors) = $this->user->validateModification($values); if ($valid) { - if ($this->user->update($values)) { $this->session->flash(t('User updated successfully.')); - } - else { + } else { $this->session->flashError(t('Unable to update your user.')); } @@ -397,7 +384,6 @@ class User extends Base $user = $this->getUser(); if ($this->request->getStringParam('confirmation') === 'yes') { - $this->checkCSRFParam(); if ($this->user->remove($user['id'])) { diff --git a/app/Controller/UserImport.php b/app/Controller/UserImport.php index 59defa0a..32b9a865 100644 --- a/app/Controller/UserImport.php +++ b/app/Controller/UserImport.php @@ -47,8 +47,7 @@ class UserImport extends Base if ($this->userImport->counter > 0) { $this->session->flash(t('%d user(s) have been imported successfully.', $this->userImport->counter)); - } - else { + } else { $this->session->flashError(t('Nothing have been imported!')); } diff --git a/app/Controller/Webhook.php b/app/Controller/Webhook.php index 1186680d..a7e9bde4 100644 --- a/app/Controller/Webhook.php +++ b/app/Controller/Webhook.php @@ -31,7 +31,7 @@ class Webhook extends Base 'category_id' => $this->request->getIntegerParam('category_id'), ); - list($valid,) = $this->taskValidator->validateCreation($values); + list($valid, ) = $this->taskValidator->validateCreation($values); if ($valid && $this->taskCreation->create($values)) { $this->response->text('OK'); diff --git a/app/Core/Csv.php b/app/Core/Csv.php index 37f51b27..7c6a4620 100644 --- a/app/Core/Csv.php +++ b/app/Core/Csv.php @@ -93,7 +93,8 @@ class Csv { if (! empty($value)) { $value = trim(strtolower($value)); - return $value === '1' || $value{0} === 't' ? 1 : 0; + return $value === '1' || $value{0} + === 't' ? 1 : 0; } return 0; @@ -187,8 +188,7 @@ class Csv foreach ($this->columns as $sql_name => $csv_name) { if (isset($row[$index])) { $line[$sql_name] = $row[$index]; - } - else { + } else { $line[$sql_name] = ''; } diff --git a/app/Core/DateParser.php b/app/Core/DateParser.php index 026cf305..6577af0f 100644 --- a/app/Core/DateParser.php +++ b/app/Core/DateParser.php @@ -214,8 +214,7 @@ class DateParser extends Base foreach ($fields as $field) { if (! empty($values[$field])) { $values[$field] = date($format, $values[$field]); - } - else { + } else { $values[$field] = ''; } } diff --git a/app/Core/HttpClient.php b/app/Core/HttpClient.php index 4ec5396e..7f4ea47a 100644 --- a/app/Core/HttpClient.php +++ b/app/Core/HttpClient.php @@ -131,8 +131,7 @@ class HttpClient extends Base if (is_resource($stream)) { $response = stream_get_contents($stream); - } - else { + } else { $this->container['logger']->error('HttpClient: request failed'); } diff --git a/app/Core/Lexer.php b/app/Core/Lexer.php index 92443c2c..ca2ef895 100644 --- a/app/Core/Lexer.php +++ b/app/Core/Lexer.php @@ -60,7 +60,6 @@ class Lexer $this->offset = 0; while (isset($input[$this->offset])) { - $result = $this->match(substr($input, $this->offset)); if ($result === false) { @@ -84,7 +83,6 @@ class Lexer { foreach ($this->tokenMap as $pattern => $name) { if (preg_match($pattern, $string, $matches)) { - $this->offset += strlen($matches[1]); return array( @@ -113,7 +111,6 @@ class Lexer ); while (false !== ($token = current($tokens))) { - switch ($token['token']) { case 'T_ASSIGNEE': case 'T_COLOR': diff --git a/app/Core/Mail/Client.php b/app/Core/Mail/Client.php index c7cfaab9..52caef73 100644 --- a/app/Core/Mail/Client.php +++ b/app/Core/Mail/Client.php @@ -87,7 +87,7 @@ class Client extends Base { $container = $this->container; - $this->transports[$transport] = function() use ($class, $container) { + $this->transports[$transport] = function () use ($class, $container) { return new $class($container); }; diff --git a/app/Core/Mail/Transport/Mail.php b/app/Core/Mail/Transport/Mail.php index ca06e208..4d833f8f 100644 --- a/app/Core/Mail/Transport/Mail.php +++ b/app/Core/Mail/Transport/Mail.php @@ -30,7 +30,6 @@ class Mail extends Base implements ClientInterface public function sendEmail($email, $name, $subject, $html, $author) { try { - $message = Swift_Message::newInstance() ->setSubject($subject) ->setFrom(array(MAIL_FROM => $author)) @@ -38,8 +37,7 @@ class Mail extends Base implements ClientInterface ->setTo(array($email => $name)); Swift_Mailer::newInstance($this->getTransport())->send($message); - } - catch (Swift_TransportException $e) { + } catch (Swift_TransportException $e) { $this->logger->error($e->getMessage()); } } diff --git a/app/Core/Markdown.php b/app/Core/Markdown.php index 4101a3b3..f08c486a 100644 --- a/app/Core/Markdown.php +++ b/app/Core/Markdown.php @@ -29,7 +29,6 @@ class Markdown extends Parsedown { // Replace task #123 by a link to the task if (! empty($this->link) && preg_match('!#(\d+)!i', $Excerpt['text'], $matches)) { - $url = $this->helper->href( $this->link['controller'], $this->link['action'], diff --git a/app/Core/OAuth2.php b/app/Core/OAuth2.php index ee6a7837..a5bbba1a 100644 --- a/app/Core/OAuth2.php +++ b/app/Core/OAuth2.php @@ -86,7 +86,6 @@ class OAuth2 extends Base public function getAccessToken($code) { if (empty($this->accessToken) && ! empty($code)) { - $params = array( 'code' => $code, 'client_id' => $this->clientId, diff --git a/app/Core/Paginator.php b/app/Core/Paginator.php index 763cb8b9..cfe89938 100644 --- a/app/Core/Paginator.php +++ b/app/Core/Paginator.php @@ -355,8 +355,7 @@ class Paginator $this->action, $this->getUrlParams($this->page - 1, $this->order, $this->direction) ); - } - else { + } else { $html .= '← '.t('Previous'); } @@ -382,8 +381,7 @@ class Paginator $this->action, $this->getUrlParams($this->page + 1, $this->order, $this->direction) ); - } - else { + } else { $html .= t('Next').' →'; } diff --git a/app/Core/Plugin/Base.php b/app/Core/Plugin/Base.php index e38ffee8..15265370 100644 --- a/app/Core/Plugin/Base.php +++ b/app/Core/Plugin/Base.php @@ -51,7 +51,7 @@ abstract class Base extends \Kanboard\Core\Base { $container = $this->container; - $this->container['dispatcher']->addListener($event, function() use ($container, $callback) { + $this->container['dispatcher']->addListener($event, function () use ($container, $callback) { call_user_func($callback, $container); }); } diff --git a/app/Core/Plugin/Loader.php b/app/Core/Plugin/Loader.php index ea512c4e..e68ba8e6 100644 --- a/app/Core/Plugin/Loader.php +++ b/app/Core/Plugin/Loader.php @@ -94,7 +94,6 @@ class Loader extends \Kanboard\Core\Base $current_version = $this->getSchemaVersion($plugin); try { - $this->db->startTransaction(); $this->db->getDriver()->disableForeignKeys(); @@ -109,8 +108,7 @@ class Loader extends \Kanboard\Core\Base $this->db->getDriver()->enableForeignKeys(); $this->db->closeTransaction(); $this->setSchemaVersion($plugin, $i - 1); - } - catch (PDOException $e) { + } catch (PDOException $e) { $this->db->cancelTransaction(); $this->db->getDriver()->enableForeignKeys(); die('Unable to migrate schema for the plugin: '.$plugin.' => '.$e->getMessage()); diff --git a/app/Core/Request.php b/app/Core/Request.php index f553d7cd..5eda2d02 100644 --- a/app/Core/Request.php +++ b/app/Core/Request.php @@ -218,11 +218,8 @@ class Request ); foreach ($keys as $key) { - if (isset($_SERVER[$key])) { - foreach (explode(',', $_SERVER[$key]) as $ip_address) { - $ip_address = trim($ip_address); if ($only_public) { @@ -231,9 +228,7 @@ class Request if (filter_var($ip_address, FILTER_VALIDATE_IP, FILTER_FLAG_NO_PRIV_RANGE | FILTER_FLAG_NO_RES_RANGE) !== false) { return $ip_address; } - } - else { - + } else { return $ip_address; } } diff --git a/app/Core/Response.php b/app/Core/Response.php index c27f0a1d..528a6302 100644 --- a/app/Core/Response.php +++ b/app/Core/Response.php @@ -68,8 +68,7 @@ class Response { if (isset($_SERVER['HTTP_X_REQUESTED_WITH']) && $_SERVER['HTTP_X_REQUESTED_WITH'] === 'XMLHttpRequest') { header('X-Ajax-Redirect: '.$url); - } - else { + } else { header('Location: '.$url); } diff --git a/app/Core/Router.php b/app/Core/Router.php index 8f366daf..f4453c71 100644 --- a/app/Core/Router.php +++ b/app/Core/Router.php @@ -127,17 +127,13 @@ class Router extends Base $count = count($parts); foreach ($this->paths as $route) { - if ($count === $route['count']) { - $params = array(); for ($i = 0; $i < $count; $i++) { - if ($route['pattern'][$i]{0} === ':') { $params[substr($route['pattern'][$i], 1)] = $parts[$i]; - } - else if ($route['pattern'][$i] !== $parts[$i]) { + } elseif ($route['pattern'][$i] !== $parts[$i]) { break; } } @@ -168,7 +164,6 @@ class Router extends Base } foreach ($this->urls[$controller][$action] as $pattern) { - if (array_diff_key($params, $pattern['params']) === array()) { $url = $pattern['path']; $i = 0; @@ -213,8 +208,7 @@ class Router extends Base $this->controller = $this->sanitize($_GET['controller'], 'app'); $this->action = $this->sanitize($_GET['action'], 'index'); $plugin = ! empty($_GET['plugin']) ? $this->sanitize($_GET['plugin'], '') : ''; - } - else { + } else { list($this->controller, $this->action) = $this->findRoute($this->getPath($uri, $query_string)); // TODO: add plugin for routes $plugin = ''; } diff --git a/app/Core/Security.php b/app/Core/Security.php index 126de2fd..54207ee1 100644 --- a/app/Core/Security.php +++ b/app/Core/Security.php @@ -10,7 +10,7 @@ namespace Kanboard\Core; */ class Security { - /** + /** * Generate a random token with different methods: openssl or /dev/urandom or fallback to uniqid() * * @static @@ -21,8 +21,7 @@ class Security { if (function_exists('openssl_random_pseudo_bytes')) { return bin2hex(\openssl_random_pseudo_bytes(30)); - } - else if (ini_get('open_basedir') === '' && strtoupper(substr(PHP_OS, 0, 3)) !== 'WIN') { + } elseif (ini_get('open_basedir') === '' && strtoupper(substr(PHP_OS, 0, 3)) !== 'WIN') { return hash('sha256', file_get_contents('/dev/urandom', false, null, 0, 30)); } diff --git a/app/Core/Template.php b/app/Core/Template.php index d1e0c25a..002b20b1 100644 --- a/app/Core/Template.php +++ b/app/Core/Template.php @@ -85,8 +85,7 @@ class Template extends Helper if (strpos($template_name, ':') !== false) { list($plugin, $template) = explode(':', $template_name); $path = __DIR__.'/../../plugins/'.ucfirst($plugin).'/Template/'.$template.'.php'; - } - else { + } else { $path = __DIR__.'/../Template/'.$template_name.'.php'; } diff --git a/app/Core/Tool.php b/app/Core/Tool.php index 1bd43a40..247fda1a 100644 --- a/app/Core/Tool.php +++ b/app/Core/Tool.php @@ -26,8 +26,8 @@ class Tool return ''; } - list($local_part,) = explode('@', $email); - list(,$identifier) = explode('+', $local_part); + list($local_part, ) = explode('@', $email); + list(, $identifier) = explode('+', $local_part); return $identifier; } @@ -83,14 +83,11 @@ class Tool $dst_width = $resize_width; $dst_height = floor($src_height * ($resize_width / $src_width)); $dst_image = imagecreatetruecolor($dst_width, $dst_height); - } - elseif ($resize_width == 0 && $resize_height > 0) { + } elseif ($resize_width == 0 && $resize_height > 0) { $dst_width = floor($src_width * ($resize_height / $src_height)); $dst_height = $resize_height; $dst_image = imagecreatetruecolor($dst_width, $dst_height); - } - else { - + } else { $src_ratio = $src_width / $src_height; $resize_ratio = $resize_width / $resize_height; @@ -99,8 +96,7 @@ class Tool $dst_height = floor($src_height * ($resize_width / $src_width)); $dst_y = ($dst_height - $resize_height) / 2 * (-1); - } - else { + } else { $dst_width = floor($src_width * ($resize_height / $src_height)); $dst_height = $resize_height; diff --git a/app/Core/Translator.php b/app/Core/Translator.php index 7dd67363..96a481f6 100644 --- a/app/Core/Translator.php +++ b/app/Core/Translator.php @@ -184,8 +184,7 @@ class Translator { if (isset(self::$locales[$identifier])) { return self::$locales[$identifier]; - } - else { + } else { return $default; } } diff --git a/app/Formatter/ProjectGanttFormatter.php b/app/Formatter/ProjectGanttFormatter.php index b629bdfa..17496088 100644 --- a/app/Formatter/ProjectGanttFormatter.php +++ b/app/Formatter/ProjectGanttFormatter.php @@ -31,9 +31,7 @@ class ProjectGanttFormatter extends Project implements FormatterInterface { if (empty($project_ids)) { $this->projects = array(); - } - else { - + } else { $this->projects = $this->db ->table(self::TABLE) ->asc('start_date') diff --git a/app/Formatter/TaskFilterICalendarFormatter.php b/app/Formatter/TaskFilterICalendarFormatter.php index bdf6b6c2..25b3aea0 100644 --- a/app/Formatter/TaskFilterICalendarFormatter.php +++ b/app/Formatter/TaskFilterICalendarFormatter.php @@ -56,7 +56,6 @@ class TaskFilterICalendarFormatter extends TaskFilterCalendarEvent implements Fo public function addDateTimeEvents() { foreach ($this->query->findAll() as $task) { - $start = new DateTime; $start->setTimestamp($task[$this->startColumn]); @@ -82,7 +81,6 @@ class TaskFilterICalendarFormatter extends TaskFilterCalendarEvent implements Fo public function addFullDayEvents() { foreach ($this->query->findAll() as $task) { - $date = new DateTime; $date->setTimestamp($task[$this->startColumn]); diff --git a/app/Helper/App.php b/app/Helper/App.php index 0e84f694..19801fa8 100644 --- a/app/Helper/App.php +++ b/app/Helper/App.php @@ -68,8 +68,7 @@ class App extends \Kanboard\Core\Base $html = '
'.$this->helper->e($this->session['flash_message']).'
'; unset($this->session['flash_message']); unset($this->session['flash_error_message']); - } - else if (isset($this->session['flash_error_message'])) { + } elseif (isset($this->session['flash_error_message'])) { $html = '
'.$this->helper->e($this->session['flash_error_message']).'
'; unset($this->session['flash_message']); unset($this->session['flash_error_message']); diff --git a/app/Helper/Dt.php b/app/Helper/Dt.php index e717a4c0..78002b1b 100644 --- a/app/Helper/Dt.php +++ b/app/Helper/Dt.php @@ -52,11 +52,9 @@ class Dt extends \Kanboard\Core\Base } if ($diff < 1200) { return t('<30m'); - } - else if ($diff < 3600) { + } elseif ($diff < 3600) { return t('<1h'); - } - else if ($diff < 86400) { + } elseif ($diff < 86400) { return '~'.t('%dh', $diff / 3600); } diff --git a/app/Helper/File.php b/app/Helper/File.php index b0a7f675..d2cdfc6a 100644 --- a/app/Helper/File.php +++ b/app/Helper/File.php @@ -17,8 +17,8 @@ class File extends \Kanboard\Core\Base * @param string $filename Filename * @return string Font-Awesome-Icon-Name */ - public function icon($filename){ - + public function icon($filename) + { $extension = strtolower(pathinfo($filename, PATHINFO_EXTENSION)); switch ($extension) { diff --git a/app/Helper/Form.php b/app/Helper/Form.php index 92d07ccc..5f19f2a8 100644 --- a/app/Helper/Form.php +++ b/app/Helper/Form.php @@ -52,11 +52,14 @@ class Form extends \Kanboard\Core\Base $html = ' diff --git a/app/Template/project/filters.php b/app/Template/project/filters.php index eee691c5..c17cfb3c 100644 --- a/app/Template/project/filters.php +++ b/app/Template/project/filters.php @@ -68,7 +68,7 @@ diff --git a/app/Template/task/changes.php b/app/Template/task/changes.php index c7fc0d52..f288a8f4 100644 --- a/app/Template/task/changes.php +++ b/app/Template/task/changes.php @@ -3,7 +3,6 @@ $value) { - switch ($field) { case 'title': echo '
  • '.t('New title: %s', $task['title']).'
  • '; @@ -11,16 +10,14 @@ case 'owner_id': if (empty($task['owner_id'])) { echo '
  • '.t('The task is not assigned anymore').'
  • '; - } - else { + } else { echo '
  • '.t('New assignee: %s', $task['assignee_name'] ?: $task['assignee_username']).'
  • '; } break; case 'category_id': if (empty($task['category_id'])) { echo '
  • '.t('There is no category now').'
  • '; - } - else { + } else { echo '
  • '.t('New category: %s', $task['category_name']).'
  • '; } break; @@ -33,8 +30,7 @@ case 'date_due': if (empty($task['date_due'])) { echo '
  • '.t('The due date have been removed').'
  • '; - } - else { + } else { echo '
  • '.dt('New due date: %B %e, %Y', $task['date_due']).'
  • '; } break; diff --git a/app/Template/user/last.php b/app/Template/user/last.php index 8097d6f1..8879466e 100644 --- a/app/Template/user/last.php +++ b/app/Template/user/last.php @@ -12,7 +12,7 @@ - + e($login['auth_type']) ?> diff --git a/app/Template/user/sessions.php b/app/Template/user/sessions.php index 67b2c8cd..eabf3672 100644 --- a/app/Template/user/sessions.php +++ b/app/Template/user/sessions.php @@ -13,7 +13,7 @@ - + diff --git a/app/common.php b/app/common.php index 33e45f0d..85a2b7d2 100644 --- a/app/common.php +++ b/app/common.php @@ -4,7 +4,6 @@ require dirname(__DIR__) . '/vendor/autoload.php'; // Automatically parse environment configuration (Heroku) if (getenv('DATABASE_URL')) { - $dbopts = parse_url(getenv('DATABASE_URL')); define('DB_DRIVER', $dbopts['scheme']); diff --git a/doc/coding-standards.markdown b/doc/coding-standards.markdown index e0e762db..4d3db814 100644 --- a/doc/coding-standards.markdown +++ b/doc/coding-standards.markdown @@ -9,7 +9,7 @@ PHP code - Encoding: UTF-8 - Use only the opening tags `exec('DROP DATABASE '.DB_NAME); $pdo->exec('CREATE DATABASE '.DB_NAME); $pdo = null; - } - else if (DB_DRIVER === 'postgres') { + } elseif (DB_DRIVER === 'postgres') { $pdo = new PDO('pgsql:host='.DB_HOSTNAME, DB_USERNAME, DB_PASSWORD); $pdo->exec('DROP DATABASE '.DB_NAME); $pdo->exec('CREATE DATABASE '.DB_NAME.' WITH OWNER '.DB_USERNAME); @@ -1082,4 +1080,4 @@ class Api extends PHPUnit_Framework_TestCase $this->assertEquals('overdue task', $tasks[0]['title']); $this->assertEquals('API test', $tasks[0]['project_name']); } -} \ No newline at end of file +} diff --git a/tests/functionals/UserApiTest.php b/tests/functionals/UserApiTest.php index 3abb7b28..8a80c706 100644 --- a/tests/functionals/UserApiTest.php +++ b/tests/functionals/UserApiTest.php @@ -12,14 +12,12 @@ class UserApi extends PHPUnit_Framework_TestCase { if (DB_DRIVER === 'sqlite') { @unlink(DB_FILENAME); - } - else if (DB_DRIVER === 'mysql') { + } elseif (DB_DRIVER === 'mysql') { $pdo = new PDO('mysql:host='.DB_HOSTNAME, DB_USERNAME, DB_PASSWORD); $pdo->exec('DROP DATABASE '.DB_NAME); $pdo->exec('CREATE DATABASE '.DB_NAME); $pdo = null; - } - else if (DB_DRIVER === 'postgres') { + } elseif (DB_DRIVER === 'postgres') { $pdo = new PDO('pgsql:host='.DB_HOSTNAME, DB_USERNAME, DB_PASSWORD); $pdo->exec('DROP DATABASE '.DB_NAME); $pdo->exec('CREATE DATABASE '.DB_NAME.' WITH OWNER '.DB_USERNAME); diff --git a/tests/units/Action/TaskEmailTest.php b/tests/units/Action/TaskEmailTest.php index 863e5677..404865f4 100644 --- a/tests/units/Action/TaskEmailTest.php +++ b/tests/units/Action/TaskEmailTest.php @@ -147,4 +147,4 @@ class TaskEmailTest extends Base // Our event should be executed $this->assertTrue($action->execute(new GenericEvent($event))); } -} \ No newline at end of file +} diff --git a/tests/units/Base.php b/tests/units/Base.php index fe054344..4a5b303f 100644 --- a/tests/units/Base.php +++ b/tests/units/Base.php @@ -65,8 +65,7 @@ abstract class Base extends PHPUnit_Framework_TestCase $pdo->exec('DROP DATABASE '.DB_NAME); $pdo->exec('CREATE DATABASE '.DB_NAME); $pdo = null; - } - else if (DB_DRIVER === 'postgres') { + } elseif (DB_DRIVER === 'postgres') { $pdo = new PDO('pgsql:host='.DB_HOSTNAME, DB_USERNAME, DB_PASSWORD); $pdo->exec('DROP DATABASE '.DB_NAME); $pdo->exec('CREATE DATABASE '.DB_NAME.' WITH OWNER '.DB_USERNAME); diff --git a/tests/units/Core/Plugin/HookTest.php b/tests/units/Core/Plugin/HookTest.php index 8b771697..d1c139b3 100644 --- a/tests/units/Core/Plugin/HookTest.php +++ b/tests/units/Core/Plugin/HookTest.php @@ -42,11 +42,11 @@ class HookTest extends Base $values = array('A', 'B'); $expected = array('A', 'B', 'c', 'D'); - $h->on('myhook', function($p) { + $h->on('myhook', function ($p) { return array($p); }); - $h->on('myhook', function() { + $h->on('myhook', function () { return array('D'); }); @@ -61,7 +61,7 @@ class HookTest extends Base $values = array('A', 'B'); $expected = array('A', 'B'); - $h->on('myhook', function() { + $h->on('myhook', function () { return 'string'; }); @@ -82,11 +82,11 @@ class HookTest extends Base { $h = new Hook; - $h->on('myhook', function($p) { + $h->on('myhook', function ($p) { return $p + 1; }); - $h->on('myhook', function($p) { + $h->on('myhook', function ($p) { return $p; }); diff --git a/tests/units/Integration/BitbucketWebhookTest.php b/tests/units/Integration/BitbucketWebhookTest.php index 66d65d37..1a3b005b 100644 --- a/tests/units/Integration/BitbucketWebhookTest.php +++ b/tests/units/Integration/BitbucketWebhookTest.php @@ -248,7 +248,7 @@ class BitbucketWebhookTest extends Base public function testIssueAssignedWithNoPermission() { - $this->container['dispatcher']->addListener(BitbucketWebhook::EVENT_ISSUE_ASSIGNEE_CHANGE, function() {}); + $this->container['dispatcher']->addListener(BitbucketWebhook::EVENT_ISSUE_ASSIGNEE_CHANGE, function () {}); $p = new Project($this->container); $this->assertEquals(1, $p->create(array('name' => 'foobar'))); @@ -272,7 +272,7 @@ class BitbucketWebhookTest extends Base public function testIssueAssignedWithNoUser() { - $this->container['dispatcher']->addListener(BitbucketWebhook::EVENT_ISSUE_ASSIGNEE_CHANGE, function() {}); + $this->container['dispatcher']->addListener(BitbucketWebhook::EVENT_ISSUE_ASSIGNEE_CHANGE, function () {}); $p = new Project($this->container); $this->assertEquals(1, $p->create(array('name' => 'foobar'))); @@ -293,7 +293,7 @@ class BitbucketWebhookTest extends Base public function testIssueAssignedWithNoTask() { - $this->container['dispatcher']->addListener(BitbucketWebhook::EVENT_ISSUE_ASSIGNEE_CHANGE, function() {}); + $this->container['dispatcher']->addListener(BitbucketWebhook::EVENT_ISSUE_ASSIGNEE_CHANGE, function () {}); $p = new Project($this->container); $this->assertEquals(1, $p->create(array('name' => 'foobar'))); diff --git a/tests/units/Locale/LocaleTest.php b/tests/units/Locale/LocaleTest.php index 6cace0d5..976dfc58 100644 --- a/tests/units/Locale/LocaleTest.php +++ b/tests/units/Locale/LocaleTest.php @@ -6,21 +6,19 @@ class LocaleTest extends Base { public function testLocales() { - foreach(glob('app/Locale/*') as $file) { - + foreach (glob('app/Locale/*') as $file) { $locale = require($file . '/translations.php'); - foreach($locale as $k => $v) { - - if (strpos($k,'%B %e, %Y') !== false) { + foreach ($locale as $k => $v) { + if (strpos($k, '%B %e, %Y') !== false) { continue; } - if (strpos($k,'%b %e, %Y') !== false) { + if (strpos($k, '%b %e, %Y') !== false) { continue; } - foreach(array('%s', '%d') as $placeholder) { + foreach (array('%s', '%d') as $placeholder) { $this->assertEquals( substr_count($k, $placeholder), substr_count($v, $placeholder), diff --git a/tests/units/Model/SubtaskTest.php b/tests/units/Model/SubtaskTest.php index ba57ab01..04b274cc 100644 --- a/tests/units/Model/SubtaskTest.php +++ b/tests/units/Model/SubtaskTest.php @@ -11,7 +11,7 @@ use Kanboard\Model\User; use Kanboard\Core\Session; use Kanboard\Model\UserSession; -class SubTaskTest extends Base +class SubtaskTest extends Base { public function onSubtaskCreated($event) { diff --git a/tests/units/Model/TaskCreationTest.php b/tests/units/Model/TaskCreationTest.php index ea0d32e6..d76937b2 100644 --- a/tests/units/Model/TaskCreationTest.php +++ b/tests/units/Model/TaskCreationTest.php @@ -28,8 +28,8 @@ class TaskCreationTest extends Base $tc = new TaskCreation($this->container); $tf = new TaskFinder($this->container); - $this->container['dispatcher']->addListener(Task::EVENT_CREATE_UPDATE, function() {}); - $this->container['dispatcher']->addListener(Task::EVENT_CREATE, function() {}); + $this->container['dispatcher']->addListener(Task::EVENT_CREATE_UPDATE, function () {}); + $this->container['dispatcher']->addListener(Task::EVENT_CREATE, function () {}); $this->assertEquals(1, $p->create(array('name' => 'test'))); $this->assertEquals(0, $tc->create(array('title' => 'test', 'project_id' => 0))); @@ -45,8 +45,8 @@ class TaskCreationTest extends Base $tc = new TaskCreation($this->container); $tf = new TaskFinder($this->container); - $this->container['dispatcher']->addListener(Task::EVENT_CREATE_UPDATE, function() {}); - $this->container['dispatcher']->addListener(Task::EVENT_CREATE, function() {}); + $this->container['dispatcher']->addListener(Task::EVENT_CREATE_UPDATE, function () {}); + $this->container['dispatcher']->addListener(Task::EVENT_CREATE, function () {}); $this->assertEquals(1, $p->create(array('name' => 'test'))); $this->assertEquals(1, $tc->create(array('project_id' => 1))); @@ -68,7 +68,7 @@ class TaskCreationTest extends Base $tc = new TaskCreation($this->container); $tf = new TaskFinder($this->container); - $this->container['dispatcher']->addListener(Task::EVENT_CREATE_UPDATE, function() {}); + $this->container['dispatcher']->addListener(Task::EVENT_CREATE_UPDATE, function () {}); $this->container['dispatcher']->addListener(Task::EVENT_CREATE, array($this, 'onCreate')); $this->assertEquals(1, $p->create(array('name' => 'test'))); diff --git a/tests/units/Model/TaskDuplicationTest.php b/tests/units/Model/TaskDuplicationTest.php index 95c39308..5273928c 100644 --- a/tests/units/Model/TaskDuplicationTest.php +++ b/tests/units/Model/TaskDuplicationTest.php @@ -75,8 +75,8 @@ class TaskDuplicationTest extends Base $this->assertEquals(2, $task['category_id']); $this->assertEquals(4.4, $task['time_spent']); - $this->container['dispatcher']->addListener(Task::EVENT_CREATE_UPDATE, function() {}); - $this->container['dispatcher']->addListener(Task::EVENT_CREATE, function() {}); + $this->container['dispatcher']->addListener(Task::EVENT_CREATE_UPDATE, function () {}); + $this->container['dispatcher']->addListener(Task::EVENT_CREATE, function () {}); // We duplicate our task $this->assertEquals(2, $td->duplicate(1)); @@ -117,8 +117,8 @@ class TaskDuplicationTest extends Base // We create a task $this->assertEquals(1, $tc->create(array('title' => 'test', 'project_id' => 1, 'column_id' => 2, 'owner_id' => 1, 'category_id' => 1))); - $this->container['dispatcher']->addListener(Task::EVENT_CREATE_UPDATE, function() {}); - $this->container['dispatcher']->addListener(Task::EVENT_CREATE, function() {}); + $this->container['dispatcher']->addListener(Task::EVENT_CREATE_UPDATE, function () {}); + $this->container['dispatcher']->addListener(Task::EVENT_CREATE, function () {}); // We duplicate our task to the 2nd project $this->assertEquals(2, $td->duplicateToProject(1, 2)); diff --git a/tests/units/Model/TaskExportTest.php b/tests/units/Model/TaskExportTest.php index f7f8e2eb..40b3a5a2 100644 --- a/tests/units/Model/TaskExportTest.php +++ b/tests/units/Model/TaskExportTest.php @@ -30,7 +30,6 @@ class TaskExportTest extends Base $this->assertNotFalse($c->create(array('name' => 'Category #3', 'project_id' => 1))); for ($i = 1; $i <= 100; $i++) { - $task = array( 'title' => 'Task #'.$i, 'project_id' => 1, diff --git a/tests/units/Model/TaskPositionTest.php b/tests/units/Model/TaskPositionTest.php index d1838d52..42612f44 100644 --- a/tests/units/Model/TaskPositionTest.php +++ b/tests/units/Model/TaskPositionTest.php @@ -272,9 +272,7 @@ class TaskPositionTest extends Base $task_per_column = 5; foreach (array(1, 2, 3, 4) as $column_id) { - for ($i = 1; $i <= $task_per_column; $i++, $counter++) { - $task = array( 'title' => 'Task #'.$i.'-'.$column_id, 'project_id' => 1, -- cgit v1.2.3