From 33a3196001a29e82f77faf8799c58c6ec3cc7579 Mon Sep 17 00:00:00 2001 From: Frederic Guillot Date: Sun, 19 Jul 2015 18:54:00 -0400 Subject: Fix minor issues --- app/Controller/Comment.php | 4 ++-- app/Controller/Taskduplication.php | 6 ++++-- 2 files changed, 6 insertions(+), 4 deletions(-) (limited to 'app/Controller') diff --git a/app/Controller/Comment.php b/app/Controller/Comment.php index 7b9d4aee..81fd7215 100644 --- a/app/Controller/Comment.php +++ b/app/Controller/Comment.php @@ -140,7 +140,7 @@ class Comment extends Base $this->session->flashError(t('Unable to update your comment.')); } - $this->response->redirect($this->helper->url->to('task', 'show', array('task_id' => $task['id'], 'project_id' => $task['project_id'])), 'comment-'.$comment['id']); + $this->response->redirect($this->helper->url->to('task', 'show', array('task_id' => $task['id'], 'project_id' => $task['project_id']), 'comment-'.$comment['id'])); } $this->edit($values, $errors); @@ -181,6 +181,6 @@ class Comment extends Base $this->session->flashError(t('Unable to remove this comment.')); } - $this->response->redirect($this->helper->url->to('task', 'show', array('task_id' => $task['id'], 'project_id' => $task['project_id'])), 'comments'); + $this->response->redirect($this->helper->url->to('task', 'show', array('task_id' => $task['id'], 'project_id' => $task['project_id']), 'comments')); } } diff --git a/app/Controller/Taskduplication.php b/app/Controller/Taskduplication.php index 91291b0d..aebbcfc1 100644 --- a/app/Controller/Taskduplication.php +++ b/app/Controller/Taskduplication.php @@ -50,7 +50,7 @@ class Taskduplication extends Base if ($this->request->isPost()) { $values = $this->request->getValues(); - list($valid, $errors) = $this->taskValidator->validateProjectModification($values); + list($valid,) = $this->taskValidator->validateProjectModification($values); if ($valid && $this->taskDuplication->moveToProject($task['id'], $values['project_id'], @@ -81,7 +81,7 @@ class Taskduplication extends Base if ($this->request->isPost()) { $values = $this->request->getValues(); - list($valid, $errors) = $this->taskValidator->validateProjectModification($values); + list($valid,) = $this->taskValidator->validateProjectModification($values); if ($valid && $this->taskDuplication->duplicateToProject($task['id'], $values['project_id'], @@ -104,6 +104,8 @@ class Taskduplication extends Base * Choose destination when move/copy task to another project * * @access private + * @param array $task + * @param string $template */ private function chooseDestination(array $task, $template) { -- cgit v1.2.3