From 4ebcf84d47666bc649bd6a0624bd2ab0d3f4a405 Mon Sep 17 00:00:00 2001
From: Frédéric Guillot <fred@kanboard.net>
Date: Tue, 4 Jun 2019 15:57:07 -0700
Subject: Display cURL error message in logs
---
app/Core/Http/Client.php | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
(limited to 'app/Core')
diff --git a/app/Core/Http/Client.php b/app/Core/Http/Client.php
index 230a5958..d875fe67 100644
--- a/app/Core/Http/Client.php
+++ b/app/Core/Http/Client.php
@@ -265,14 +265,16 @@ class Client extends Base
$body = curl_exec($curlSession);
- if (! $body) {
- $this->logger->error('HttpClient: request failed ('.$url.')');
+ if ($body === false) {
+ $errorMsg = curl_error($curlSession);
+ curl_close($curlSession);
+
+ $this->logger->error('HttpClient: request failed ('.$url.' - '.$errorMsg.')');
if ($raiseForErrors) {
- throw new ClientException('Unreachable URL: '.$url);
+ throw new ClientException('Unreachable URL: '.$url.' ('.$errorMsg.')');
}
- curl_close($curlSession);
return '';
}
--
cgit v1.2.3