From bd3c44c3d337d49b02e19da0c6baed1a4abec37b Mon Sep 17 00:00:00 2001 From: Frederic Guillot Date: Sun, 10 May 2015 15:15:58 -0400 Subject: Recurring tasks (#847): move hardcoded conditions to event subscriber + refactoring --- app/Model/TaskStatus.php | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) (limited to 'app/Model/TaskStatus.php') diff --git a/app/Model/TaskStatus.php b/app/Model/TaskStatus.php index 1ae8bfeb..30a65e1e 100644 --- a/app/Model/TaskStatus.php +++ b/app/Model/TaskStatus.php @@ -89,9 +89,7 @@ class TaskStatus extends Base */ private function changeStatus($task_id, $status, $date_completed, $event) { - $task = $this->taskFinder->getById($task_id); - - if (!$task['id']) { + if (! $this->taskFinder->exists($task_id)) { return false; } @@ -109,13 +107,6 @@ class TaskStatus extends Base $event, new TaskEvent(array('task_id' => $task_id) + $this->taskFinder->getById($task_id)) ); - - if ($status == Task::STATUS_CLOSED - && $task['recurrence_status'] == Task::RECURE_STATUS_PENDING - && $task['recurrence_trigger'] == Task::RECURE_TRIGGER_CLOSE) - { - $this->taskDuplication->createRecurrence($task_id); - } } return $result; -- cgit v1.2.3