From 5a29cccc959dfd0be5fdc279ac1170d2db0b3040 Mon Sep 17 00:00:00 2001 From: Frederic Guillot Date: Fri, 3 Apr 2015 18:32:51 -0400 Subject: Various fixes for PHPAnalyzer --- app/Subscriber/Base.php | 2 ++ app/Subscriber/NotificationSubscriber.php | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) (limited to 'app/Subscriber') diff --git a/app/Subscriber/Base.php b/app/Subscriber/Base.php index f90d9604..97e230b5 100644 --- a/app/Subscriber/Base.php +++ b/app/Subscriber/Base.php @@ -10,6 +10,8 @@ use Pimple\Container; * @package subscriber * @author Frederic Guillot * + * @property \Integration\SlackWebhook $slackWebhook + * @property \Integration\Hipchat $hipchat * @property \Model\Board $board * @property \Model\Config $config * @property \Model\Comment $comment diff --git a/app/Subscriber/NotificationSubscriber.php b/app/Subscriber/NotificationSubscriber.php index 1b7187fe..94815b56 100644 --- a/app/Subscriber/NotificationSubscriber.php +++ b/app/Subscriber/NotificationSubscriber.php @@ -49,7 +49,7 @@ class NotificationSubscriber extends Base implements EventSubscriberInterface $values = $this->getTemplateData($event); $users = $this->notification->getUsersList($values['task']['project_id']); - if ($users) { + if (! empty($users)) { $this->notification->sendEmails($this->templates[$event_name], $users, $values); } } -- cgit v1.2.3