From 554500aa493faa66b43b2ddce72338880a874724 Mon Sep 17 00:00:00 2001 From: Frederic Guillot Date: Sat, 4 Jul 2015 11:14:21 -0400 Subject: Refactoring to implement new layout with filters: board/calendar/list views (work in progress) --- app/Template/activity/project.php | 40 ++++++++++++++ app/Template/analytic/layout.php | 12 ++++- app/Template/app/calendar.php | 5 +- app/Template/app/overview.php | 2 +- app/Template/board/assignee.php | 21 -------- app/Template/board/category.php | 22 -------- app/Template/board/comments.php | 16 ------ app/Template/board/description.php | 5 -- app/Template/board/files.php | 31 ----------- app/Template/board/filters.php | 43 ---------------- app/Template/board/index.php | 16 ------ app/Template/board/popover_assignee.php | 21 ++++++++ app/Template/board/popover_category.php | 22 ++++++++ app/Template/board/private_view.php | 16 ++++++ app/Template/board/public.php | 11 ---- app/Template/board/public_view.php | 11 ++++ app/Template/board/show.php | 30 ----------- app/Template/board/subtasks.php | 7 --- app/Template/board/swimlane.php | 83 ------------------------------ app/Template/board/table_container.php | 30 +++++++++++ app/Template/board/table_swimlane.php | 83 ++++++++++++++++++++++++++++++ app/Template/board/tasklinks.php | 18 ------- app/Template/board/tooltip_comments.php | 16 ++++++ app/Template/board/tooltip_description.php | 5 ++ app/Template/board/tooltip_files.php | 31 +++++++++++ app/Template/board/tooltip_subtasks.php | 7 +++ app/Template/board/tooltip_tasklinks.php | 18 +++++++ app/Template/calendar/show.php | 53 ++++--------------- app/Template/calendar/sidebar.php | 40 -------------- app/Template/listing/show.php | 67 ++++++++++++++++++++++++ app/Template/project/dropdown.php | 14 +---- app/Template/project/filters.php | 49 ++++++++++++++++++ app/Template/project/index.php | 2 +- app/Template/project/layout.php | 6 ++- app/Template/projectinfo/activity.php | 30 ----------- app/Template/projectinfo/search.php | 43 ---------------- app/Template/projectinfo/tasks.php | 33 ------------ app/Template/task/layout.php | 10 ++-- app/Template/task/new.php | 2 +- app/Template/task/table.php | 56 -------------------- 40 files changed, 453 insertions(+), 574 deletions(-) create mode 100644 app/Template/activity/project.php delete mode 100644 app/Template/board/assignee.php delete mode 100644 app/Template/board/category.php delete mode 100644 app/Template/board/comments.php delete mode 100644 app/Template/board/description.php delete mode 100644 app/Template/board/files.php delete mode 100644 app/Template/board/filters.php delete mode 100644 app/Template/board/index.php create mode 100644 app/Template/board/popover_assignee.php create mode 100644 app/Template/board/popover_category.php create mode 100644 app/Template/board/private_view.php delete mode 100644 app/Template/board/public.php create mode 100644 app/Template/board/public_view.php delete mode 100644 app/Template/board/show.php delete mode 100644 app/Template/board/subtasks.php delete mode 100644 app/Template/board/swimlane.php create mode 100644 app/Template/board/table_container.php create mode 100644 app/Template/board/table_swimlane.php delete mode 100644 app/Template/board/tasklinks.php create mode 100644 app/Template/board/tooltip_comments.php create mode 100644 app/Template/board/tooltip_description.php create mode 100644 app/Template/board/tooltip_files.php create mode 100644 app/Template/board/tooltip_subtasks.php create mode 100644 app/Template/board/tooltip_tasklinks.php delete mode 100644 app/Template/calendar/sidebar.php create mode 100644 app/Template/listing/show.php create mode 100644 app/Template/project/filters.php delete mode 100644 app/Template/projectinfo/activity.php delete mode 100644 app/Template/projectinfo/search.php delete mode 100644 app/Template/projectinfo/tasks.php delete mode 100644 app/Template/task/table.php (limited to 'app/Template') diff --git a/app/Template/activity/project.php b/app/Template/activity/project.php new file mode 100644 index 00000000..480bbadd --- /dev/null +++ b/app/Template/activity/project.php @@ -0,0 +1,40 @@ +
+ + + render('event/events', array('events' => $events)) ?> +
\ No newline at end of file diff --git a/app/Template/analytic/layout.php b/app/Template/analytic/layout.php index 41c6a2ab..9d6bf77c 100644 --- a/app/Template/analytic/layout.php +++ b/app/Template/analytic/layout.php @@ -12,9 +12,19 @@
  • - + url->link(t('Back to the board'), 'board', 'show', array('project_id' => $project['id'])) ?>
  • +
  • + + url->link(t('Back to the calendar'), 'calendar', 'show', array('project_id' => $project['id'])) ?> +
  • + user->isManager($project['id'])): ?> +
  • + + url->link(t('Project settings'), 'project', 'show', array('project_id' => $project['id'])) ?> +
  • +
  • url->link(t('All projects'), 'project', 'index') ?> diff --git a/app/Template/app/calendar.php b/app/Template/app/calendar.php index 6acee6ec..a154203b 100644 --- a/app/Template/app/calendar.php +++ b/app/Template/app/calendar.php @@ -1,6 +1,5 @@ -
    diff --git a/app/Template/app/overview.php b/app/Template/app/overview.php index a2301cd0..66bcaa63 100644 --- a/app/Template/app/overview.php +++ b/app/Template/app/overview.php @@ -1,7 +1,7 @@
    form->hidden('controller', array('controller' => 'search')) ?> form->hidden('action', array('controller' => 'index')) ?> - form->text('search', array(), array(), array('required', 'placeholder="'.t('Search').'"'), 'form-input-large') ?> + form->text('search', array(), array(), array('placeholder="'.t('Search').'"'), 'form-input-large') ?>
    diff --git a/app/Template/board/assignee.php b/app/Template/board/assignee.php deleted file mode 100644 index 4af19cf7..00000000 --- a/app/Template/board/assignee.php +++ /dev/null @@ -1,21 +0,0 @@ -
    -
    -

    -
    - - form->csrf() ?> - - form->hidden('id', $values) ?> - form->hidden('project_id', $values) ?> - - form->label(t('Assignee'), 'owner_id') ?> - form->select('owner_id', $users_list, $values, array(), array('autofocus')) ?>
    - -
    - - - url->link(t('cancel'), 'board', 'show', array('project_id' => $project['id']), false, 'close-popover') ?> -
    -
    -
    -
    \ No newline at end of file diff --git a/app/Template/board/category.php b/app/Template/board/category.php deleted file mode 100644 index b38758d3..00000000 --- a/app/Template/board/category.php +++ /dev/null @@ -1,22 +0,0 @@ -
    -
    -

    -
    - - form->csrf() ?> - - form->hidden('id', $values) ?> - form->hidden('project_id', $values) ?> - - form->label(t('Category'), 'category_id') ?> - form->select('category_id', $categories_list, $values) ?>
    - -
    - - - url->link(t('cancel'), 'board', 'show', array('project_id' => $project['id']), false, 'close-popover') ?> -
    -
    -
    - -
    \ No newline at end of file diff --git a/app/Template/board/comments.php b/app/Template/board/comments.php deleted file mode 100644 index 2e2c0c1e..00000000 --- a/app/Template/board/comments.php +++ /dev/null @@ -1,16 +0,0 @@ -
    - -

    - - e($comment['name'] ?: $comment['username']) ?> @ - - -

    - -
    -
    - text->markdown($comment['comment']) ?> -
    -
    - -
    diff --git a/app/Template/board/description.php b/app/Template/board/description.php deleted file mode 100644 index 7e0e3430..00000000 --- a/app/Template/board/description.php +++ /dev/null @@ -1,5 +0,0 @@ -
    -
    - text->markdown($task['description']) ?> -
    -
    \ No newline at end of file diff --git a/app/Template/board/files.php b/app/Template/board/files.php deleted file mode 100644 index 81136659..00000000 --- a/app/Template/board/files.php +++ /dev/null @@ -1,31 +0,0 @@ -
    - - - - - - - - - - - - - - - - - -
    - - e($file['name']) ?> - - url->link(t('download'), 'file', 'download', array('task_id' => $task['id'], 'project_id' => $task['project_id'], 'file_id' => $file['id'])) ?> - url->link(t('open'), 'file', 'open', array('task_id' => $task['id'], 'project_id' => $task['project_id'], 'file_id' => $file['id']), false, 'popover') ?> -
    - - e($file['name']) ?> - - url->link(t('download'), 'file', 'download', array('task_id' => $task['id'], 'project_id' => $task['project_id'], 'file_id' => $file['id'])) ?> -
    -
    diff --git a/app/Template/board/filters.php b/app/Template/board/filters.php deleted file mode 100644 index b80234a0..00000000 --- a/app/Template/board/filters.php +++ /dev/null @@ -1,43 +0,0 @@ - \ No newline at end of file diff --git a/app/Template/board/index.php b/app/Template/board/index.php deleted file mode 100644 index 6f6fddbe..00000000 --- a/app/Template/board/index.php +++ /dev/null @@ -1,16 +0,0 @@ -
    - - render('board/filters', array( - 'categories' => $categories_listing, - 'users' => $users, - 'project' => $project, - )) ?> - - render('board/show', array( - 'project' => $project, - 'swimlanes' => $swimlanes, - 'board_private_refresh_interval' => $board_private_refresh_interval, - 'board_highlight_period' => $board_highlight_period, - )) ?> - -
    diff --git a/app/Template/board/popover_assignee.php b/app/Template/board/popover_assignee.php new file mode 100644 index 00000000..4af19cf7 --- /dev/null +++ b/app/Template/board/popover_assignee.php @@ -0,0 +1,21 @@ +
    +
    +

    +
    + + form->csrf() ?> + + form->hidden('id', $values) ?> + form->hidden('project_id', $values) ?> + + form->label(t('Assignee'), 'owner_id') ?> + form->select('owner_id', $users_list, $values, array(), array('autofocus')) ?>
    + +
    + + + url->link(t('cancel'), 'board', 'show', array('project_id' => $project['id']), false, 'close-popover') ?> +
    +
    +
    +
    \ No newline at end of file diff --git a/app/Template/board/popover_category.php b/app/Template/board/popover_category.php new file mode 100644 index 00000000..b38758d3 --- /dev/null +++ b/app/Template/board/popover_category.php @@ -0,0 +1,22 @@ +
    +
    +

    +
    + + form->csrf() ?> + + form->hidden('id', $values) ?> + form->hidden('project_id', $values) ?> + + form->label(t('Category'), 'category_id') ?> + form->select('category_id', $categories_list, $values) ?>
    + +
    + + + url->link(t('cancel'), 'board', 'show', array('project_id' => $project['id']), false, 'close-popover') ?> +
    +
    +
    + +
    \ No newline at end of file diff --git a/app/Template/board/private_view.php b/app/Template/board/private_view.php new file mode 100644 index 00000000..5fdaa7fc --- /dev/null +++ b/app/Template/board/private_view.php @@ -0,0 +1,16 @@ +
    + + render('project/filters', array( + 'project' => $project, + 'filters' => $filters, + 'is_board' => true, + )) ?> + + render('board/table_container', array( + 'project' => $project, + 'swimlanes' => $swimlanes, + 'board_private_refresh_interval' => $board_private_refresh_interval, + 'board_highlight_period' => $board_highlight_period, + )) ?> + +
    diff --git a/app/Template/board/public.php b/app/Template/board/public.php deleted file mode 100644 index ad7515db..00000000 --- a/app/Template/board/public.php +++ /dev/null @@ -1,11 +0,0 @@ -
    - - render('board/show', array( - 'project' => $project, - 'swimlanes' => $swimlanes, - 'board_private_refresh_interval' => $board_private_refresh_interval, - 'board_highlight_period' => $board_highlight_period, - 'not_editable' => true, - )) ?> - -
    \ No newline at end of file diff --git a/app/Template/board/public_view.php b/app/Template/board/public_view.php new file mode 100644 index 00000000..aea72031 --- /dev/null +++ b/app/Template/board/public_view.php @@ -0,0 +1,11 @@ +
    + + render('board/table_container', array( + 'project' => $project, + 'swimlanes' => $swimlanes, + 'board_private_refresh_interval' => $board_private_refresh_interval, + 'board_highlight_period' => $board_highlight_period, + 'not_editable' => true, + )) ?> + +
    \ No newline at end of file diff --git a/app/Template/board/show.php b/app/Template/board/show.php deleted file mode 100644 index c0aa5d36..00000000 --- a/app/Template/board/show.php +++ /dev/null @@ -1,30 +0,0 @@ -
    - - - -
    - - - - -

    - - - render('board/swimlane', array( - 'project' => $project, - 'swimlane' => $swimlane, - 'board_highlight_period' => $board_highlight_period, - 'hide_swimlane' => count($swimlanes) === 1, - 'not_editable' => isset($not_editable), - )) ?> - - -
    -
    \ No newline at end of file diff --git a/app/Template/board/subtasks.php b/app/Template/board/subtasks.php deleted file mode 100644 index 950da925..00000000 --- a/app/Template/board/subtasks.php +++ /dev/null @@ -1,7 +0,0 @@ -
    - - subtask->toggleStatus($subtask, 'board') ?> - e(empty($subtask['username']) ? '' : ' ['.$this->user->getFullname($subtask).']') ?> -
    - -
    diff --git a/app/Template/board/swimlane.php b/app/Template/board/swimlane.php deleted file mode 100644 index b86fc446..00000000 --- a/app/Template/board/swimlane.php +++ /dev/null @@ -1,83 +0,0 @@ - - - - 0): ?> - - - - - e($swimlane['name']) ?> - - - - - - - -
    - url->link('+', 'task', 'create', array('project_id' => $column['project_id'], 'column_id' => $column['id'], 'swimlane_id' => $swimlane['id']), false, 'task-board-popover', t('Add a new task')) ?> -
    - - - e($column['title']) ?> - - - '> - - - - - - -   - - - - - - (/e($column['task_limit']) ?>) - - - - () - - - - - - - - - - e($swimlane['name']) ?> - - - () - - - - - - - - - - - - - - render($not_editable ? 'board/task_public' : 'board/task_private', array( - 'project' => $project, - 'task' => $task, - 'board_highlight_period' => $board_highlight_period, - 'not_editable' => $not_editable, - )) ?> - - - - \ No newline at end of file diff --git a/app/Template/board/table_container.php b/app/Template/board/table_container.php new file mode 100644 index 00000000..9d3a1134 --- /dev/null +++ b/app/Template/board/table_container.php @@ -0,0 +1,30 @@ +
    + + + +
    + + + + +

    + + + render('board/table_swimlane', array( + 'project' => $project, + 'swimlane' => $swimlane, + 'board_highlight_period' => $board_highlight_period, + 'hide_swimlane' => count($swimlanes) === 1, + 'not_editable' => isset($not_editable), + )) ?> + + +
    +
    \ No newline at end of file diff --git a/app/Template/board/table_swimlane.php b/app/Template/board/table_swimlane.php new file mode 100644 index 00000000..b86fc446 --- /dev/null +++ b/app/Template/board/table_swimlane.php @@ -0,0 +1,83 @@ + + + + 0): ?> + + + + + e($swimlane['name']) ?> + + + + + + + +
    + url->link('+', 'task', 'create', array('project_id' => $column['project_id'], 'column_id' => $column['id'], 'swimlane_id' => $swimlane['id']), false, 'task-board-popover', t('Add a new task')) ?> +
    + + + e($column['title']) ?> + + + '> + + + + + + +   + + + + + + (/e($column['task_limit']) ?>) + + + + () + + + + + + + + + + e($swimlane['name']) ?> + + + () + + + + + + + + + + + + + + render($not_editable ? 'board/task_public' : 'board/task_private', array( + 'project' => $project, + 'task' => $task, + 'board_highlight_period' => $board_highlight_period, + 'not_editable' => $not_editable, + )) ?> + + + + \ No newline at end of file diff --git a/app/Template/board/tasklinks.php b/app/Template/board/tasklinks.php deleted file mode 100644 index 25aa91aa..00000000 --- a/app/Template/board/tasklinks.php +++ /dev/null @@ -1,18 +0,0 @@ - \ No newline at end of file diff --git a/app/Template/board/tooltip_comments.php b/app/Template/board/tooltip_comments.php new file mode 100644 index 00000000..2e2c0c1e --- /dev/null +++ b/app/Template/board/tooltip_comments.php @@ -0,0 +1,16 @@ +
    + +

    + + e($comment['name'] ?: $comment['username']) ?> @ + + +

    + +
    +
    + text->markdown($comment['comment']) ?> +
    +
    + +
    diff --git a/app/Template/board/tooltip_description.php b/app/Template/board/tooltip_description.php new file mode 100644 index 00000000..7e0e3430 --- /dev/null +++ b/app/Template/board/tooltip_description.php @@ -0,0 +1,5 @@ +
    +
    + text->markdown($task['description']) ?> +
    +
    \ No newline at end of file diff --git a/app/Template/board/tooltip_files.php b/app/Template/board/tooltip_files.php new file mode 100644 index 00000000..81136659 --- /dev/null +++ b/app/Template/board/tooltip_files.php @@ -0,0 +1,31 @@ +
    + + + + + + + + + + + + + + + + + +
    + + e($file['name']) ?> + + url->link(t('download'), 'file', 'download', array('task_id' => $task['id'], 'project_id' => $task['project_id'], 'file_id' => $file['id'])) ?> + url->link(t('open'), 'file', 'open', array('task_id' => $task['id'], 'project_id' => $task['project_id'], 'file_id' => $file['id']), false, 'popover') ?> +
    + + e($file['name']) ?> + + url->link(t('download'), 'file', 'download', array('task_id' => $task['id'], 'project_id' => $task['project_id'], 'file_id' => $file['id'])) ?> +
    +
    diff --git a/app/Template/board/tooltip_subtasks.php b/app/Template/board/tooltip_subtasks.php new file mode 100644 index 00000000..950da925 --- /dev/null +++ b/app/Template/board/tooltip_subtasks.php @@ -0,0 +1,7 @@ +
    + + subtask->toggleStatus($subtask, 'board') ?> + e(empty($subtask['username']) ? '' : ' ['.$this->user->getFullname($subtask).']') ?> +
    + +
    diff --git a/app/Template/board/tooltip_tasklinks.php b/app/Template/board/tooltip_tasklinks.php new file mode 100644 index 00000000..25aa91aa --- /dev/null +++ b/app/Template/board/tooltip_tasklinks.php @@ -0,0 +1,18 @@ + \ No newline at end of file diff --git a/app/Template/calendar/show.php b/app/Template/calendar/show.php index cf2a20ec..0406414c 100644 --- a/app/Template/calendar/show.php +++ b/app/Template/calendar/show.php @@ -1,46 +1,13 @@
    - - +
    +
    \ No newline at end of file diff --git a/app/Template/calendar/sidebar.php b/app/Template/calendar/sidebar.php deleted file mode 100644 index 6c4fb5b0..00000000 --- a/app/Template/calendar/sidebar.php +++ /dev/null @@ -1,40 +0,0 @@ - diff --git a/app/Template/listing/show.php b/app/Template/listing/show.php new file mode 100644 index 00000000..06940678 --- /dev/null +++ b/app/Template/listing/show.php @@ -0,0 +1,67 @@ +
    + render('project/filters', array( + 'project' => $project, + 'filters' => $filters, + )) ?> + + isEmpty()): ?> +

    + isEmpty()): ?> + + + + + + + + + + + + + getCollection() as $task): ?> + + + + + + + + + + + + +
    order(t('Id'), 'tasks.id') ?>order(t('Column'), 'tasks.column_id') ?>order(t('Category'), 'tasks.category_id') ?>order(t('Title'), 'tasks.title') ?>order(t('Assignee'), 'users.username') ?>order(t('Due date'), 'tasks.date_due') ?>order(t('Date created'), 'tasks.date_creation') ?>order(t('Date completed'), 'tasks.date_completed') ?>order(t('Status'), 'tasks.is_active') ?>
    + url->link('#'.$this->e($task['id']), 'task', 'show', array('task_id' => $task['id'], 'project_id' => $task['project_id']), false, '', t('View this task')) ?> + + e($task['column_name']) ?> + + e($task['category_name']) ?> + + url->link($this->e($task['title']), 'task', 'show', array('task_id' => $task['id'], 'project_id' => $task['project_id']), false, '', t('View this task')) ?> + + + e($task['assignee_name'] ?: $task['assignee_username']) ?> + + + + + + + + + + + + + + + + + +
    + + + +
    \ No newline at end of file diff --git a/app/Template/project/dropdown.php b/app/Template/project/dropdown.php index 2e2650a7..aa4322e6 100644 --- a/app/Template/project/dropdown.php +++ b/app/Template/project/dropdown.php @@ -1,18 +1,6 @@ -
  • - - url->link(t('Search'), 'projectinfo', 'search', array('project_id' => $project['id'])) ?> -
  • -
  • - - url->link(t('Completed tasks'), 'projectinfo', 'tasks', array('project_id' => $project['id'])) ?> -
  • - url->link(t('Activity'), 'projectinfo', 'activity', array('project_id' => $project['id'])) ?> -
  • -
  • - - url->link(t('Calendar'), 'calendar', 'show', array('project_id' => $project['id'])) ?> + url->link(t('Activity'), 'activity', 'project', array('project_id' => $project['id'])) ?>
  • diff --git a/app/Template/project/filters.php b/app/Template/project/filters.php new file mode 100644 index 00000000..402807d7 --- /dev/null +++ b/app/Template/project/filters.php @@ -0,0 +1,49 @@ + \ No newline at end of file diff --git a/app/Template/project/index.php b/app/Template/project/index.php index 1080968e..7a03ec16 100644 --- a/app/Template/project/index.php +++ b/app/Template/project/index.php @@ -35,7 +35,7 @@ e($project['identifier']) ?> - url->link('', 'board', 'show', array('project_id' => $project['id']), false, 'dashboard-table-link', t('Board')) ?>  + url->link('', 'board', 'show', array('project_id' => $project['id']), false, 'dashboard-table-link', t('Board')) ?>  diff --git a/app/Template/project/layout.php b/app/Template/project/layout.php index 7bb3d478..8ba92ef9 100644 --- a/app/Template/project/layout.php +++ b/app/Template/project/layout.php @@ -12,9 +12,13 @@
  • - + url->link(t('Back to the board'), 'board', 'show', array('project_id' => $project['id'])) ?>
  • +
  • + + url->link(t('Back to the calendar'), 'calendar', 'show', array('project_id' => $project['id'])) ?> +
  • url->link(t('All projects'), 'project', 'index') ?> diff --git a/app/Template/projectinfo/activity.php b/app/Template/projectinfo/activity.php deleted file mode 100644 index d458ea3d..00000000 --- a/app/Template/projectinfo/activity.php +++ /dev/null @@ -1,30 +0,0 @@ -
    - - - render('event/events', array('events' => $events)) ?> -
    \ No newline at end of file diff --git a/app/Template/projectinfo/search.php b/app/Template/projectinfo/search.php deleted file mode 100644 index 4b7c8f70..00000000 --- a/app/Template/projectinfo/search.php +++ /dev/null @@ -1,43 +0,0 @@ -
    - - -
    - form->hidden('controller', $values) ?> - form->hidden('action', $values) ?> - form->hidden('project_id', $values) ?> - form->text('search', $values, array(), array('autofocus', 'required', 'placeholder="'.t('Search').'"'), 'form-input-large') ?> - -
    - - isEmpty()): ?> -

    - isEmpty()): ?> - render('task/table', array( - 'paginator' => $paginator, - 'categories' => $categories, - 'columns' => $columns, - )) ?> - - -
    \ No newline at end of file diff --git a/app/Template/projectinfo/tasks.php b/app/Template/projectinfo/tasks.php deleted file mode 100644 index 41884783..00000000 --- a/app/Template/projectinfo/tasks.php +++ /dev/null @@ -1,33 +0,0 @@ -
    - - isEmpty()): ?> -

    - - render('task/table', array( - 'paginator' => $paginator, - 'categories' => $categories, - 'columns' => $columns, - )) ?> - -
    \ No newline at end of file diff --git a/app/Template/task/layout.php b/app/Template/task/layout.php index 5a14fb39..ddce4bce 100644 --- a/app/Template/task/layout.php +++ b/app/Template/task/layout.php @@ -2,19 +2,19 @@