From ed074d176406ca3ce5ba8fa6e0c4511f729efa5b Mon Sep 17 00:00:00 2001
From: Frederic Guillot <fred@kanboard.net>
Date: Sat, 28 May 2016 21:24:24 -0400
Subject: Move task import outside of project settings

---
 app/Template/export/sidebar.php          |  8 ++++----
 app/Template/project/sidebar.php         |  5 +----
 app/Template/project_header/dropdown.php |  9 ++++++++-
 app/Template/task_import/show.php        | 34 ++++++++++++++++++++++++++++++++
 app/Template/task_import/sidebar.php     |  9 +++++++++
 app/Template/task_import/step1.php       | 34 --------------------------------
 6 files changed, 56 insertions(+), 43 deletions(-)
 create mode 100644 app/Template/task_import/show.php
 create mode 100644 app/Template/task_import/sidebar.php
 delete mode 100644 app/Template/task_import/step1.php

(limited to 'app/Template')

diff --git a/app/Template/export/sidebar.php b/app/Template/export/sidebar.php
index c9d4d0a3..55fbaeef 100644
--- a/app/Template/export/sidebar.php
+++ b/app/Template/export/sidebar.php
@@ -1,16 +1,16 @@
 <div class="sidebar">
     <h2><?= t('Exports') ?></h2>
     <ul>
-        <li <?= $this->app->getRouterAction() === 'tasks' ? 'class="active"' : '' ?>>
+        <li <?= $this->app->checkMenuSelection('ExportController', 'tasks') ?>>
             <?= $this->url->link(t('Tasks'), 'ExportController', 'tasks', array('project_id' => $project['id'])) ?>
         </li>
-        <li <?= $this->app->getRouterAction() === 'subtasks' ? 'class="active"' : '' ?>>
+        <li <?= $this->app->checkMenuSelection('ExportController', 'subtasks') ?>>
             <?= $this->url->link(t('Subtasks'), 'ExportController', 'subtasks', array('project_id' => $project['id'])) ?>
         </li>
-        <li <?= $this->app->getRouterAction() === 'transitions' ? 'class="active"' : '' ?>>
+        <li <?= $this->app->checkMenuSelection('ExportController', 'transitions') ?>>
             <?= $this->url->link(t('Task transitions'), 'ExportController', 'transitions', array('project_id' => $project['id'])) ?>
         </li>
-        <li <?= $this->app->getRouterAction() === 'summary' ? 'class="active"' : '' ?>>
+        <li <?= $this->app->checkMenuSelection('ExportController', 'summary') ?>>
             <?= $this->url->link(t('Daily project summary'), 'ExportController', 'summary', array('project_id' => $project['id'])) ?>
         </li>
         <?= $this->hook->render('template:export:sidebar') ?>
diff --git a/app/Template/project/sidebar.php b/app/Template/project/sidebar.php
index 3fac3fd1..9bc0c9c4 100644
--- a/app/Template/project/sidebar.php
+++ b/app/Template/project/sidebar.php
@@ -29,7 +29,7 @@
             <li <?= $this->app->checkMenuSelection('SwimlaneController') ?>>
                 <?= $this->url->link(t('Swimlanes'), 'SwimlaneController', 'index', array('project_id' => $project['id'])) ?>
             </li>
-            <li <?= $this->app->checkMenuSelection('category') ?>>
+            <li <?= $this->app->checkMenuSelection('CategoryController') ?>>
                 <?= $this->url->link(t('Categories'), 'CategoryController', 'index', array('project_id' => $project['id'])) ?>
             </li>
             <?php if ($project['is_private'] == 0): ?>
@@ -51,9 +51,6 @@
                     <?= $this->url->link(t('Enable'), 'ProjectStatusController', 'confirmEnable', array('project_id' => $project['id']), false, 'popover') ?>
                 <?php endif ?>
             </li>
-            <li <?= $this->app->checkMenuSelection('TaskImportController') ?>>
-                <?= $this->url->link(t('Import'), 'TaskImportController', 'step1', array('project_id' => $project['id'])) ?>
-            </li>
             <?php if ($this->user->hasProjectAccess('ProjectStatusController', 'remove', $project['id'])): ?>
                 <li>
                     <?= $this->url->link(t('Remove'), 'ProjectStatusController', 'confirmRemove', array('project_id' => $project['id']), false, 'popover') ?>
diff --git a/app/Template/project_header/dropdown.php b/app/Template/project_header/dropdown.php
index 6b5c51a6..79a1b389 100644
--- a/app/Template/project_header/dropdown.php
+++ b/app/Template/project_header/dropdown.php
@@ -67,11 +67,18 @@
 
         <?php if ($this->user->hasProjectAccess('ExportController', 'tasks', $project['id'])): ?>
             <li>
-                <i class="fa fa-download fa-fw"></i>
+                <i class="fa fa-upload fa-fw"></i>
                 <?= $this->url->link(t('Exports'), 'ExportController', 'tasks', array('project_id' => $project['id'])) ?>
             </li>
         <?php endif ?>
 
+        <?php if ($this->user->hasProjectAccess('TaskImportController', 'tasks', $project['id'])): ?>
+            <li>
+                <i class="fa fa-download fa-fw"></i>
+                <?= $this->url->link(t('Imports'), 'TaskImportController', 'show', array('project_id' => $project['id'])) ?>
+            </li>
+        <?php endif ?>
+
         <?php if ($this->user->hasProjectAccess('ProjectEditController', 'edit', $project['id'])): ?>
             <li>
                 <i class="fa fa-cog fa-fw"></i>
diff --git a/app/Template/task_import/show.php b/app/Template/task_import/show.php
new file mode 100644
index 00000000..cc6a7b3a
--- /dev/null
+++ b/app/Template/task_import/show.php
@@ -0,0 +1,34 @@
+<div class="page-header">
+    <h2><?= t('Tasks Importation') ?></h2>
+</div>
+<form action="<?= $this->url->href('TaskImportController', 'save', array('project_id' => $project['id'])) ?>" method="post" enctype="multipart/form-data">
+    <?= $this->form->csrf() ?>
+
+    <?= $this->form->label(t('Delimiter'), 'delimiter') ?>
+    <?= $this->form->select('delimiter', $delimiters, $values) ?>
+
+    <?= $this->form->label(t('Enclosure'), 'enclosure') ?>
+    <?= $this->form->select('enclosure', $enclosures, $values) ?>
+
+    <?= $this->form->label(t('CSV File'), 'file') ?>
+    <?= $this->form->file('file', $errors) ?>
+
+    <p class="form-help"><?= t('Maximum size: ') ?><?= is_integer($max_size) ? $this->text->bytes($max_size) : $max_size ?></p>
+
+    <div class="form-actions">
+        <button type="submit" class="btn btn-blue"><?= t('Import') ?></button>
+    </div>
+</form>
+<div class="page-header">
+    <h2><?= t('Instructions') ?></h2>
+</div>
+<div class="alert">
+    <ul>
+        <li><?= t('Your file must use the predefined CSV format') ?></li>
+        <li><?= t('Your file must be encoded in UTF-8') ?></li>
+        <li><?= t('The first row must be the header') ?></li>
+        <li><?= t('Duplicates are not verified for you') ?></li>
+        <li><?= t('The due date must use the ISO format: YYYY-MM-DD') ?></li>
+    </ul>
+</div>
+<p><i class="fa fa-download fa-fw"></i><?= $this->url->link(t('Download CSV template'), 'TaskImportController', 'template', array('project_id' => $project['id'])) ?></p>
diff --git a/app/Template/task_import/sidebar.php b/app/Template/task_import/sidebar.php
new file mode 100644
index 00000000..4cd92af8
--- /dev/null
+++ b/app/Template/task_import/sidebar.php
@@ -0,0 +1,9 @@
+<div class="sidebar">
+    <h2><?= t('Imports') ?></h2>
+    <ul>
+        <li <?= $this->app->checkMenuSelection('TaskImportController', 'show') ?>>
+            <?= $this->url->link(t('Tasks').' (CSV)', 'TaskImportController', 'show', array('project_id' => $project['id'])) ?>
+        </li>
+        <?= $this->hook->render('template:task-import:sidebar') ?>
+    </ul>
+</div>
diff --git a/app/Template/task_import/step1.php b/app/Template/task_import/step1.php
deleted file mode 100644
index 23fcc11c..00000000
--- a/app/Template/task_import/step1.php
+++ /dev/null
@@ -1,34 +0,0 @@
-<div class="page-header">
-    <h2><?= t('Tasks Importation') ?></h2>
-</div>
-<form action="<?= $this->url->href('TaskImportController', 'step2', array('project_id' => $project['id'])) ?>" method="post" enctype="multipart/form-data">
-    <?= $this->form->csrf() ?>
-
-    <?= $this->form->label(t('Delimiter'), 'delimiter') ?>
-    <?= $this->form->select('delimiter', $delimiters, $values) ?>
-
-    <?= $this->form->label(t('Enclosure'), 'enclosure') ?>
-    <?= $this->form->select('enclosure', $enclosures, $values) ?>
-
-    <?= $this->form->label(t('CSV File'), 'file') ?>
-    <?= $this->form->file('file', $errors) ?>
-
-    <p class="form-help"><?= t('Maximum size: ') ?><?= is_integer($max_size) ? $this->text->bytes($max_size) : $max_size ?></p>
-
-    <div class="form-actions">
-        <button type="submit" class="btn btn-blue"><?= t('Import') ?></button>
-    </div>
-</form>
-<div class="page-header">
-    <h2><?= t('Instructions') ?></h2>
-</div>
-<div class="alert">
-    <ul>
-        <li><?= t('Your file must use the predefined CSV format') ?></li>
-        <li><?= t('Your file must be encoded in UTF-8') ?></li>
-        <li><?= t('The first row must be the header') ?></li>
-        <li><?= t('Duplicates are not verified for you') ?></li>
-        <li><?= t('The due date must use the ISO format: YYYY-MM-DD') ?></li>
-    </ul>
-</div>
-<p><i class="fa fa-download fa-fw"></i><?= $this->url->link(t('Download CSV template'), 'TaskImportController', 'template', array('project_id' => $project['id'])) ?></p>
-- 
cgit v1.2.3