From 57f66cc855458d9fd76c9a3073de2852a6e0712f Mon Sep 17 00:00:00 2001 From: Dj Padzensky Date: Tue, 19 Jul 2016 19:16:07 -0700 Subject: ProjectPermissionController: make sure groups don't exist before creating them Adding logic to check for a group by external ID, before trying to create it. --- app/Controller/ProjectPermissionController.php | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) (limited to 'app') diff --git a/app/Controller/ProjectPermissionController.php b/app/Controller/ProjectPermissionController.php index f3ca6ed9..cbcdf77d 100644 --- a/app/Controller/ProjectPermissionController.php +++ b/app/Controller/ProjectPermissionController.php @@ -147,7 +147,13 @@ class ProjectPermissionController extends BaseController $values = $this->request->getValues(); if (empty($values['group_id']) && ! empty($values['external_id'])) { - $values['group_id'] = $this->groupModel->create($values['name'], $values['external_id']); + $group = $this->groupModel->getByExternalId($values['external_id']); + if ($group) { + $values['group_id'] = $group['id']; + } + else { + $values['group_id'] = $this->groupModel->create($values['name'], $values['external_id']); + } } if ($this->projectGroupRoleModel->addGroup($project['id'], $values['group_id'], $values['role'])) { -- cgit v1.2.3