From 81f3131bbc4eaabf8f7e2d8825e0ba45a5e1b507 Mon Sep 17 00:00:00 2001
From: mluepkes <michael@luepkes.net>
Date: Mon, 12 Jan 2015 00:11:48 +0100
Subject: Implemented Project duplication with Tasks within Controller\Project

---
 app/Controller/Project.php | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

(limited to 'app')

diff --git a/app/Controller/Project.php b/app/Controller/Project.php
index d0da53d0..2aa4ac74 100644
--- a/app/Controller/Project.php
+++ b/app/Controller/Project.php
@@ -307,7 +307,14 @@ class Project extends Base
 
             $this->checkCSRFParam();
 
-            if ($this->project->duplicate($project['id'])) {
+            $clone_project_id = $this->project->duplicate($project['id']);
+
+            if ($clone_project_id) {
+                // Find all task for source project and clone to target project
+                $tasks = $this->taskFinder->getAll($project['id']);
+                foreach($tasks as $task) {
+                    $this->taskDuplication->duplicateToProject($task['id'], $clone_project_id);
+                }
                 $this->session->flash(t('Project cloned successfully.'));
             } else {
                 $this->session->flashError(t('Unable to clone this project.'));
-- 
cgit v1.2.3


From 569c99a73302271b80cd7c8a25356ea285606563 Mon Sep 17 00:00:00 2001
From: Michael Lüpkes <michael@luepkes.net>
Date: Tue, 13 Jan 2015 14:09:02 +0100
Subject: set maxlength for name input fields in templates

---
 app/Template/board/edit.php     | 4 ++--
 app/Template/category/edit.php  | 2 +-
 app/Template/category/index.php | 2 +-
 app/Template/project/edit.php   | 2 +-
 app/Template/project/new.php    | 2 +-
 app/Template/subtask/create.php | 2 +-
 app/Template/subtask/edit.php   | 2 +-
 app/Template/swimlane/edit.php  | 2 +-
 app/Template/swimlane/index.php | 4 ++--
 app/Template/task/edit.php      | 2 +-
 app/Template/task/new.php       | 2 +-
 app/Template/user/edit.php      | 2 +-
 app/Template/user/new.php       | 2 +-
 13 files changed, 15 insertions(+), 15 deletions(-)

(limited to 'app')

diff --git a/app/Template/board/edit.php b/app/Template/board/edit.php
index 65a8fb26..f30a65c1 100644
--- a/app/Template/board/edit.php
+++ b/app/Template/board/edit.php
@@ -17,7 +17,7 @@
         <?php foreach ($columns as $column): ?>
         <tr>
             <td><?= $this->formLabel('#'.++$i, 'title['.$column['id'].']', array('title="column_id='.$column['id'].'"')) ?></td>
-            <td><?= $this->formText('title['.$column['id'].']', $values, $errors, array('required')) ?></td>
+            <td><?= $this->formText('title['.$column['id'].']', $values, $errors, array('required', 'maxlength="50"')) ?></td>
             <td><?= $this->formNumber('task_limit['.$column['id'].']', $values, $errors, array('placeholder="'.t('limit').'"')) ?></td>
             <td>
                 <ul>
@@ -53,7 +53,7 @@
     <?= $this->formHidden('project_id', $values) ?>
 
     <?= $this->formLabel(t('Title'), 'title') ?>
-    <?= $this->formText('title', $values, $errors, array('required')) ?>
+    <?= $this->formText('title', $values, $errors, array('required', 'maxlength="50"')) ?>
 
     <div class="form-actions">
         <input type="submit" value="<?= t('Add this column') ?>" class="btn btn-blue"/>
diff --git a/app/Template/category/edit.php b/app/Template/category/edit.php
index bec175d5..46d47782 100644
--- a/app/Template/category/edit.php
+++ b/app/Template/category/edit.php
@@ -10,7 +10,7 @@
     <?= $this->formHidden('project_id', $values) ?>
 
     <?= $this->formLabel(t('Category Name'), 'name') ?>
-    <?= $this->formText('name', $values, $errors, array('autofocus required')) ?>
+    <?= $this->formText('name', $values, $errors, array('autofocus', 'required', 'maxlength="50"')) ?>
 
     <div class="form-actions">
         <input type="submit" value="<?= t('Save') ?>" class="btn btn-blue"/>
diff --git a/app/Template/category/index.php b/app/Template/category/index.php
index f876275f..d5b50af4 100644
--- a/app/Template/category/index.php
+++ b/app/Template/category/index.php
@@ -34,7 +34,7 @@
     <?= $this->formHidden('project_id', $values) ?>
 
     <?= $this->formLabel(t('Category Name'), 'name') ?>
-    <?= $this->formText('name', $values, $errors, array('autofocus required')) ?>
+    <?= $this->formText('name', $values, $errors, array('autofocus', 'required', 'maxlength="50"')) ?>
 
     <div class="form-actions">
         <input type="submit" value="<?= t('Save') ?>" class="btn btn-blue"/>
diff --git a/app/Template/project/edit.php b/app/Template/project/edit.php
index bb776a06..a1b945cd 100644
--- a/app/Template/project/edit.php
+++ b/app/Template/project/edit.php
@@ -7,7 +7,7 @@
     <?= $this->formHidden('id', $values) ?>
 
     <?= $this->formLabel(t('Name'), 'name') ?>
-    <?= $this->formText('name', $values, $errors, array('required')) ?>
+    <?= $this->formText('name', $values, $errors, array('required', 'maxlength="50"')) ?>
 
     <div class="form-actions">
         <input type="submit" value="<?= t('Save') ?>" class="btn btn-blue"/>
diff --git a/app/Template/project/new.php b/app/Template/project/new.php
index 91db75e1..b68258b4 100644
--- a/app/Template/project/new.php
+++ b/app/Template/project/new.php
@@ -10,7 +10,7 @@
         <?= $this->formCsrf() ?>
         <?= $this->formHidden('is_private', $values) ?>
         <?= $this->formLabel(t('Name'), 'name') ?>
-        <?= $this->formText('name', $values, $errors, array('autofocus', 'required')) ?>
+        <?= $this->formText('name', $values, $errors, array('autofocus', 'required', 'maxlength="50"')) ?>
 
         <div class="form-actions">
             <input type="submit" value="<?= t('Save') ?>" class="btn btn-blue"/>
diff --git a/app/Template/subtask/create.php b/app/Template/subtask/create.php
index 73a08af1..be7fc311 100644
--- a/app/Template/subtask/create.php
+++ b/app/Template/subtask/create.php
@@ -9,7 +9,7 @@
     <?= $this->formHidden('task_id', $values) ?>
 
     <?= $this->formLabel(t('Title'), 'title') ?>
-    <?= $this->formText('title', $values, $errors, array('required autofocus')) ?><br/>
+    <?= $this->formText('title', $values, $errors, array('required', 'autofocus', 'maxlength="50"')) ?><br/>
 
     <?= $this->formLabel(t('Assignee'), 'user_id') ?>
     <?= $this->formSelect('user_id', $users_list, $values, $errors) ?><br/>
diff --git a/app/Template/subtask/edit.php b/app/Template/subtask/edit.php
index 4920eb32..8350dc09 100644
--- a/app/Template/subtask/edit.php
+++ b/app/Template/subtask/edit.php
@@ -10,7 +10,7 @@
     <?= $this->formHidden('task_id', $values) ?>
 
     <?= $this->formLabel(t('Title'), 'title') ?>
-    <?= $this->formText('title', $values, $errors, array('required autofocus')) ?><br/>
+    <?= $this->formText('title', $values, $errors, array('required', 'autofocus', 'maxlength="50"')) ?><br/>
 
     <?= $this->formLabel(t('Status'), 'status') ?>
     <?= $this->formSelect('status', $status_list, $values, $errors) ?><br/>
diff --git a/app/Template/swimlane/edit.php b/app/Template/swimlane/edit.php
index ea842f31..f39b6fde 100644
--- a/app/Template/swimlane/edit.php
+++ b/app/Template/swimlane/edit.php
@@ -10,7 +10,7 @@
     <?= $this->formHidden('project_id', $values) ?>
 
     <?= $this->formLabel(t('Name'), 'name') ?>
-    <?= $this->formText('name', $values, $errors, array('autofocus required')) ?>
+    <?= $this->formText('name', $values, $errors, array('autofocus', 'required', 'maxlength="50"')) ?>
 
     <div class="form-actions">
         <input type="submit" value="<?= t('Save') ?>" class="btn btn-blue"/>
diff --git a/app/Template/swimlane/index.php b/app/Template/swimlane/index.php
index 2bcddf75..3482a56c 100644
--- a/app/Template/swimlane/index.php
+++ b/app/Template/swimlane/index.php
@@ -14,7 +14,7 @@
     <?= $this->formHidden('project_id', $values) ?>
 
     <?= $this->formLabel(t('Name'), 'name') ?>
-    <?= $this->formText('name', $values, $errors, array('autofocus required')) ?>
+    <?= $this->formText('name', $values, $errors, array('autofocus', 'required', 'maxlength="50"')) ?>
 
     <div class="form-actions">
         <input type="submit" value="<?= t('Save') ?>" class="btn btn-blue"/>
@@ -30,7 +30,7 @@
     <?= $this->formHidden('id', $default_swimlane) ?>
 
     <?= $this->formLabel(t('Rename'), 'default_swimlane') ?>
-    <?= $this->formText('default_swimlane', $default_swimlane, array(), array('autofocus required')) ?><br/>
+    <?= $this->formText('default_swimlane', $default_swimlane, array(), array('autofocus', 'required', 'maxlength="50"')) ?><br/>
 
     <?= $this->formCheckbox('show_default_swimlane', t('Show default swimlane'), 1, isset($default_swimlane['show_default_swimlane']) && $default_swimlane['show_default_swimlane'] == 1) ?>
 
diff --git a/app/Template/task/edit.php b/app/Template/task/edit.php
index 51cb2884..0df1676b 100644
--- a/app/Template/task/edit.php
+++ b/app/Template/task/edit.php
@@ -9,7 +9,7 @@
     <div class="form-column">
 
         <?= $this->formLabel(t('Title'), 'title') ?>
-        <?= $this->formText('title', $values, $errors, array('required')) ?><br/>
+        <?= $this->formText('title', $values, $errors, array('required', 'maxlength="200"')) ?><br/>
 
         <?= $this->formLabel(t('Description'), 'description') ?>
 
diff --git a/app/Template/task/new.php b/app/Template/task/new.php
index 6294968a..5eef9923 100644
--- a/app/Template/task/new.php
+++ b/app/Template/task/new.php
@@ -17,7 +17,7 @@
 
     <div class="form-column">
         <?= $this->formLabel(t('Title'), 'title') ?>
-        <?= $this->formText('title', $values, $errors, array('autofocus', 'required'), 'form-input-large') ?><br/>
+        <?= $this->formText('title', $values, $errors, array('autofocus', 'required', 'maxlength="200"'), 'form-input-large') ?><br/>
 
         <?= $this->formLabel(t('Description'), 'description') ?>
 
diff --git a/app/Template/user/edit.php b/app/Template/user/edit.php
index 43171d29..310a1ed0 100644
--- a/app/Template/user/edit.php
+++ b/app/Template/user/edit.php
@@ -9,7 +9,7 @@
     <?= $this->formHidden('is_ldap_user', $values) ?>
 
     <?= $this->formLabel(t('Username'), 'username') ?>
-    <?= $this->formText('username', $values, $errors, array('required', $values['is_ldap_user'] == 1 ? 'readonly' : '')) ?><br/>
+    <?= $this->formText('username', $values, $errors, array('required', $values['is_ldap_user'] == 1 ? 'readonly' : '', 'maxlength="50"')) ?><br/>
 
     <?= $this->formLabel(t('Name'), 'name') ?>
     <?= $this->formText('name', $values, $errors) ?><br/>
diff --git a/app/Template/user/new.php b/app/Template/user/new.php
index 1413bd3d..e56f38b1 100644
--- a/app/Template/user/new.php
+++ b/app/Template/user/new.php
@@ -10,7 +10,7 @@
         <?= $this->formCsrf() ?>
 
         <?= $this->formLabel(t('Username'), 'username') ?>
-        <?= $this->formText('username', $values, $errors, array('autofocus', 'required')) ?><br/>
+        <?= $this->formText('username', $values, $errors, array('autofocus', 'required', 'maxlength="50"')) ?><br/>
 
         <?= $this->formLabel(t('Name'), 'name') ?>
         <?= $this->formText('name', $values, $errors) ?><br/>
-- 
cgit v1.2.3


From 99323ba5c80ab01f6d66548262d281e30ecbed6a Mon Sep 17 00:00:00 2001
From: Michael Lüpkes <michael@luepkes.net>
Date: Tue, 13 Jan 2015 14:14:42 +0100
Subject: Removed Project duplication in Controller

---
 app/Controller/Project.php | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

(limited to 'app')

diff --git a/app/Controller/Project.php b/app/Controller/Project.php
index 2aa4ac74..d0da53d0 100644
--- a/app/Controller/Project.php
+++ b/app/Controller/Project.php
@@ -307,14 +307,7 @@ class Project extends Base
 
             $this->checkCSRFParam();
 
-            $clone_project_id = $this->project->duplicate($project['id']);
-
-            if ($clone_project_id) {
-                // Find all task for source project and clone to target project
-                $tasks = $this->taskFinder->getAll($project['id']);
-                foreach($tasks as $task) {
-                    $this->taskDuplication->duplicateToProject($task['id'], $clone_project_id);
-                }
+            if ($this->project->duplicate($project['id'])) {
                 $this->session->flash(t('Project cloned successfully.'));
             } else {
                 $this->session->flashError(t('Unable to clone this project.'));
-- 
cgit v1.2.3