From 73a5b9bc75d40a30e7c9674b292957657ac01f63 Mon Sep 17 00:00:00 2001 From: Frederic Guillot Date: Sat, 17 Oct 2015 09:51:15 -0400 Subject: Make user notifications pluggable --- tests/units/Base.php | 6 + tests/units/Model/EmailNotificationTest.php | 118 -------------- tests/units/Model/NotificationFilterTest.php | 193 ---------------------- tests/units/Model/NotificationTest.php | 197 ---------------------- tests/units/Model/NotificationTypeTest.php | 26 --- tests/units/Model/UserNotificationFilterTest.php | 193 ++++++++++++++++++++++ tests/units/Model/UserNotificationTest.php | 198 +++++++++++++++++++++++ tests/units/Model/UserNotificationTypeTest.php | 30 ++++ tests/units/Model/UserUnreadNotificationTest.php | 141 ++++++++++++++++ tests/units/Model/WebNotificationTest.php | 141 ---------------- tests/units/Notification/MailTest.php | 118 ++++++++++++++ 11 files changed, 686 insertions(+), 675 deletions(-) delete mode 100644 tests/units/Model/EmailNotificationTest.php delete mode 100644 tests/units/Model/NotificationFilterTest.php delete mode 100644 tests/units/Model/NotificationTest.php delete mode 100644 tests/units/Model/NotificationTypeTest.php create mode 100644 tests/units/Model/UserNotificationFilterTest.php create mode 100644 tests/units/Model/UserNotificationTest.php create mode 100644 tests/units/Model/UserNotificationTypeTest.php create mode 100644 tests/units/Model/UserUnreadNotificationTest.php delete mode 100644 tests/units/Model/WebNotificationTest.php create mode 100644 tests/units/Notification/MailTest.php (limited to 'tests') diff --git a/tests/units/Base.php b/tests/units/Base.php index 3b7ffa2a..fe054344 100644 --- a/tests/units/Base.php +++ b/tests/units/Base.php @@ -88,6 +88,12 @@ abstract class Base extends PHPUnit_Framework_TestCase $this->container['logger']->setLogger(new File('/dev/null')); $this->container['httpClient'] = new FakeHttpClient; $this->container['emailClient'] = $this->getMockBuilder('EmailClient')->setMethods(array('send'))->getMock(); + + $this->container['userNotificationType'] = $this + ->getMockBuilder('\Kanboard\Model\UserNotificationType') + ->setConstructorArgs(array($this->container)) + ->setMethods(array('getType')) + ->getMock(); } public function tearDown() diff --git a/tests/units/Model/EmailNotificationTest.php b/tests/units/Model/EmailNotificationTest.php deleted file mode 100644 index 342f0aa9..00000000 --- a/tests/units/Model/EmailNotificationTest.php +++ /dev/null @@ -1,118 +0,0 @@ -container); - $p = new Project($this->container); - $tf = new TaskFinder($this->container); - $tc = new TaskCreation($this->container); - $s = new Subtask($this->container); - $c = new Comment($this->container); - $f = new File($this->container); - - $this->assertEquals(1, $p->create(array('name' => 'test'))); - $this->assertEquals(1, $tc->create(array('title' => 'test', 'project_id' => 1))); - $this->assertEquals(1, $s->create(array('title' => 'test', 'task_id' => 1))); - $this->assertEquals(1, $c->create(array('comment' => 'test', 'task_id' => 1, 'user_id' => 1))); - $this->assertEquals(1, $f->create(1, 'test', 'blah', 123)); - - $task = $tf->getDetails(1); - $subtask = $s->getById(1, true); - $comment = $c->getById(1); - $file = $c->getById(1); - - $this->assertNotEmpty($task); - $this->assertNotEmpty($subtask); - $this->assertNotEmpty($comment); - $this->assertNotEmpty($file); - - foreach (NotificationSubscriber::getSubscribedEvents() as $event => $values) { - $this->assertNotEmpty($en->getMailContent($event, array( - 'task' => $task, - 'comment' => $comment, - 'subtask' => $subtask, - 'file' => $file, - 'changes' => array()) - )); - - $this->assertNotEmpty($en->getMailSubject($event, array( - 'task' => $task, - 'comment' => $comment, - 'subtask' => $subtask, - 'file' => $file, - 'changes' => array()) - )); - } - } - - public function testSendWithEmailAddress() - { - $en = new EmailNotification($this->container); - $p = new Project($this->container); - $tf = new TaskFinder($this->container); - $tc = new TaskCreation($this->container); - $u = new User($this->container); - - $this->assertEquals(1, $p->create(array('name' => 'test'))); - $this->assertEquals(1, $tc->create(array('title' => 'test', 'project_id' => 1))); - $this->assertTrue($u->update(array('id' => 1, 'email' => 'test@localhost'))); - - $this->container['emailClient'] = $this - ->getMockBuilder('\Kanboard\Core\Mail\Client') - ->setConstructorArgs(array($this->container)) - ->setMethods(array('send')) - ->getMock(); - - $this->container['emailClient'] - ->expects($this->once()) - ->method('send') - ->with( - $this->equalTo('test@localhost'), - $this->equalTo('admin'), - $this->equalTo('[test][New task] test (#1)'), - $this->stringContains('test') - ); - - $en->send($u->getById(1), Task::EVENT_CREATE, array('task' => $tf->getDetails(1))); - } - - public function testSendWithoutEmailAddress() - { - $en = new EmailNotification($this->container); - $p = new Project($this->container); - $tf = new TaskFinder($this->container); - $tc = new TaskCreation($this->container); - $u = new User($this->container); - - $this->assertEquals(1, $p->create(array('name' => 'test'))); - $this->assertEquals(1, $tc->create(array('title' => 'test', 'project_id' => 1))); - - $this->container['emailClient'] = $this - ->getMockBuilder('\Kanboard\Core\Mail\Client') - ->setConstructorArgs(array($this->container)) - ->setMethods(array('send')) - ->getMock(); - - $this->container['emailClient'] - ->expects($this->never()) - ->method('send'); - - $en->send($u->getById(1), Task::EVENT_CREATE, array('task' => $tf->getDetails(1))); - } -} diff --git a/tests/units/Model/NotificationFilterTest.php b/tests/units/Model/NotificationFilterTest.php deleted file mode 100644 index 2f8cdc8a..00000000 --- a/tests/units/Model/NotificationFilterTest.php +++ /dev/null @@ -1,193 +0,0 @@ -container); - $filters = $nf->getFilters(); - $this->assertArrayHasKey(NotificationFilter::FILTER_NONE, $filters); - $this->assertArrayHasKey(NotificationFilter::FILTER_BOTH, $filters); - $this->assertArrayHasKey(NotificationFilter::FILTER_CREATOR, $filters); - $this->assertArrayHasKey(NotificationFilter::FILTER_ASSIGNEE, $filters); - } - - public function testSaveProjectFilter() - { - $nf = new NotificationFilter($this->container); - $p = new Project($this->container); - - $this->assertEquals(1, $p->create(array('name' => 'UnitTest1'))); - $this->assertEquals(2, $p->create(array('name' => 'UnitTest2'))); - - $this->assertEmpty($nf->getUserSelectedProjects(1)); - $nf->saveUserSelectedProjects(1, array(1, 2)); - $this->assertEquals(array(1, 2), $nf->getUserSelectedProjects(1)); - } - - public function testSaveUserFilter() - { - $nf = new NotificationFilter($this->container); - - $this->assertEquals(NotificationFilter::FILTER_BOTH, $nf->getUserSelectedFilter(1)); - $nf->saveUserFilter(1, NotificationFilter::FILTER_CREATOR); - $this->assertEquals(NotificationFilter::FILTER_CREATOR, $nf->getUserSelectedFilter(1)); - } - - public function testFilterNone() - { - $u = new User($this->container); - $n = new NotificationFilter($this->container); - - $this->assertEquals(2, $u->create(array('username' => 'user1', 'notifications_filter' => NotificationFilter::FILTER_NONE))); - $this->assertTrue($n->filterNone($u->getById(2), array())); - - $this->assertEquals(3, $u->create(array('username' => 'user2', 'notifications_filter' => NotificationFilter::FILTER_BOTH))); - $this->assertFalse($n->filterNone($u->getById(3), array())); - } - - public function testFilterCreator() - { - $u = new User($this->container); - $n = new NotificationFilter($this->container); - - $this->assertEquals(2, $u->create(array('username' => 'user1', 'notifications_filter' => NotificationFilter::FILTER_CREATOR))); - $this->assertTrue($n->filterCreator($u->getById(2), array('task' => array('creator_id' => 2)))); - - $this->assertEquals(3, $u->create(array('username' => 'user2', 'notifications_filter' => NotificationFilter::FILTER_CREATOR))); - $this->assertFalse($n->filterCreator($u->getById(3), array('task' => array('creator_id' => 1)))); - - $this->assertEquals(4, $u->create(array('username' => 'user3', 'notifications_filter' => NotificationFilter::FILTER_NONE))); - $this->assertFalse($n->filterCreator($u->getById(4), array('task' => array('creator_id' => 2)))); - } - - public function testFilterAssignee() - { - $u = new User($this->container); - $n = new NotificationFilter($this->container); - - $this->assertEquals(2, $u->create(array('username' => 'user1', 'notifications_filter' => NotificationFilter::FILTER_ASSIGNEE))); - $this->assertTrue($n->filterAssignee($u->getById(2), array('task' => array('owner_id' => 2)))); - - $this->assertEquals(3, $u->create(array('username' => 'user2', 'notifications_filter' => NotificationFilter::FILTER_ASSIGNEE))); - $this->assertFalse($n->filterAssignee($u->getById(3), array('task' => array('owner_id' => 1)))); - - $this->assertEquals(4, $u->create(array('username' => 'user3', 'notifications_filter' => NotificationFilter::FILTER_NONE))); - $this->assertFalse($n->filterAssignee($u->getById(4), array('task' => array('owner_id' => 2)))); - } - - public function testFilterBoth() - { - $u = new User($this->container); - $n = new NotificationFilter($this->container); - - $this->assertEquals(2, $u->create(array('username' => 'user1', 'notifications_filter' => NotificationFilter::FILTER_BOTH))); - $this->assertTrue($n->filterBoth($u->getById(2), array('task' => array('owner_id' => 2, 'creator_id' => 1)))); - $this->assertTrue($n->filterBoth($u->getById(2), array('task' => array('owner_id' => 0, 'creator_id' => 2)))); - - $this->assertEquals(3, $u->create(array('username' => 'user2', 'notifications_filter' => NotificationFilter::FILTER_BOTH))); - $this->assertFalse($n->filterBoth($u->getById(3), array('task' => array('owner_id' => 1, 'creator_id' => 1)))); - $this->assertFalse($n->filterBoth($u->getById(3), array('task' => array('owner_id' => 2, 'creator_id' => 1)))); - - $this->assertEquals(4, $u->create(array('username' => 'user3', 'notifications_filter' => NotificationFilter::FILTER_NONE))); - $this->assertFalse($n->filterBoth($u->getById(4), array('task' => array('owner_id' => 2, 'creator_id' => 1)))); - } - - public function testFilterProject() - { - $u = new User($this->container); - $n = new Notification($this->container); - $nf = new NotificationFilter($this->container); - $p = new Project($this->container); - - $this->assertEquals(1, $p->create(array('name' => 'UnitTest1'))); - $this->assertEquals(2, $p->create(array('name' => 'UnitTest2'))); - - // No project selected - $this->assertTrue($nf->filterProject($u->getById(1), array())); - - // User that select only some projects - $this->assertEquals(2, $u->create(array('username' => 'user2', 'notifications_filter' => NotificationFilter::FILTER_NONE))); - $n->saveSettings(2, array('notifications_enabled' => 1, 'notification_projects' => array(2 => true))); - - $this->assertFalse($nf->filterProject($u->getById(2), array('task' => array('project_id' => 1)))); - $this->assertTrue($nf->filterProject($u->getById(2), array('task' => array('project_id' => 2)))); - } - - public function testFilterUserWithNoFilter() - { - $u = new User($this->container); - $n = new NotificationFilter($this->container); - $p = new Project($this->container); - - $this->assertEquals(2, $u->create(array('username' => 'user2', 'notifications_filter' => NotificationFilter::FILTER_NONE))); - - $this->assertTrue($n->shouldReceiveNotification($u->getById(2), array('task' => array('project_id' => 1)))); - } - - public function testFilterUserWithAssigneeFilter() - { - $u = new User($this->container); - $n = new NotificationFilter($this->container); - $p = new Project($this->container); - - $this->assertEquals(2, $u->create(array('username' => 'user2', 'notifications_filter' => NotificationFilter::FILTER_ASSIGNEE))); - - $this->assertTrue($n->shouldReceiveNotification($u->getById(2), array('task' => array('project_id' => 1, 'owner_id' => 2)))); - $this->assertFalse($n->shouldReceiveNotification($u->getById(2), array('task' => array('project_id' => 1, 'owner_id' => 1)))); - } - - public function testFilterUserWithCreatorFilter() - { - $u = new User($this->container); - $n = new NotificationFilter($this->container); - $p = new Project($this->container); - - $this->assertEquals(2, $u->create(array('username' => 'user2', 'notifications_filter' => NotificationFilter::FILTER_CREATOR))); - - $this->assertTrue($n->shouldReceiveNotification($u->getById(2), array('task' => array('project_id' => 1, 'creator_id' => 2)))); - $this->assertFalse($n->shouldReceiveNotification($u->getById(2), array('task' => array('project_id' => 1, 'creator_id' => 1)))); - } - - public function testFilterUserWithBothFilter() - { - $u = new User($this->container); - $n = new NotificationFilter($this->container); - $p = new Project($this->container); - - $this->assertEquals(2, $u->create(array('username' => 'user2', 'notifications_filter' => NotificationFilter::FILTER_BOTH))); - - $this->assertTrue($n->shouldReceiveNotification($u->getById(2), array('task' => array('project_id' => 1, 'creator_id' => 2, 'owner_id' => 3)))); - $this->assertTrue($n->shouldReceiveNotification($u->getById(2), array('task' => array('project_id' => 1, 'creator_id' => 0, 'owner_id' => 2)))); - $this->assertFalse($n->shouldReceiveNotification($u->getById(2), array('task' => array('project_id' => 1, 'creator_id' => 4, 'owner_id' => 1)))); - $this->assertFalse($n->shouldReceiveNotification($u->getById(2), array('task' => array('project_id' => 1, 'creator_id' => 5, 'owner_id' => 0)))); - } - - public function testFilterUserWithBothFilterAndProjectSelected() - { - $u = new User($this->container); - $n = new Notification($this->container); - $nf = new NotificationFilter($this->container); - $p = new Project($this->container); - - $this->assertEquals(1, $p->create(array('name' => 'UnitTest1'))); - $this->assertEquals(2, $p->create(array('name' => 'UnitTest2'))); - - $this->assertEquals(2, $u->create(array('username' => 'user2', 'notifications_filter' => NotificationFilter::FILTER_BOTH))); - - $n->saveSettings(2, array('notifications_enabled' => 1, 'notification_projects' => array(2 => true))); - - $this->assertFalse($nf->shouldReceiveNotification($u->getById(2), array('task' => array('project_id' => 1, 'creator_id' => 2, 'owner_id' => 3)))); - $this->assertFalse($nf->shouldReceiveNotification($u->getById(2), array('task' => array('project_id' => 1, 'creator_id' => 0, 'owner_id' => 2)))); - - $this->assertTrue($nf->shouldReceiveNotification($u->getById(2), array('task' => array('project_id' => 2, 'creator_id' => 2, 'owner_id' => 3)))); - $this->assertTrue($nf->shouldReceiveNotification($u->getById(2), array('task' => array('project_id' => 2, 'creator_id' => 0, 'owner_id' => 2)))); - } -} diff --git a/tests/units/Model/NotificationTest.php b/tests/units/Model/NotificationTest.php deleted file mode 100644 index 251ae1b2..00000000 --- a/tests/units/Model/NotificationTest.php +++ /dev/null @@ -1,197 +0,0 @@ -container); - $p = new Project($this->container); - $n = new Notification($this->container); - $pp = new ProjectPermission($this->container); - - $this->assertEquals(1, $p->create(array('name' => 'UnitTest1'))); - $this->assertEquals(2, $u->create(array('username' => 'user1'))); - $this->assertTrue($pp->addMember(1, 2)); - - $this->assertEmpty($n->getUsersWithNotificationEnabled(1)); - $n->enableNotification(2); - $this->assertNotEmpty($n->getUsersWithNotificationEnabled(1)); - $n->disableNotification(2); - $this->assertEmpty($n->getUsersWithNotificationEnabled(1)); - } - - public function testReadWriteSettings() - { - $n = new Notification($this->container); - $p = new Project($this->container); - - $this->assertEquals(1, $p->create(array('name' => 'UnitTest1'))); - - $n->saveSettings(1, array( - 'notifications_enabled' => 1, - 'notifications_filter' => NotificationFilter::FILTER_CREATOR, - 'notification_types' => array(NotificationType::TYPE_EMAIL => 1), - 'notification_projects' => array(), - )); - - $settings = $n->readSettings(1); - $this->assertNotEmpty($settings); - $this->assertEquals(1, $settings['notifications_enabled']); - $this->assertEquals(NotificationFilter::FILTER_CREATOR, $settings['notifications_filter']); - $this->assertEquals(array(NotificationType::TYPE_EMAIL), $settings['notification_types']); - $this->assertEmpty($settings['notification_projects']); - - $n->saveSettings(1, array( - 'notifications_enabled' => 0, - )); - - $settings = $n->readSettings(1); - $this->assertNotEmpty($settings); - $this->assertEquals(0, $settings['notifications_enabled']); - - $n->saveSettings(1, array( - 'notifications_enabled' => 1, - 'notifications_filter' => NotificationFilter::FILTER_ASSIGNEE, - 'notification_types' => array(NotificationType::TYPE_WEB => 1, NotificationType::TYPE_EMAIL => 1), - 'notification_projects' => array(1 => 1), - )); - - $settings = $n->readSettings(1); - $this->assertNotEmpty($settings); - $this->assertEquals(1, $settings['notifications_enabled']); - $this->assertEquals(NotificationFilter::FILTER_ASSIGNEE, $settings['notifications_filter']); - $this->assertEquals(array(NotificationType::TYPE_EMAIL, NotificationType::TYPE_WEB), $settings['notification_types']); - $this->assertEquals(array(1), $settings['notification_projects']); - } - - public function testGetProjectMembersWithNotifications() - { - $u = new User($this->container); - $p = new Project($this->container); - $n = new Notification($this->container); - $pp = new ProjectPermission($this->container); - - $this->assertEquals(1, $p->create(array('name' => 'UnitTest1'))); - - // Email + Notifications enabled - $this->assertNotFalse($u->create(array('username' => 'user1', 'email' => 'user1@here', 'notifications_enabled' => 1))); - - // No email + Notifications enabled - $this->assertNotFalse($u->create(array('username' => 'user2', 'email' => '', 'notifications_enabled' => 1))); - - // Email + Notifications enabled - $this->assertNotFalse($u->create(array('username' => 'user3', 'email' => 'user3@here', 'notifications_enabled' => 1))); - - // No email + notifications disabled - $this->assertNotFalse($u->create(array('username' => 'user4'))); - - // Nobody is member of any projects - $this->assertEmpty($pp->getMembers(1)); - $this->assertEmpty($n->getUsersWithNotificationEnabled(1)); - - // We allow all users to be member of our projects - $this->assertTrue($pp->addMember(1, 1)); - $this->assertTrue($pp->addMember(1, 2)); - $this->assertTrue($pp->addMember(1, 3)); - $this->assertTrue($pp->addMember(1, 4)); - - $this->assertNotEmpty($pp->getMembers(1)); - $users = $n->getUsersWithNotificationEnabled(1); - - $this->assertNotEmpty($users); - $this->assertCount(3, $users); - $this->assertEquals('user1@here', $users[0]['email']); - $this->assertEquals('', $users[1]['email']); - $this->assertEquals('user3@here', $users[2]['email']); - } - - public function testGetUsersWithNotificationsWhenEverybodyAllowed() - { - $u = new User($this->container); - $p = new Project($this->container); - $n = new Notification($this->container); - $pp = new ProjectPermission($this->container); - - $this->assertEquals(1, $p->create(array('name' => 'UnitTest1', 'is_everybody_allowed' => 1))); - $this->assertTrue($pp->isEverybodyAllowed(1)); - - // Email + Notifications enabled - $this->assertNotFalse($u->create(array('username' => 'user1', 'email' => 'user1@here', 'notifications_enabled' => 1))); - - // No email + Notifications enabled - $this->assertNotFalse($u->create(array('username' => 'user2', 'email' => '', 'notifications_enabled' => 1))); - - // Email + Notifications enabled - $this->assertNotFalse($u->create(array('username' => 'user3', 'email' => 'user3@here', 'notifications_enabled' => 1))); - - // No email + notifications disabled - $this->assertNotFalse($u->create(array('username' => 'user4'))); - - $users = $n->getUsersWithNotificationEnabled(1); - - $this->assertNotEmpty($users); - $this->assertCount(3, $users); - $this->assertEquals('user1@here', $users[0]['email']); - $this->assertEquals('', $users[1]['email']); - $this->assertEquals('user3@here', $users[2]['email']); - } - - public function testSendNotifications() - { - $u = new User($this->container); - $n = new Notification($this->container); - $p = new Project($this->container); - $tc = new TaskCreation($this->container); - $tf = new TaskFinder($this->container); - $pp = new ProjectPermission($this->container); - - $this->assertEquals(1, $p->create(array('name' => 'UnitTest1', 'is_everybody_allowed' => 1))); - $this->assertEquals(1, $tc->create(array('title' => 'test', 'project_id' => 1))); - $this->assertTrue($u->update(array('id' => 1, 'email' => 'test@localhost'))); - $this->assertTrue($pp->isEverybodyAllowed(1)); - - $n->saveSettings(1, array( - 'notifications_enabled' => 1, - 'notifications_filter' => NotificationFilter::FILTER_NONE, - 'notification_types' => array(NotificationType::TYPE_WEB => 1, NotificationType::TYPE_EMAIL => 1), - )); - - $this->container['emailNotification'] = $this - ->getMockBuilder('\Kanboard\Model\EmailNotification') - ->setConstructorArgs(array($this->container)) - ->setMethods(array('send')) - ->getMock(); - - $this->container['webNotification'] = $this - ->getMockBuilder('\Kanboard\Model\WebNotification') - ->setConstructorArgs(array($this->container)) - ->setMethods(array('send')) - ->getMock(); - - $this->container['emailNotification'] - ->expects($this->once()) - ->method('send'); - - $this->container['webNotification'] - ->expects($this->once()) - ->method('send'); - - $n->sendNotifications(Task::EVENT_CREATE, array('task' => $tf->getDetails(1))); - } -} diff --git a/tests/units/Model/NotificationTypeTest.php b/tests/units/Model/NotificationTypeTest.php deleted file mode 100644 index bf3c78a0..00000000 --- a/tests/units/Model/NotificationTypeTest.php +++ /dev/null @@ -1,26 +0,0 @@ -container); - $this->assertEquals(array('email' => 'Email', 'web' => 'Web'), $nt->getTypes()); - } - - public function testGetUserNotificationTypes() - { - $nt = new NotificationType($this->container); - $types = $nt->getUserSelectedTypes(1); - $this->assertEmpty($types); - - $this->assertTrue($nt->saveUserSelectedTypes(1, array('email', 'web'))); - $types = $nt->getUserSelectedTypes(1); - $this->assertNotEmpty($types); - $this->assertEquals(array('email', 'web'), $types); - } -} diff --git a/tests/units/Model/UserNotificationFilterTest.php b/tests/units/Model/UserNotificationFilterTest.php new file mode 100644 index 00000000..0b5f1d98 --- /dev/null +++ b/tests/units/Model/UserNotificationFilterTest.php @@ -0,0 +1,193 @@ +container); + $filters = $nf->getFilters(); + $this->assertArrayHasKey(UserNotificationFilter::FILTER_NONE, $filters); + $this->assertArrayHasKey(UserNotificationFilter::FILTER_BOTH, $filters); + $this->assertArrayHasKey(UserNotificationFilter::FILTER_CREATOR, $filters); + $this->assertArrayHasKey(UserNotificationFilter::FILTER_ASSIGNEE, $filters); + } + + public function testSaveProjectFilter() + { + $nf = new UserNotificationFilter($this->container); + $p = new Project($this->container); + + $this->assertEquals(1, $p->create(array('name' => 'UnitTest1'))); + $this->assertEquals(2, $p->create(array('name' => 'UnitTest2'))); + + $this->assertEmpty($nf->getSelectedProjects(1)); + $nf->saveSelectedProjects(1, array(1, 2)); + $this->assertEquals(array(1, 2), $nf->getSelectedProjects(1)); + } + + public function testSaveUserFilter() + { + $nf = new UserNotificationFilter($this->container); + + $this->assertEquals(UserNotificationFilter::FILTER_BOTH, $nf->getSelectedFilter(1)); + $nf->saveFilter(1, UserNotificationFilter::FILTER_CREATOR); + $this->assertEquals(UserNotificationFilter::FILTER_CREATOR, $nf->getSelectedFilter(1)); + } + + public function testFilterNone() + { + $u = new User($this->container); + $n = new UserNotificationFilter($this->container); + + $this->assertEquals(2, $u->create(array('username' => 'user1', 'notifications_filter' => UserNotificationFilter::FILTER_NONE))); + $this->assertTrue($n->filterNone($u->getById(2), array())); + + $this->assertEquals(3, $u->create(array('username' => 'user2', 'notifications_filter' => UserNotificationFilter::FILTER_BOTH))); + $this->assertFalse($n->filterNone($u->getById(3), array())); + } + + public function testFilterCreator() + { + $u = new User($this->container); + $n = new UserNotificationFilter($this->container); + + $this->assertEquals(2, $u->create(array('username' => 'user1', 'notifications_filter' => UserNotificationFilter::FILTER_CREATOR))); + $this->assertTrue($n->filterCreator($u->getById(2), array('task' => array('creator_id' => 2)))); + + $this->assertEquals(3, $u->create(array('username' => 'user2', 'notifications_filter' => UserNotificationFilter::FILTER_CREATOR))); + $this->assertFalse($n->filterCreator($u->getById(3), array('task' => array('creator_id' => 1)))); + + $this->assertEquals(4, $u->create(array('username' => 'user3', 'notifications_filter' => UserNotificationFilter::FILTER_NONE))); + $this->assertFalse($n->filterCreator($u->getById(4), array('task' => array('creator_id' => 2)))); + } + + public function testFilterAssignee() + { + $u = new User($this->container); + $n = new UserNotificationFilter($this->container); + + $this->assertEquals(2, $u->create(array('username' => 'user1', 'notifications_filter' => UserNotificationFilter::FILTER_ASSIGNEE))); + $this->assertTrue($n->filterAssignee($u->getById(2), array('task' => array('owner_id' => 2)))); + + $this->assertEquals(3, $u->create(array('username' => 'user2', 'notifications_filter' => UserNotificationFilter::FILTER_ASSIGNEE))); + $this->assertFalse($n->filterAssignee($u->getById(3), array('task' => array('owner_id' => 1)))); + + $this->assertEquals(4, $u->create(array('username' => 'user3', 'notifications_filter' => UserNotificationFilter::FILTER_NONE))); + $this->assertFalse($n->filterAssignee($u->getById(4), array('task' => array('owner_id' => 2)))); + } + + public function testFilterBoth() + { + $u = new User($this->container); + $n = new UserNotificationFilter($this->container); + + $this->assertEquals(2, $u->create(array('username' => 'user1', 'notifications_filter' => UserNotificationFilter::FILTER_BOTH))); + $this->assertTrue($n->filterBoth($u->getById(2), array('task' => array('owner_id' => 2, 'creator_id' => 1)))); + $this->assertTrue($n->filterBoth($u->getById(2), array('task' => array('owner_id' => 0, 'creator_id' => 2)))); + + $this->assertEquals(3, $u->create(array('username' => 'user2', 'notifications_filter' => UserNotificationFilter::FILTER_BOTH))); + $this->assertFalse($n->filterBoth($u->getById(3), array('task' => array('owner_id' => 1, 'creator_id' => 1)))); + $this->assertFalse($n->filterBoth($u->getById(3), array('task' => array('owner_id' => 2, 'creator_id' => 1)))); + + $this->assertEquals(4, $u->create(array('username' => 'user3', 'notifications_filter' => UserNotificationFilter::FILTER_NONE))); + $this->assertFalse($n->filterBoth($u->getById(4), array('task' => array('owner_id' => 2, 'creator_id' => 1)))); + } + + public function testFilterProject() + { + $u = new User($this->container); + $n = new UserNotification($this->container); + $nf = new UserNotificationFilter($this->container); + $p = new Project($this->container); + + $this->assertEquals(1, $p->create(array('name' => 'UnitTest1'))); + $this->assertEquals(2, $p->create(array('name' => 'UnitTest2'))); + + // No project selected + $this->assertTrue($nf->filterProject($u->getById(1), array())); + + // User that select only some projects + $this->assertEquals(2, $u->create(array('username' => 'user2', 'notifications_filter' => UserNotificationFilter::FILTER_NONE))); + $n->saveSettings(2, array('notifications_enabled' => 1, 'notification_projects' => array(2 => true))); + + $this->assertFalse($nf->filterProject($u->getById(2), array('task' => array('project_id' => 1)))); + $this->assertTrue($nf->filterProject($u->getById(2), array('task' => array('project_id' => 2)))); + } + + public function testFilterUserWithNoFilter() + { + $u = new User($this->container); + $n = new UserNotificationFilter($this->container); + $p = new Project($this->container); + + $this->assertEquals(2, $u->create(array('username' => 'user2', 'notifications_filter' => UserNotificationFilter::FILTER_NONE))); + + $this->assertTrue($n->shouldReceiveNotification($u->getById(2), array('task' => array('project_id' => 1)))); + } + + public function testFilterUserWithAssigneeFilter() + { + $u = new User($this->container); + $n = new UserNotificationFilter($this->container); + $p = new Project($this->container); + + $this->assertEquals(2, $u->create(array('username' => 'user2', 'notifications_filter' => UserNotificationFilter::FILTER_ASSIGNEE))); + + $this->assertTrue($n->shouldReceiveNotification($u->getById(2), array('task' => array('project_id' => 1, 'owner_id' => 2)))); + $this->assertFalse($n->shouldReceiveNotification($u->getById(2), array('task' => array('project_id' => 1, 'owner_id' => 1)))); + } + + public function testFilterUserWithCreatorFilter() + { + $u = new User($this->container); + $n = new UserNotificationFilter($this->container); + $p = new Project($this->container); + + $this->assertEquals(2, $u->create(array('username' => 'user2', 'notifications_filter' => UserNotificationFilter::FILTER_CREATOR))); + + $this->assertTrue($n->shouldReceiveNotification($u->getById(2), array('task' => array('project_id' => 1, 'creator_id' => 2)))); + $this->assertFalse($n->shouldReceiveNotification($u->getById(2), array('task' => array('project_id' => 1, 'creator_id' => 1)))); + } + + public function testFilterUserWithBothFilter() + { + $u = new User($this->container); + $n = new UserNotificationFilter($this->container); + $p = new Project($this->container); + + $this->assertEquals(2, $u->create(array('username' => 'user2', 'notifications_filter' => UserNotificationFilter::FILTER_BOTH))); + + $this->assertTrue($n->shouldReceiveNotification($u->getById(2), array('task' => array('project_id' => 1, 'creator_id' => 2, 'owner_id' => 3)))); + $this->assertTrue($n->shouldReceiveNotification($u->getById(2), array('task' => array('project_id' => 1, 'creator_id' => 0, 'owner_id' => 2)))); + $this->assertFalse($n->shouldReceiveNotification($u->getById(2), array('task' => array('project_id' => 1, 'creator_id' => 4, 'owner_id' => 1)))); + $this->assertFalse($n->shouldReceiveNotification($u->getById(2), array('task' => array('project_id' => 1, 'creator_id' => 5, 'owner_id' => 0)))); + } + + public function testFilterUserWithBothFilterAndProjectSelected() + { + $u = new User($this->container); + $n = new UserNotification($this->container); + $nf = new UserNotificationFilter($this->container); + $p = new Project($this->container); + + $this->assertEquals(1, $p->create(array('name' => 'UnitTest1'))); + $this->assertEquals(2, $p->create(array('name' => 'UnitTest2'))); + + $this->assertEquals(2, $u->create(array('username' => 'user2', 'notifications_filter' => UserNotificationFilter::FILTER_BOTH))); + + $n->saveSettings(2, array('notifications_enabled' => 1, 'notification_projects' => array(2 => true))); + + $this->assertFalse($nf->shouldReceiveNotification($u->getById(2), array('task' => array('project_id' => 1, 'creator_id' => 2, 'owner_id' => 3)))); + $this->assertFalse($nf->shouldReceiveNotification($u->getById(2), array('task' => array('project_id' => 1, 'creator_id' => 0, 'owner_id' => 2)))); + + $this->assertTrue($nf->shouldReceiveNotification($u->getById(2), array('task' => array('project_id' => 2, 'creator_id' => 2, 'owner_id' => 3)))); + $this->assertTrue($nf->shouldReceiveNotification($u->getById(2), array('task' => array('project_id' => 2, 'creator_id' => 0, 'owner_id' => 2)))); + } +} diff --git a/tests/units/Model/UserNotificationTest.php b/tests/units/Model/UserNotificationTest.php new file mode 100644 index 00000000..8d7dec60 --- /dev/null +++ b/tests/units/Model/UserNotificationTest.php @@ -0,0 +1,198 @@ +container); + $p = new Project($this->container); + $n = new UserNotification($this->container); + $pp = new ProjectPermission($this->container); + + $this->assertEquals(1, $p->create(array('name' => 'UnitTest1'))); + $this->assertEquals(2, $u->create(array('username' => 'user1'))); + $this->assertTrue($pp->addMember(1, 2)); + + $this->assertEmpty($n->getUsersWithNotificationEnabled(1)); + $n->enableNotification(2); + $this->assertNotEmpty($n->getUsersWithNotificationEnabled(1)); + $n->disableNotification(2); + $this->assertEmpty($n->getUsersWithNotificationEnabled(1)); + } + + public function testReadWriteSettings() + { + $n = new UserNotification($this->container); + $p = new Project($this->container); + + $this->assertEquals(1, $p->create(array('name' => 'UnitTest1'))); + + $n->saveSettings(1, array( + 'notifications_enabled' => 1, + 'notifications_filter' => UserNotificationFilter::FILTER_CREATOR, + 'notification_types' => array('email' => 1), + 'notification_projects' => array(), + )); + + $settings = $n->readSettings(1); + $this->assertNotEmpty($settings); + $this->assertEquals(1, $settings['notifications_enabled']); + $this->assertEquals(UserNotificationFilter::FILTER_CREATOR, $settings['notifications_filter']); + $this->assertEquals(array('email'), $settings['notification_types']); + $this->assertEmpty($settings['notification_projects']); + + $n->saveSettings(1, array( + 'notifications_enabled' => 0, + )); + + $settings = $n->readSettings(1); + $this->assertNotEmpty($settings); + $this->assertEquals(0, $settings['notifications_enabled']); + + $n->saveSettings(1, array( + 'notifications_enabled' => 1, + 'notifications_filter' => UserNotificationFilter::FILTER_ASSIGNEE, + 'notification_types' => array('web' => 1, 'email' => 1), + 'notification_projects' => array(1 => 1), + )); + + $settings = $n->readSettings(1); + $this->assertNotEmpty($settings); + $this->assertEquals(1, $settings['notifications_enabled']); + $this->assertEquals(UserNotificationFilter::FILTER_ASSIGNEE, $settings['notifications_filter']); + $this->assertEquals(array('email', 'web'), $settings['notification_types']); + $this->assertEquals(array(1), $settings['notification_projects']); + } + + public function testGetProjectMembersWithNotifications() + { + $u = new User($this->container); + $p = new Project($this->container); + $n = new UserNotification($this->container); + $pp = new ProjectPermission($this->container); + + $this->assertEquals(1, $p->create(array('name' => 'UnitTest1'))); + + // Email + Notifications enabled + $this->assertNotFalse($u->create(array('username' => 'user1', 'email' => 'user1@here', 'notifications_enabled' => 1))); + + // No email + Notifications enabled + $this->assertNotFalse($u->create(array('username' => 'user2', 'email' => '', 'notifications_enabled' => 1))); + + // Email + Notifications enabled + $this->assertNotFalse($u->create(array('username' => 'user3', 'email' => 'user3@here', 'notifications_enabled' => 1))); + + // No email + notifications disabled + $this->assertNotFalse($u->create(array('username' => 'user4'))); + + // Nobody is member of any projects + $this->assertEmpty($pp->getMembers(1)); + $this->assertEmpty($n->getUsersWithNotificationEnabled(1)); + + // We allow all users to be member of our projects + $this->assertTrue($pp->addMember(1, 1)); + $this->assertTrue($pp->addMember(1, 2)); + $this->assertTrue($pp->addMember(1, 3)); + $this->assertTrue($pp->addMember(1, 4)); + + $this->assertNotEmpty($pp->getMembers(1)); + $users = $n->getUsersWithNotificationEnabled(1); + + $this->assertNotEmpty($users); + $this->assertCount(3, $users); + $this->assertEquals('user1@here', $users[0]['email']); + $this->assertEquals('', $users[1]['email']); + $this->assertEquals('user3@here', $users[2]['email']); + } + + public function testGetUsersWithNotificationsWhenEverybodyAllowed() + { + $u = new User($this->container); + $p = new Project($this->container); + $n = new UserNotification($this->container); + $pp = new ProjectPermission($this->container); + + $this->assertEquals(1, $p->create(array('name' => 'UnitTest1', 'is_everybody_allowed' => 1))); + $this->assertTrue($pp->isEverybodyAllowed(1)); + + // Email + Notifications enabled + $this->assertNotFalse($u->create(array('username' => 'user1', 'email' => 'user1@here', 'notifications_enabled' => 1))); + + // No email + Notifications enabled + $this->assertNotFalse($u->create(array('username' => 'user2', 'email' => '', 'notifications_enabled' => 1))); + + // Email + Notifications enabled + $this->assertNotFalse($u->create(array('username' => 'user3', 'email' => 'user3@here', 'notifications_enabled' => 1))); + + // No email + notifications disabled + $this->assertNotFalse($u->create(array('username' => 'user4'))); + + $users = $n->getUsersWithNotificationEnabled(1); + + $this->assertNotEmpty($users); + $this->assertCount(3, $users); + $this->assertEquals('user1@here', $users[0]['email']); + $this->assertEquals('', $users[1]['email']); + $this->assertEquals('user3@here', $users[2]['email']); + } + + public function testSendNotifications() + { + $u = new User($this->container); + $n = new UserNotification($this->container); + $p = new Project($this->container); + $tc = new TaskCreation($this->container); + $tf = new TaskFinder($this->container); + $pp = new ProjectPermission($this->container); + + $this->assertEquals(1, $p->create(array('name' => 'UnitTest1', 'is_everybody_allowed' => 1))); + $this->assertEquals(1, $tc->create(array('title' => 'test', 'project_id' => 1))); + $this->assertTrue($u->update(array('id' => 1, 'email' => 'test@localhost'))); + $this->assertTrue($pp->isEverybodyAllowed(1)); + + $n->saveSettings(1, array( + 'notifications_enabled' => 1, + 'notifications_filter' => UserNotificationFilter::FILTER_NONE, + 'notification_types' => array('web' => 1, 'email' => 1), + )); + + $notifier = $this + ->getMockBuilder('Stdclass') + ->setMethods(array('notifyUser')) + ->getMock(); + + $notifier + ->expects($this->exactly(2)) + ->method('notifyUser'); + + $this->container['userNotificationType'] + ->expects($this->at(0)) + ->method('getType') + ->with($this->equalTo('email')) + ->will($this->returnValue($notifier)); + + $this->container['userNotificationType'] + ->expects($this->at(1)) + ->method('getType') + ->with($this->equalTo('web')) + ->will($this->returnValue($notifier)); + + $n->sendNotifications(Task::EVENT_CREATE, array('task' => $tf->getDetails(1))); + } +} diff --git a/tests/units/Model/UserNotificationTypeTest.php b/tests/units/Model/UserNotificationTypeTest.php new file mode 100644 index 00000000..a0a1491d --- /dev/null +++ b/tests/units/Model/UserNotificationTypeTest.php @@ -0,0 +1,30 @@ +container); + $this->assertEmpty($nt->getTypes()); + + $nt->setType('email', 'Email', 'Something'); + $nt->setType('web', 'Web', 'Something'); + $this->assertEquals(array('email' => 'Email', 'web' => 'Web'), $nt->getTypes()); + } + + public function testGetUserNotificationTypes() + { + $nt = new UserNotificationType($this->container); + $types = $nt->getSelectedTypes(1); + $this->assertEmpty($types); + + $this->assertTrue($nt->saveSelectedTypes(1, array('email', 'web'))); + $types = $nt->getSelectedTypes(1); + $this->assertNotEmpty($types); + $this->assertEquals(array('email', 'web'), $types); + } +} diff --git a/tests/units/Model/UserUnreadNotificationTest.php b/tests/units/Model/UserUnreadNotificationTest.php new file mode 100644 index 00000000..130a6eba --- /dev/null +++ b/tests/units/Model/UserUnreadNotificationTest.php @@ -0,0 +1,141 @@ +container); + $p = new Project($this->container); + $tf = new TaskFinder($this->container); + $tc = new TaskCreation($this->container); + $s = new Subtask($this->container); + $c = new Comment($this->container); + $f = new File($this->container); + + $this->assertEquals(1, $p->create(array('name' => 'test'))); + $this->assertEquals(1, $tc->create(array('title' => 'test', 'project_id' => 1))); + $this->assertEquals(1, $s->create(array('title' => 'test', 'task_id' => 1))); + $this->assertEquals(1, $c->create(array('comment' => 'test', 'task_id' => 1, 'user_id' => 1))); + $this->assertEquals(1, $f->create(1, 'test', 'blah', 123)); + + $task = $tf->getDetails(1); + $subtask = $s->getById(1, true); + $comment = $c->getById(1); + $file = $c->getById(1); + + $this->assertNotEmpty($task); + $this->assertNotEmpty($subtask); + $this->assertNotEmpty($comment); + $this->assertNotEmpty($file); + + foreach (NotificationSubscriber::getSubscribedEvents() as $event_name => $values) { + $title = $wn->getTitleFromEvent($event_name, array( + 'task' => $task, + 'comment' => $comment, + 'subtask' => $subtask, + 'file' => $file, + 'changes' => array() + )); + + $this->assertNotEmpty($title); + } + + $this->assertNotEmpty($wn->getTitleFromEvent(Task::EVENT_OVERDUE, array('tasks' => array(array('id' => 1))))); + $this->assertNotEmpty($wn->getTitleFromEvent('unkown', array())); + } + + public function testHasNotification() + { + $wn = new UserUnreadNotification($this->container); + $p = new Project($this->container); + $tf = new TaskFinder($this->container); + $tc = new TaskCreation($this->container); + $u = new User($this->container); + + $this->assertEquals(1, $p->create(array('name' => 'test'))); + $this->assertEquals(1, $tc->create(array('title' => 'test', 'project_id' => 1))); + + $this->assertFalse($wn->hasNotifications(1)); + + $wn->create(1, Task::EVENT_CREATE, array('task' => $tf->getDetails(1))); + + $this->assertTrue($wn->hasNotifications(1)); + } + + public function testMarkAllAsRead() + { + $wn = new UserUnreadNotification($this->container); + $p = new Project($this->container); + $tf = new TaskFinder($this->container); + $tc = new TaskCreation($this->container); + $u = new User($this->container); + + $this->assertEquals(1, $p->create(array('name' => 'test'))); + $this->assertEquals(1, $tc->create(array('title' => 'test', 'project_id' => 1))); + + $wn->create(1, Task::EVENT_CREATE, array('task' => $tf->getDetails(1))); + + $this->assertTrue($wn->hasNotifications(1)); + $this->assertTrue($wn->markAllAsRead(1)); + + $this->assertFalse($wn->hasNotifications(1)); + $this->assertFalse($wn->markAllAsRead(1)); + } + + public function testMarkAsRead() + { + $wn = new UserUnreadNotification($this->container); + $p = new Project($this->container); + $tf = new TaskFinder($this->container); + $tc = new TaskCreation($this->container); + $u = new User($this->container); + + $this->assertEquals(1, $p->create(array('name' => 'test'))); + $this->assertEquals(1, $tc->create(array('title' => 'test', 'project_id' => 1))); + + $wn->create(1, Task::EVENT_CREATE, array('task' => $tf->getDetails(1))); + + $this->assertTrue($wn->hasNotifications(1)); + + $this->assertFalse($wn->markAsRead(2, 1)); + $this->assertTrue($wn->markAsRead(1, 1)); + + $this->assertFalse($wn->hasNotifications(1)); + $this->assertFalse($wn->markAsRead(1, 1)); + } + + public function testGetAll() + { + $wn = new UserUnreadNotification($this->container); + $p = new Project($this->container); + $tf = new TaskFinder($this->container); + $tc = new TaskCreation($this->container); + $u = new User($this->container); + + $this->assertEquals(1, $p->create(array('name' => 'test'))); + $this->assertEquals(1, $tc->create(array('title' => 'test', 'project_id' => 1))); + + $wn->create(1, Task::EVENT_CREATE, array('task' => $tf->getDetails(1))); + $wn->create(1, Task::EVENT_CREATE, array('task' => $tf->getDetails(1))); + + $this->assertEmpty($wn->getAll(2)); + + $notifications = $wn->getAll(1); + $this->assertCount(2, $notifications); + $this->assertArrayHasKey('title', $notifications[0]); + $this->assertTrue(is_array($notifications[0]['event_data'])); + } +} diff --git a/tests/units/Model/WebNotificationTest.php b/tests/units/Model/WebNotificationTest.php deleted file mode 100644 index 8ed37692..00000000 --- a/tests/units/Model/WebNotificationTest.php +++ /dev/null @@ -1,141 +0,0 @@ -container); - $p = new Project($this->container); - $tf = new TaskFinder($this->container); - $tc = new TaskCreation($this->container); - $s = new Subtask($this->container); - $c = new Comment($this->container); - $f = new File($this->container); - - $this->assertEquals(1, $p->create(array('name' => 'test'))); - $this->assertEquals(1, $tc->create(array('title' => 'test', 'project_id' => 1))); - $this->assertEquals(1, $s->create(array('title' => 'test', 'task_id' => 1))); - $this->assertEquals(1, $c->create(array('comment' => 'test', 'task_id' => 1, 'user_id' => 1))); - $this->assertEquals(1, $f->create(1, 'test', 'blah', 123)); - - $task = $tf->getDetails(1); - $subtask = $s->getById(1, true); - $comment = $c->getById(1); - $file = $c->getById(1); - - $this->assertNotEmpty($task); - $this->assertNotEmpty($subtask); - $this->assertNotEmpty($comment); - $this->assertNotEmpty($file); - - foreach (NotificationSubscriber::getSubscribedEvents() as $event_name => $values) { - $title = $wn->getTitleFromEvent($event_name, array( - 'task' => $task, - 'comment' => $comment, - 'subtask' => $subtask, - 'file' => $file, - 'changes' => array() - )); - - $this->assertNotEmpty($title); - } - - $this->assertNotEmpty($wn->getTitleFromEvent(Task::EVENT_OVERDUE, array('tasks' => array(array('id' => 1))))); - $this->assertNotEmpty($wn->getTitleFromEvent('unkown', array())); - } - - public function testHasNotification() - { - $wn = new WebNotification($this->container); - $p = new Project($this->container); - $tf = new TaskFinder($this->container); - $tc = new TaskCreation($this->container); - $u = new User($this->container); - - $this->assertEquals(1, $p->create(array('name' => 'test'))); - $this->assertEquals(1, $tc->create(array('title' => 'test', 'project_id' => 1))); - - $this->assertFalse($wn->hasNotifications(1)); - - $wn->send($u->getById(1), Task::EVENT_CREATE, array('task' => $tf->getDetails(1))); - - $this->assertTrue($wn->hasNotifications(1)); - } - - public function testMarkAllAsRead() - { - $wn = new WebNotification($this->container); - $p = new Project($this->container); - $tf = new TaskFinder($this->container); - $tc = new TaskCreation($this->container); - $u = new User($this->container); - - $this->assertEquals(1, $p->create(array('name' => 'test'))); - $this->assertEquals(1, $tc->create(array('title' => 'test', 'project_id' => 1))); - - $wn->send($u->getById(1), Task::EVENT_CREATE, array('task' => $tf->getDetails(1))); - - $this->assertTrue($wn->hasNotifications(1)); - $this->assertTrue($wn->markAllAsRead(1)); - - $this->assertFalse($wn->hasNotifications(1)); - $this->assertFalse($wn->markAllAsRead(1)); - } - - public function testMarkAsRead() - { - $wn = new WebNotification($this->container); - $p = new Project($this->container); - $tf = new TaskFinder($this->container); - $tc = new TaskCreation($this->container); - $u = new User($this->container); - - $this->assertEquals(1, $p->create(array('name' => 'test'))); - $this->assertEquals(1, $tc->create(array('title' => 'test', 'project_id' => 1))); - - $wn->send($u->getById(1), Task::EVENT_CREATE, array('task' => $tf->getDetails(1))); - - $this->assertTrue($wn->hasNotifications(1)); - - $this->assertFalse($wn->markAsRead(2, 1)); - $this->assertTrue($wn->markAsRead(1, 1)); - - $this->assertFalse($wn->hasNotifications(1)); - $this->assertFalse($wn->markAsRead(1, 1)); - } - - public function testGetAll() - { - $wn = new WebNotification($this->container); - $p = new Project($this->container); - $tf = new TaskFinder($this->container); - $tc = new TaskCreation($this->container); - $u = new User($this->container); - - $this->assertEquals(1, $p->create(array('name' => 'test'))); - $this->assertEquals(1, $tc->create(array('title' => 'test', 'project_id' => 1))); - - $wn->send($u->getById(1), Task::EVENT_CREATE, array('task' => $tf->getDetails(1))); - $wn->send($u->getById(1), Task::EVENT_CREATE, array('task' => $tf->getDetails(1))); - - $this->assertEmpty($wn->getAll(2)); - - $notifications = $wn->getAll(1); - $this->assertCount(2, $notifications); - $this->assertArrayHasKey('title', $notifications[0]); - $this->assertTrue(is_array($notifications[0]['event_data'])); - } -} diff --git a/tests/units/Notification/MailTest.php b/tests/units/Notification/MailTest.php new file mode 100644 index 00000000..3aa1a39c --- /dev/null +++ b/tests/units/Notification/MailTest.php @@ -0,0 +1,118 @@ +container); + $p = new Project($this->container); + $tf = new TaskFinder($this->container); + $tc = new TaskCreation($this->container); + $s = new Subtask($this->container); + $c = new Comment($this->container); + $f = new File($this->container); + + $this->assertEquals(1, $p->create(array('name' => 'test'))); + $this->assertEquals(1, $tc->create(array('title' => 'test', 'project_id' => 1))); + $this->assertEquals(1, $s->create(array('title' => 'test', 'task_id' => 1))); + $this->assertEquals(1, $c->create(array('comment' => 'test', 'task_id' => 1, 'user_id' => 1))); + $this->assertEquals(1, $f->create(1, 'test', 'blah', 123)); + + $task = $tf->getDetails(1); + $subtask = $s->getById(1, true); + $comment = $c->getById(1); + $file = $c->getById(1); + + $this->assertNotEmpty($task); + $this->assertNotEmpty($subtask); + $this->assertNotEmpty($comment); + $this->assertNotEmpty($file); + + foreach (NotificationSubscriber::getSubscribedEvents() as $event => $values) { + $this->assertNotEmpty($en->getMailContent($event, array( + 'task' => $task, + 'comment' => $comment, + 'subtask' => $subtask, + 'file' => $file, + 'changes' => array()) + )); + + $this->assertNotEmpty($en->getMailSubject($event, array( + 'task' => $task, + 'comment' => $comment, + 'subtask' => $subtask, + 'file' => $file, + 'changes' => array()) + )); + } + } + + public function testSendWithEmailAddress() + { + $en = new Mail($this->container); + $p = new Project($this->container); + $tf = new TaskFinder($this->container); + $tc = new TaskCreation($this->container); + $u = new User($this->container); + + $this->assertEquals(1, $p->create(array('name' => 'test'))); + $this->assertEquals(1, $tc->create(array('title' => 'test', 'project_id' => 1))); + $this->assertTrue($u->update(array('id' => 1, 'email' => 'test@localhost'))); + + $this->container['emailClient'] = $this + ->getMockBuilder('\Kanboard\Core\Mail\Client') + ->setConstructorArgs(array($this->container)) + ->setMethods(array('send')) + ->getMock(); + + $this->container['emailClient'] + ->expects($this->once()) + ->method('send') + ->with( + $this->equalTo('test@localhost'), + $this->equalTo('admin'), + $this->equalTo('[test][New task] test (#1)'), + $this->stringContains('test') + ); + + $en->notifyUser($u->getById(1), Task::EVENT_CREATE, array('task' => $tf->getDetails(1))); + } + + public function testSendWithoutEmailAddress() + { + $en = new Mail($this->container); + $p = new Project($this->container); + $tf = new TaskFinder($this->container); + $tc = new TaskCreation($this->container); + $u = new User($this->container); + + $this->assertEquals(1, $p->create(array('name' => 'test'))); + $this->assertEquals(1, $tc->create(array('title' => 'test', 'project_id' => 1))); + + $this->container['emailClient'] = $this + ->getMockBuilder('\Kanboard\Core\Mail\Client') + ->setConstructorArgs(array($this->container)) + ->setMethods(array('send')) + ->getMock(); + + $this->container['emailClient'] + ->expects($this->never()) + ->method('send'); + + $en->notifyUser($u->getById(1), Task::EVENT_CREATE, array('task' => $tf->getDetails(1))); + } +} -- cgit v1.2.3