From 637d5678be83c5fae1b21848d53e4d90bd5c0b0d Mon Sep 17 00:00:00 2001 From: knut <> Date: Wed, 6 Aug 2008 01:03:05 +0000 Subject: fixed #834 --- framework/Data/Common/TDbCommandBuilder.php | 20 +++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-) (limited to 'framework/Data/Common') diff --git a/framework/Data/Common/TDbCommandBuilder.php b/framework/Data/Common/TDbCommandBuilder.php index fee48082..c4bfeb98 100644 --- a/framework/Data/Common/TDbCommandBuilder.php +++ b/framework/Data/Common/TDbCommandBuilder.php @@ -1,10 +1,10 @@ - * @link http://www.pradosoft.com/ - * @copyright Copyright © 2005-2008 PradoSoft + * @copyright Copyright © 2005-2008 PradoSoft * @license http://www.pradosoft.com/license/ * @version $Id$ * @package System.Data.Common @@ -105,11 +105,17 @@ class TDbCommandBuilder extends TComponent public function applyOrdering($sql, $ordering) { $orders=array(); - foreach($ordering as $name=>$direction) + foreach($ordering as $name => $direction) { $direction = strtolower($direction) == 'desc' ? 'DESC' : 'ASC'; - $column = $this->getTableInfo()->getColumn($name)->getColumnName(); - $orders[] = $column.' '.$direction; + if(strpos($name, '(') && strpos($name, ')')) { + // key is a function (bad practice, but we need to handle it) + $key = $name; + } else { + // key is a column + $key = $this->getTableInfo()->getColumn($name)->getColumnName(); + } + $orders[] = $key.' '.$direction; } if(count($orders) > 0) $sql .= ' ORDER BY '.implode(', ', $orders); @@ -361,5 +367,5 @@ class TDbCommandBuilder extends TComponent return false; } } - -?> + +?> -- cgit v1.2.3