From 4b8a9a5189a625bf99fedec7fd31f6e146410a14 Mon Sep 17 00:00:00 2001 From: emkael Date: Thu, 26 Apr 2018 01:00:12 +0200 Subject: Update FB API library --- .../tests/HttpClients/AbstractTestHttpClient.php | 2 +- .../HttpClients/FacebookCurlHttpClientTest.php | 61 ++---------------- .../HttpClients/FacebookGuzzleHttpClientTest.php | 4 +- .../HttpClients/FacebookStreamHttpClientTest.php | 4 +- .../tests/HttpClients/HttpClientsFactoryTest.php | 72 ++++++++++++++++++++++ 5 files changed, 82 insertions(+), 61 deletions(-) create mode 100644 lib/facebook-graph-sdk/tests/HttpClients/HttpClientsFactoryTest.php (limited to 'lib/facebook-graph-sdk/tests/HttpClients') diff --git a/lib/facebook-graph-sdk/tests/HttpClients/AbstractTestHttpClient.php b/lib/facebook-graph-sdk/tests/HttpClients/AbstractTestHttpClient.php index 269b235..a870052 100644 --- a/lib/facebook-graph-sdk/tests/HttpClients/AbstractTestHttpClient.php +++ b/lib/facebook-graph-sdk/tests/HttpClients/AbstractTestHttpClient.php @@ -1,6 +1,6 @@ markTestSkipped('cURL must be installed to test cURL client handler.'); + } $this->curlMock = m::mock('Facebook\HttpClients\FacebookCurl'); $this->curlClient = new FacebookCurlHttpClient($this->curlMock); } @@ -146,15 +149,6 @@ class FacebookCurlHttpClientTest extends AbstractTestHttpClient public function testIsolatesTheHeaderAndBody() { - $this->curlMock - ->shouldReceive('getinfo') - ->with(CURLINFO_HEADER_SIZE) - ->once() - ->andReturn(strlen($this->fakeRawHeader)); - $this->curlMock - ->shouldReceive('version') - ->once() - ->andReturn(['version_number' => self::CURL_VERSION_STABLE]); $this->curlMock ->shouldReceive('exec') ->once() @@ -170,15 +164,6 @@ class FacebookCurlHttpClientTest extends AbstractTestHttpClient public function testProperlyHandlesProxyHeaders() { $rawHeader = $this->fakeRawProxyHeader . $this->fakeRawHeader; - $this->curlMock - ->shouldReceive('getinfo') - ->with(CURLINFO_HEADER_SIZE) - ->once() - ->andReturn(mb_strlen($rawHeader)); - $this->curlMock - ->shouldReceive('version') - ->once() - ->andReturn(['version_number' => self::CURL_VERSION_STABLE]); $this->curlMock ->shouldReceive('exec') ->once() @@ -194,15 +179,6 @@ class FacebookCurlHttpClientTest extends AbstractTestHttpClient public function testProperlyHandlesProxyHeadersWithCurlBug() { $rawHeader = $this->fakeRawProxyHeader . $this->fakeRawHeader; - $this->curlMock - ->shouldReceive('getinfo') - ->with(CURLINFO_HEADER_SIZE) - ->once() - ->andReturn(mb_strlen($this->fakeRawHeader)); // Mimic bug that doesn't count proxy header - $this->curlMock - ->shouldReceive('version') - ->once() - ->andReturn(['version_number' => self::CURL_VERSION_BUGGY]); $this->curlMock ->shouldReceive('exec') ->once() @@ -218,15 +194,6 @@ class FacebookCurlHttpClientTest extends AbstractTestHttpClient public function testProperlyHandlesProxyHeadersWithCurlBug2() { $rawHeader = $this->fakeRawProxyHeader2 . $this->fakeRawHeader; - $this->curlMock - ->shouldReceive('getinfo') - ->with(CURLINFO_HEADER_SIZE) - ->once() - ->andReturn(mb_strlen($this->fakeRawHeader)); // Mimic bug that doesn't count proxy header - $this->curlMock - ->shouldReceive('version') - ->once() - ->andReturn(['version_number' => self::CURL_VERSION_BUGGY]); $this->curlMock ->shouldReceive('exec') ->once() @@ -242,15 +209,6 @@ class FacebookCurlHttpClientTest extends AbstractTestHttpClient public function testProperlyHandlesRedirectHeaders() { $rawHeader = $this->fakeRawRedirectHeader . $this->fakeRawHeader; - $this->curlMock - ->shouldReceive('getinfo') - ->with(CURLINFO_HEADER_SIZE) - ->once() - ->andReturn(mb_strlen($rawHeader)); - $this->curlMock - ->shouldReceive('version') - ->once() - ->andReturn(['version_number' => self::CURL_VERSION_STABLE]); $this->curlMock ->shouldReceive('exec') ->once() @@ -281,15 +239,6 @@ class FacebookCurlHttpClientTest extends AbstractTestHttpClient ->shouldReceive('errno') ->once() ->andReturn(null); - $this->curlMock - ->shouldReceive('getinfo') - ->with(CURLINFO_HEADER_SIZE) - ->once() - ->andReturn(mb_strlen($this->fakeRawHeader)); - $this->curlMock - ->shouldReceive('version') - ->once() - ->andReturn(['version_number' => self::CURL_VERSION_STABLE]); $this->curlMock ->shouldReceive('close') ->once() diff --git a/lib/facebook-graph-sdk/tests/HttpClients/FacebookGuzzleHttpClientTest.php b/lib/facebook-graph-sdk/tests/HttpClients/FacebookGuzzleHttpClientTest.php index 12eb36a..f14ad96 100644 --- a/lib/facebook-graph-sdk/tests/HttpClients/FacebookGuzzleHttpClientTest.php +++ b/lib/facebook-graph-sdk/tests/HttpClients/FacebookGuzzleHttpClientTest.php @@ -1,6 +1,6 @@ guzzleMock = m::mock('GuzzleHttp\Client'); $this->guzzleClient = new FacebookGuzzleHttpClient($this->guzzleMock); diff --git a/lib/facebook-graph-sdk/tests/HttpClients/FacebookStreamHttpClientTest.php b/lib/facebook-graph-sdk/tests/HttpClients/FacebookStreamHttpClientTest.php index 9102b08..3749960 100644 --- a/lib/facebook-graph-sdk/tests/HttpClients/FacebookStreamHttpClientTest.php +++ b/lib/facebook-graph-sdk/tests/HttpClients/FacebookStreamHttpClientTest.php @@ -1,6 +1,6 @@ streamMock = m::mock('Facebook\HttpClients\FacebookStream'); $this->streamClient = new FacebookStreamHttpClient($this->streamMock); diff --git a/lib/facebook-graph-sdk/tests/HttpClients/HttpClientsFactoryTest.php b/lib/facebook-graph-sdk/tests/HttpClients/HttpClientsFactoryTest.php new file mode 100644 index 0000000..4d49489 --- /dev/null +++ b/lib/facebook-graph-sdk/tests/HttpClients/HttpClientsFactoryTest.php @@ -0,0 +1,72 @@ +assertInstanceOf(self::COMMON_INTERFACE, $httpClient); + $this->assertInstanceOf($expected, $httpClient); + } + + /** + * @return array + */ + public function httpClientsProvider() + { + $clients = [ + ['guzzle', self::COMMON_NAMESPACE . 'FacebookGuzzleHttpClient'], + ['stream', self::COMMON_NAMESPACE . 'FacebookStreamHttpClient'], + [new Client(), self::COMMON_NAMESPACE . 'FacebookGuzzleHttpClient'], + [new FacebookGuzzleHttpClient(), self::COMMON_NAMESPACE . 'FacebookGuzzleHttpClient'], + [new FacebookStreamHttpClient(), self::COMMON_NAMESPACE . 'FacebookStreamHttpClient'], + [null, self::COMMON_INTERFACE], + ]; + if (extension_loaded('curl')) { + $clients[] = ['curl', self::COMMON_NAMESPACE . 'FacebookCurlHttpClient']; + $clients[] = [new FacebookCurlHttpClient(), self::COMMON_NAMESPACE . 'FacebookCurlHttpClient']; + } + + return $clients; + } +} -- cgit v1.2.3