summaryrefslogtreecommitdiff
path: root/app/Controller
diff options
context:
space:
mode:
Diffstat (limited to 'app/Controller')
-rw-r--r--app/Controller/Base.php2
-rw-r--r--app/Controller/Subtask.php2
-rw-r--r--app/Controller/Swimlane.php2
-rw-r--r--app/Controller/Task.php27
4 files changed, 13 insertions, 20 deletions
diff --git a/app/Controller/Base.php b/app/Controller/Base.php
index 4719ebe4..b5d59640 100644
--- a/app/Controller/Base.php
+++ b/app/Controller/Base.php
@@ -169,7 +169,7 @@ abstract class Base
*/
public function handleAuthenticatedUser($controller, $action)
{
- if (! $this->authentication->isAuthenticated($controller, $action)) {
+ if (! $this->authentication->isAuthenticated()) {
if ($this->request->isAjax()) {
$this->response->text('Not Authorized', 401);
diff --git a/app/Controller/Subtask.php b/app/Controller/Subtask.php
index 59e9fe5c..0521b893 100644
--- a/app/Controller/Subtask.php
+++ b/app/Controller/Subtask.php
@@ -110,7 +110,7 @@ class Subtask extends Base
public function update()
{
$task = $this->getTask();
- $subtask = $this->getSubtask();
+ $this->getSubtask();
$values = $this->request->getValues();
list($valid, $errors) = $this->subTask->validateModification($values);
diff --git a/app/Controller/Swimlane.php b/app/Controller/Swimlane.php
index 10b29569..de2f1f12 100644
--- a/app/Controller/Swimlane.php
+++ b/app/Controller/Swimlane.php
@@ -87,7 +87,7 @@ class Swimlane extends Base
$project = $this->getProject();
$values = $this->request->getValues();
- list($valid, $errors) = $this->swimlane->validateDefaultModification($values);
+ list($valid,) = $this->swimlane->validateDefaultModification($values);
if ($valid) {
diff --git a/app/Controller/Task.php b/app/Controller/Task.php
index 773183fe..7f85f36c 100644
--- a/app/Controller/Task.php
+++ b/app/Controller/Task.php
@@ -141,7 +141,7 @@ class Task extends Base
$this->response->redirect('?controller=task&action=create&'.http_build_query($values));
}
else {
- $this->response->redirect('?controller=board&action=show&project_id='.$values['project_id']);
+ $this->response->redirect('?controller=board&action=show&project_id='.$project['id']);
}
}
else {
@@ -157,16 +157,20 @@ class Task extends Base
*
* @access public
*/
- public function edit()
+ public function edit(array $values = array(), array $errors = array())
{
$task = $this->getTask();
$ajax = $this->request->isAjax();
- $this->dateParser->format($task, array('date_due'));
+ if (empty($values)) {
+ $values = $task;
+ }
+
+ $this->dateParser->format($values, array('date_due'));
$params = array(
- 'values' => $task,
- 'errors' => array(),
+ 'values' => $values,
+ 'errors' => $errors,
'task' => $task,
'users_list' => $this->projectPermission->getMemberList($task['project_id']),
'colors_list' => $this->color->getList(),
@@ -213,18 +217,7 @@ class Task extends Base
}
}
- $this->response->html($this->taskLayout('task/edit', array(
- 'values' => $values,
- 'errors' => $errors,
- 'task' => $task,
- 'columns_list' => $this->board->getColumnsList($values['project_id']),
- 'users_list' => $this->projectPermission->getMemberList($values['project_id']),
- 'colors_list' => $this->color->getList(),
- 'categories_list' => $this->category->getList($values['project_id']),
- 'date_format' => $this->config->get('application_date_format'),
- 'date_formats' => $this->dateParser->getAvailableFormats(),
- 'ajax' => $this->request->isAjax(),
- )));
+ $this->edit($values, $errors);
}
/**