diff options
author | Fabio Bas <ctrlaltca@gmail.com> | 2016-02-29 22:14:08 +0100 |
---|---|---|
committer | Fabio Bas <ctrlaltca@gmail.com> | 2016-03-29 17:40:11 +0200 |
commit | dc76cfdcf0521552667d44395a2290a5c8e48281 (patch) | |
tree | f7f0eea869f1abd47b7a9aa5b3314c617df3dd57 /tests | |
parent | 0ec0d073c120a2db371dfd4cd6f2a81fd9068676 (diff) |
Fixed 10 "critical" issues found by scrutinizer
* create function => closures
* removed var_dump from tests
Diffstat (limited to 'tests')
5 files changed, 1 insertions, 5 deletions
diff --git a/tests/FunctionalTests/active-controls/protected/pages/ActiveRadioButtonListTest.php b/tests/FunctionalTests/active-controls/protected/pages/ActiveRadioButtonListTest.php index 74113cc8..3657c2a6 100755 --- a/tests/FunctionalTests/active-controls/protected/pages/ActiveRadioButtonListTest.php +++ b/tests/FunctionalTests/active-controls/protected/pages/ActiveRadioButtonListTest.php @@ -5,7 +5,6 @@ class ActiveRadioButtonListTest extends TPage function list1_callback($sender, $param) { $values = $sender->getSelectedValues(); - var_dump($values); $this->label1->setText("Selection: ".implode(', ', $values)); } diff --git a/tests/FunctionalTests/active-controls/protected/pages/AutoCompleteTest.php b/tests/FunctionalTests/active-controls/protected/pages/AutoCompleteTest.php index 1a767b79..ba1b04b2 100755 --- a/tests/FunctionalTests/active-controls/protected/pages/AutoCompleteTest.php +++ b/tests/FunctionalTests/active-controls/protected/pages/AutoCompleteTest.php @@ -37,6 +37,5 @@ class AutoCompleteTest extends TPage function suggestion_selected($sender, $param) { - var_dump($param->selectedIndex); } } diff --git a/tests/FunctionalTests/active-controls/protected/pages/Callback.php b/tests/FunctionalTests/active-controls/protected/pages/Callback.php index 8a85f50d..85c93f10 100755 --- a/tests/FunctionalTests/active-controls/protected/pages/Callback.php +++ b/tests/FunctionalTests/active-controls/protected/pages/Callback.php @@ -6,6 +6,5 @@ class Callback extends TPage { function callback1_Requested() { - var_dump("ok!"); } } diff --git a/tests/FunctionalTests/tickets/protected/pages/Ticket719.php b/tests/FunctionalTests/tickets/protected/pages/Ticket719.php index 376eecdd..64f8acb2 100755 --- a/tests/FunctionalTests/tickets/protected/pages/Ticket719.php +++ b/tests/FunctionalTests/tickets/protected/pages/Ticket719.php @@ -24,8 +24,8 @@ class Ticket719 extends TPage function suggestion_selected($sender, $param) { - var_dump($param->selectedIndex); } + public function suggestCountries($sender, $param) { $sender->setDataSource($this->matchCountries($param->Token)); diff --git a/tests/unit/Data/ActiveRecord/ActiveRecordDynamicCallTest.php b/tests/unit/Data/ActiveRecord/ActiveRecordDynamicCallTest.php index 8c6b9789..a472e546 100644 --- a/tests/unit/Data/ActiveRecord/ActiveRecordDynamicCallTest.php +++ b/tests/unit/Data/ActiveRecord/ActiveRecordDynamicCallTest.php @@ -74,6 +74,5 @@ class ActiveRecordDynamicCallTest extends PHPUnit_Framework_TestCase function assertDeleteSql($sender, $param) { - var_dump($param); } } |