diff options
| author | Joey Hess <joeyh@joeyh.name> | 2016-03-13 17:28:05 -0400 |
|---|---|---|
| committer | Joey Hess <joeyh@joeyh.name> | 2016-03-13 17:28:05 -0400 |
| commit | 66517d59e474e6929ff962c911c7c0d58c258d79 (patch) | |
| tree | ee34a2e3700b692fbc8ef7a5e522f9f7deedfaed | |
| parent | ed82fdae2bbffb68983d538b0c5028e95299b0a2 (diff) | |
| parent | 53e4646b79b5b2e3ea7f878ff410121d0e94fd16 (diff) | |
Merge branch 'master' of ssh://etckeeper.branchable.com
| -rw-r--r-- | doc/todo/Yet_another_patch_for_the_Pacman_5_hooks.mdwn | 20 | ||||
| -rw-r--r-- | doc/todo/automatic_git_gc/comment_1_a0d10512edff8765066bac4bbc8a0561._comment | 8 |
2 files changed, 28 insertions, 0 deletions
diff --git a/doc/todo/Yet_another_patch_for_the_Pacman_5_hooks.mdwn b/doc/todo/Yet_another_patch_for_the_Pacman_5_hooks.mdwn new file mode 100644 index 0000000..b85e13a --- /dev/null +++ b/doc/todo/Yet_another_patch_for_the_Pacman_5_hooks.mdwn @@ -0,0 +1,20 @@ +It turns out that my last patch ([[Patch:_Make_Pacman_5_call_etckeeper_hooks_as_late_as_possible]]) +was not perfect after all. + +Calling both the pre-transaction and the post-transaction hook as late as possible seemed to make +sense at the time, but now that I think about it, I would say that only the post-transaction hook should be +called after all other hooks; the **pre-transaction** hook should be called as **early** as possible. + +That way, the pre-transaction hook can make sure that... + +- ...everything in `/etc` gets committed before any other hook gets the chance to introduce more changes + (therefore making any changes made by other hooks part of the post-transaction commit) *and*... +- ...it can abort the transaction and thus all hooks that come after the pre-transaction hook if `/etc` + is not clean and the user wants to prevent the package manager from running in that case. This prevents + any later hooks from making changes that should not be made in the first place (since the entire transaction + is being aborted due to a dirty `/etc`). + +My patch which makes Pacman call the pre-transaction hook as early as possible can be found here: +<https://github.com/Tblue/etckeeper/commit/6ff4f922cd34689e0d61359ebd822af5f82c40a6.patch> + +Hopefully, this will be the last patch related to the Pacman hooks for some time... Sorry for the noise. diff --git a/doc/todo/automatic_git_gc/comment_1_a0d10512edff8765066bac4bbc8a0561._comment b/doc/todo/automatic_git_gc/comment_1_a0d10512edff8765066bac4bbc8a0561._comment new file mode 100644 index 0000000..b0413df --- /dev/null +++ b/doc/todo/automatic_git_gc/comment_1_a0d10512edff8765066bac4bbc8a0561._comment @@ -0,0 +1,8 @@ +[[!comment format=mdwn + username="florian.kaiser@0f461a60da03d93431a5fdc965f53e6265e3f91e" + nickname="florian.kaiser" + subject="comment 1" + date="2016-03-08T13:32:03Z" + content=""" +Git does git gc automatically when needed. +"""]] |