blob: 0841dad7f6a35601e605db9a0617290e37352bb9 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
|
[[!comment format=mdwn
username="joey"
subject="""comment 1"""
date="2015-06-10T19:50:30Z"
content="""
Reviewing this patch, I noticed a bug in the first hunk. lsscripts
currently limits the files it finds to those matching a regexp. IIRC, this
is needed, amoung other things, to avoid .dpkg-old files being run.
Looking at the second hunk, I suspect that calling `id` twice per file is
going to be significantly slower than the perl implementation.
There also seems to be missing escaping of single quotes in filenames in
the second hunk.
"""]]
|
