summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFrederic Guillot <fred@kanboard.net>2017-06-18 22:16:55 -0400
committerFrederic Guillot <fred@kanboard.net>2017-06-18 22:16:55 -0400
commitec5ec2ea81972aa9804bc77221ad56712f6d2df9 (patch)
tree379567f9d2a70a5a0f6fbd8e302ee7976ba7d344
parente70f904ed4efca82dac5319d9f973b002280aac1 (diff)
Add missing subtask permissions for project viewer role
-rw-r--r--ChangeLog4
-rw-r--r--app/ServiceProvider/AuthenticationProvider.php1
-rw-r--r--app/Template/task/show.php4
3 files changed, 7 insertions, 2 deletions
diff --git a/ChangeLog b/ChangeLog
index 0d179458..9f38c881 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -9,6 +9,10 @@ New features:
* Add configurable list of predefined subjects when sending a task or a a comment by email
* Add command line argument to filter overdue notification for a given project
+Bug fixes:
+
+* Add missing subtask permissions for project viewer role
+
Version 1.0.44 (May 28, 2017)
-----------------------------
diff --git a/app/ServiceProvider/AuthenticationProvider.php b/app/ServiceProvider/AuthenticationProvider.php
index a384e822..fe07fc0c 100644
--- a/app/ServiceProvider/AuthenticationProvider.php
+++ b/app/ServiceProvider/AuthenticationProvider.php
@@ -97,6 +97,7 @@ class AuthenticationProvider implements ServiceProviderInterface
$acl->add('ProjectStatusController', '*', Role::PROJECT_MANAGER);
$acl->add('ProjectTagController', '*', Role::PROJECT_MANAGER);
$acl->add('SubtaskController', '*', Role::PROJECT_MEMBER);
+ $acl->add('SubtaskConverterController', '*', Role::PROJECT_MEMBER);
$acl->add('SubtaskRestrictionController', '*', Role::PROJECT_MEMBER);
$acl->add('SubtaskStatusController', '*', Role::PROJECT_MEMBER);
$acl->add('SwimlaneController', '*', Role::PROJECT_MANAGER);
diff --git a/app/Template/task/show.php b/app/Template/task/show.php
index 565f0632..892d62f2 100644
--- a/app/Template/task/show.php
+++ b/app/Template/task/show.php
@@ -18,7 +18,7 @@
'task' => $task,
'subtasks' => $subtasks,
'project' => $project,
- 'editable' => true,
+ 'editable' => $this->user->hasProjectAccess('SubtaskController', 'edit', $project['id']),
)) ?>
<?php endif ?>
@@ -29,7 +29,7 @@
'links' => $internal_links,
'project' => $project,
'link_label_list' => $link_label_list,
- 'editable' => true,
+ 'editable' => $this->user->hasProjectAccess('TaskInternalLinkController', 'edit', $project['id']),
'is_public' => false,
)) ?>
<?php endif ?>