summaryrefslogtreecommitdiff
path: root/app/Controller
diff options
context:
space:
mode:
authorFrédéric Guillot <fred@kanboard.net>2014-12-27 19:43:59 -0500
committerFrédéric Guillot <fred@kanboard.net>2014-12-27 19:43:59 -0500
commit0a14c8d5e5538e487dd6b012771f72aea6f4d5a6 (patch)
tree37518ee92a95fa9aa61eb46daa9a2b0b82edc8c4 /app/Controller
parent1522be603b4508b03b8fa79a6a3fbfeb90ffece6 (diff)
Fix some PHPAnalyzer issues
Diffstat (limited to 'app/Controller')
-rw-r--r--app/Controller/App.php18
-rw-r--r--app/Controller/Board.php4
-rw-r--r--app/Controller/Project.php4
3 files changed, 17 insertions, 9 deletions
diff --git a/app/Controller/App.php b/app/Controller/App.php
index c88fd928..eb1d83af 100644
--- a/app/Controller/App.php
+++ b/app/Controller/App.php
@@ -2,7 +2,6 @@
namespace Controller;
-use Model\Project as ProjectModel;
use Model\SubTask as SubTaskModel;
use Helper;
@@ -57,6 +56,11 @@ class App extends Base
* Get tasks pagination
*
* @access public
+ * @param integer $user_id
+ * @param string $paginate
+ * @param integer $offset
+ * @param string $order
+ * @param string $direction
*/
private function getTaskPagination($user_id, $paginate, $offset, $order, $direction)
{
@@ -94,6 +98,11 @@ class App extends Base
* Get subtasks pagination
*
* @access public
+ * @param integer $user_id
+ * @param string $paginate
+ * @param integer $offset
+ * @param string $order
+ * @param string $direction
*/
private function getSubtaskPagination($user_id, $paginate, $offset, $order, $direction)
{
@@ -132,8 +141,13 @@ class App extends Base
* Get projects pagination
*
* @access public
+ * @param array $project_ids
+ * @param string $paginate
+ * @param integer $offset
+ * @param string $order
+ * @param string $direction
*/
- private function getProjectPagination($project_ids, $paginate, $offset, $order, $direction)
+ private function getProjectPagination(array $project_ids, $paginate, $offset, $order, $direction)
{
$limit = 5;
diff --git a/app/Controller/Board.php b/app/Controller/Board.php
index c5823328..072acf26 100644
--- a/app/Controller/Board.php
+++ b/app/Controller/Board.php
@@ -2,10 +2,6 @@
namespace Controller;
-use Model\Project as ProjectModel;
-use Model\User as UserModel;
-use Core\Security;
-
/**
* Board controller
*
diff --git a/app/Controller/Project.php b/app/Controller/Project.php
index d407c17e..5395a5a4 100644
--- a/app/Controller/Project.php
+++ b/app/Controller/Project.php
@@ -2,8 +2,6 @@
namespace Controller;
-use Model\Task as TaskModel;
-
/**
* Project controller
*
@@ -249,7 +247,7 @@ class Project extends Base
if ($valid) {
- if ($this->projectPermission->allowUser($values['project_id'], $values['user_id'], $values['is_owner'])) {
+ if ($this->projectPermission->allowUser($values['project_id'], $values['user_id'])) {
$this->session->flash(t('Project updated successfully.'));
}
else {