Avoid code duplication in PR #2891

1 files changed, 6 insertions, 14 deletions

diff --git a/app/Helper/FileHelper.php b/app/Helper/FileHelper.php
index 82b444d0..06589124 100644
--- a/app/Helper/FileHelper.php
+++ b/app/Helper/FileHelper.php
@@ -21,9 +21,7 @@ class FileHelper extends Base
      */
     public function icon($filename)
     {
-        $extension = strtolower(pathinfo($filename, PATHINFO_EXTENSION));
-
-        switch ($extension) {
+        switch (get_file_extension($filename)) {
             case 'jpeg':
             case 'jpg':
             case 'png':
@@ -70,9 +68,7 @@ class FileHelper extends Base
      */
     public function getImageMimeType($filename)
     {
-        $extension = strtolower(pathinfo($filename, PATHINFO_EXTENSION));
-
-        switch ($extension) {
+        switch (get_file_extension($filename)) {
             case 'jpeg':
             case 'jpg':
                 return 'image/jpeg';
@@ -94,9 +90,7 @@ class FileHelper extends Base
      */
     public function getPreviewType($filename)
     {
-        $extension = strtolower(pathinfo($filename, PATHINFO_EXTENSION));
-
-        switch ($extension) {
+        switch (get_file_extension($filename)) {
             case 'md':
             case 'markdown':
                 return 'markdown';
@@ -108,17 +102,15 @@ class FileHelper extends Base
     }
 
     /**
-     * Return the browser view mimetype based on the file extension.
+     * Return the browser view mime-type based on the file extension.
      *
+     * @access public
      * @param  $filename
-     *
      * @return string
      */
     public function getBrowserViewType($filename)
     {
-        $extension = strtolower(pathinfo($filename, PATHINFO_EXTENSION));
-
-        switch ($extension) {
+        switch (get_file_extension($filename)) {
             case 'pdf':
                 return 'application/pdf';
         }