Remove workaround for 'INSERT ON DUPLICATE KEY UPDATE...'

1 files changed, 20 insertions, 12 deletions

diff --git a/app/Model/ProjectDailyStats.php b/app/Model/ProjectDailyStats.php
index 46ca0a4b..7ec1ee2c 100644
--- a/app/Model/ProjectDailyStats.php
+++ b/app/Model/ProjectDailyStats.php
@@ -29,27 +29,35 @@ class ProjectDailyStats extends Base
      */
     public function updateTotals($project_id, $date)
     {
-        $lead_cycle_time = $this->projectAnalytic->getAverageLeadAndCycleTime($project_id);
+        $this->db->startTransaction();
 
-        return $this->db->transaction(function (Database $db) use ($project_id, $date, $lead_cycle_time) {
+        $lead_cycle_time = $this->projectAnalytic->getAverageLeadAndCycleTime($project_id);
 
-            // This call will fail if the record already exists
-            // (cross database driver hack for INSERT..ON DUPLICATE KEY UPDATE)
-            $db->table(ProjectDailyStats::TABLE)->insert(array(
-                'day' => $date,
-                'project_id' => $project_id,
-                'avg_lead_time' => 0,
-                'avg_cycle_time' => 0,
-            ));
+        $exists = $this->db->table(ProjectDailyStats::TABLE)
+            ->eq('day', $date)
+            ->eq('project_id', $project_id)
+            ->exists();
 
-            $db->table(ProjectDailyStats::TABLE)
+        if ($exists) {
+            $this->db->table(ProjectDailyStats::TABLE)
                 ->eq('project_id', $project_id)
                 ->eq('day', $date)
                 ->update(array(
                     'avg_lead_time' => $lead_cycle_time['avg_lead_time'],
                     'avg_cycle_time' => $lead_cycle_time['avg_cycle_time'],
                 ));
-        });
+        } else {
+            $this->db->table(ProjectDailyStats::TABLE)->insert(array(
+                'day' => $date,
+                'project_id' => $project_id,
+                'avg_lead_time' => $lead_cycle_time['avg_lead_time'],
+                'avg_cycle_time' => $lead_cycle_time['avg_cycle_time'],
+            ));
+        }
+
+        $this->db->closeTransaction();
+
+        return true;
     }
 
     /**