File events refactoring

4 files changed, 6 insertions, 32 deletions

diff --git a/app/Subscriber/BaseSubscriber.php b/app/Subscriber/BaseSubscriber.php
index fdea29f6..92441962 100644
--- a/app/Subscriber/BaseSubscriber.php
+++ b/app/Subscriber/BaseSubscriber.php
@@ -12,28 +12,4 @@ use Kanboard\Core\Base;
  */
 class BaseSubscriber extends Base
 {
-    /**
-     * Method called
-     *
-     * @access private
-     * @var array
-     */
-    private $called = array();
-
-    /**
-     * Check if a listener has been executed
-     *
-     * @access public
-     * @param  string  $key
-     * @return boolean
-     */
-    public function isExecuted($key = '')
-    {
-        if (isset($this->called[$key])) {
-            return true;
-        }
-
-        $this->called[$key] = true;
-        return false;
-    }
 }
diff --git a/app/Subscriber/NotificationSubscriber.php b/app/Subscriber/NotificationSubscriber.php
index 6cd7675c..47222f73 100644
--- a/app/Subscriber/NotificationSubscriber.php
+++ b/app/Subscriber/NotificationSubscriber.php
@@ -36,12 +36,10 @@ class NotificationSubscriber extends BaseSubscriber implements EventSubscriberIn
 
     public function handleEvent(GenericEvent $event, $eventName)
     {
-        if (!$this->isExecuted($eventName)) {
-            $this->logger->debug('Subscriber executed: ' . __METHOD__);
+        $this->logger->debug('Subscriber executed: ' . __METHOD__);
 
-            $this->queueManager->push(NotificationJob::getInstance($this->container)
-                ->withParams($event, $eventName, get_class($event))
-            );
-        }
+        $this->queueManager->push(NotificationJob::getInstance($this->container)
+            ->withParams($event, $eventName, get_class($event))
+        );
     }
 }
diff --git a/app/Subscriber/ProjectDailySummarySubscriber.php b/app/Subscriber/ProjectDailySummarySubscriber.php
index 6971a121..7e3c11c3 100644
--- a/app/Subscriber/ProjectDailySummarySubscriber.php
+++ b/app/Subscriber/ProjectDailySummarySubscriber.php
@@ -22,7 +22,7 @@ class ProjectDailySummarySubscriber extends BaseSubscriber implements EventSubsc
 
     public function execute(TaskEvent $event)
     {
-        if (isset($event['project_id']) && !$this->isExecuted()) {
+        if (isset($event['project_id'])) {
             $this->logger->debug('Subscriber executed: '.__METHOD__);
             $this->queueManager->push(ProjectMetricJob::getInstance($this->container)->withParams($event['project_id']));
         }
diff --git a/app/Subscriber/ProjectModificationDateSubscriber.php b/app/Subscriber/ProjectModificationDateSubscriber.php
index fee04eaa..97923af9 100644
--- a/app/Subscriber/ProjectModificationDateSubscriber.php
+++ b/app/Subscriber/ProjectModificationDateSubscriber.php
@@ -24,7 +24,7 @@ class ProjectModificationDateSubscriber extends BaseSubscriber implements EventS
 
     public function execute(GenericEvent $event)
     {
-        if (isset($event['project_id']) && !$this->isExecuted()) {
+        if (isset($event['project_id'])) {
             $this->logger->debug('Subscriber executed: '.__METHOD__);
             $this->projectModel->updateModificationDate($event['project_id']);
         }