Merge pull request #1 from fguillot/master

Update from upstream

5 files changed, 618 insertions, 0 deletions

diff --git a/tests/units/Core/Http/OAuth2Test.php b/tests/units/Core/Http/OAuth2Test.php
new file mode 100644
index 00000000..c68ae116
--- /dev/null
+++ b/tests/units/Core/Http/OAuth2Test.php
@@ -0,0 +1,53 @@
+<?php
+
+require_once __DIR__.'/../../Base.php';
+
+use Kanboard\Core\Http\OAuth2;
+
+class OAuth2Test extends Base
+{
+    public function testAuthUrl()
+    {
+        $oauth = new OAuth2($this->container);
+        $oauth->createService('A', 'B', 'C', 'D', 'E', array('f', 'g'));
+        $this->assertEquals('D?response_type=code&client_id=A&redirect_uri=C&scope=f+g', $oauth->getAuthorizationUrl());
+    }
+
+    public function testAuthHeader()
+    {
+        $oauth = new OAuth2($this->container);
+        $oauth->createService('A', 'B', 'C', 'D', 'E', array('f', 'g'));
+
+        $oauth->setAccessToken('foobar', 'BeaRer');
+        $this->assertEquals('Authorization: Bearer foobar', $oauth->getAuthorizationHeader());
+
+        $oauth->setAccessToken('foobar', 'unknown');
+        $this->assertEquals('', $oauth->getAuthorizationHeader());
+    }
+
+    public function testAccessToken()
+    {
+        $params = array(
+            'code' => 'something',
+            'client_id' => 'A',
+            'client_secret' => 'B',
+            'redirect_uri' => 'C',
+            'grant_type' => 'authorization_code',
+        );
+
+        $response = json_encode(array(
+            'token_type' => 'bearer',
+            'access_token' => 'plop',
+        ));
+
+        $this->container['httpClient']
+            ->expects($this->once())
+            ->method('postForm')
+            ->with('E', $params, array('Accept: application/json'))
+            ->will($this->returnValue($response));
+
+        $oauth = new OAuth2($this->container);
+        $oauth->createService('A', 'B', 'C', 'D', 'E', array('f', 'g'));
+        $oauth->getAccessToken('something');
+    }
+}
diff --git a/tests/units/Core/Http/RememberMeCookieTest.php b/tests/units/Core/Http/RememberMeCookieTest.php
new file mode 100644
index 00000000..ae5606ac
--- /dev/null
+++ b/tests/units/Core/Http/RememberMeCookieTest.php
@@ -0,0 +1,108 @@
+<?php
+
+namespace Kanboard\Core\Http;
+
+require_once __DIR__.'/../../Base.php';
+
+function setcookie($name, $value = "", $expire = 0, $path = "", $domain = "", $secure = false, $httponly = false)
+{
+    return RememberMeCookieTest::$functions->setcookie($name, $value, $expire, $path, $domain, $secure, $httponly);
+}
+
+class RememberMeCookieTest extends \Base
+{
+    public static $functions;
+
+    public function setUp()
+    {
+        parent::setup();
+
+        self::$functions = $this
+            ->getMockBuilder('stdClass')
+            ->setMethods(array(
+                'setcookie',
+            ))
+            ->getMock();
+    }
+
+    public function tearDown()
+    {
+        parent::tearDown();
+        self::$functions = null;
+    }
+
+    public function testEncode()
+    {
+        $cookie = new RememberMeCookie($this->container);
+        $this->assertEquals('a|b', $cookie->encode('a', 'b'));
+    }
+
+    public function testDecode()
+    {
+        $cookie = new RememberMeCookie($this->container);
+        $this->assertEquals(array('token' => 'a', 'sequence' => 'b'), $cookie->decode('a|b'));
+    }
+
+    public function testHasCookie()
+    {
+        $this->container['request'] = new Request($this->container, array(), array(), array(), array(), array());
+
+        $cookie = new RememberMeCookie($this->container);
+        $this->assertFalse($cookie->hasCookie());
+
+        $this->container['request'] = new Request($this->container, array(), array(), array(), array(), array(RememberMeCookie::COOKIE_NAME => 'miam'));
+        $this->assertTrue($cookie->hasCookie());
+    }
+
+    public function testWrite()
+    {
+        self::$functions
+            ->expects($this->once())
+            ->method('setcookie')
+            ->with(
+                RememberMeCookie::COOKIE_NAME,
+                'myToken|mySequence',
+                1234,
+                '',
+                '',
+                false,
+                true
+            )
+            ->will($this->returnValue(true));
+
+        $cookie = new RememberMeCookie($this->container);
+        $this->assertTrue($cookie->write('myToken', 'mySequence', 1234));
+    }
+
+    public function testRead()
+    {
+        $this->container['request'] = new Request($this->container, array(), array(), array(), array(), array());
+
+        $cookie = new RememberMeCookie($this->container);
+        $this->assertFalse($cookie->read());
+
+        $this->container['request'] = new Request($this->container, array(), array(), array(), array(), array(RememberMeCookie::COOKIE_NAME => 'T|S'));
+
+        $this->assertEquals(array('token' => 'T', 'sequence' => 'S'), $cookie->read());
+    }
+
+    public function testRemove()
+    {
+        self::$functions
+            ->expects($this->once())
+            ->method('setcookie')
+            ->with(
+                RememberMeCookie::COOKIE_NAME,
+                '',
+                time() - 3600,
+                '',
+                '',
+                false,
+                true
+            )
+            ->will($this->returnValue(true));
+
+        $cookie = new RememberMeCookie($this->container);
+        $this->assertTrue($cookie->remove());
+    }
+}
diff --git a/tests/units/Core/Http/RequestTest.php b/tests/units/Core/Http/RequestTest.php
new file mode 100644
index 00000000..217698f9
--- /dev/null
+++ b/tests/units/Core/Http/RequestTest.php
@@ -0,0 +1,175 @@
+<?php
+
+require_once __DIR__.'/../../Base.php';
+
+use Kanboard\Core\Http\Request;
+
+class RequestTest extends Base
+{
+    public function testGetStringParam()
+    {
+        $request = new Request($this->container, array(), array(), array(), array(), array());
+        $this->assertEquals('', $request->getStringParam('myvar'));
+
+        $request = new Request($this->container, array(), array(), array(), array(), array());
+        $this->assertEquals('default', $request->getStringParam('myvar', 'default'));
+
+        $request = new Request($this->container, array(), array('myvar' => 'myvalue'), array(), array(), array());
+        $this->assertEquals('myvalue', $request->getStringParam('myvar'));
+    }
+
+    public function testGetIntegerParam()
+    {
+        $request = new Request($this->container, array(), array(), array(), array(), array());
+        $this->assertEquals(0, $request->getIntegerParam('myvar'));
+
+        $request = new Request($this->container, array(), array(), array(), array(), array());
+        $this->assertEquals(5, $request->getIntegerParam('myvar', 5));
+
+        $request = new Request($this->container, array(), array('myvar' => 'myvalue'), array(), array(), array());
+        $this->assertEquals(0, $request->getIntegerParam('myvar'));
+
+        $request = new Request($this->container, array(), array('myvar' => '123'), array(), array(), array());
+        $this->assertEquals(123, $request->getIntegerParam('myvar'));
+    }
+
+    public function testGetValues()
+    {
+        $request = new Request($this->container, array(), array(), array('myvar' => 'myvalue'), array(), array());
+        $this->assertEmpty($request->getValue('myvar'));
+
+        $request = new Request($this->container, array(), array(), array('myvar' => 'myvalue', 'csrf_token' => $this->container['token']->getCSRFToken()), array(), array());
+        $this->assertEquals('myvalue', $request->getValue('myvar'));
+
+        $request = new Request($this->container, array(), array(), array('myvar' => 'myvalue', 'csrf_token' => $this->container['token']->getCSRFToken()), array(), array());
+        $this->assertEquals(array('myvar' => 'myvalue'), $request->getValues());
+    }
+
+    public function testGetFileContent()
+    {
+        $request = new Request($this->container, array(), array(), array(), array(), array());
+        $this->assertEmpty($request->getFileContent('myfile'));
+
+        $filename = tempnam(sys_get_temp_dir(), 'UnitTest');
+        file_put_contents($filename, 'something');
+
+        $request = new Request($this->container, array(), array(), array(), array('myfile' => array('tmp_name' => $filename)), array());
+        $this->assertEquals('something', $request->getFileContent('myfile'));
+
+        unlink($filename);
+    }
+
+    public function testGetFilePath()
+    {
+        $request = new Request($this->container, array(), array(), array(), array(), array());
+        $this->assertEmpty($request->getFilePath('myfile'));
+
+        $request = new Request($this->container, array(), array(), array(), array('myfile' => array('tmp_name' => 'somewhere')), array());
+        $this->assertEquals('somewhere', $request->getFilePath('myfile'));
+    }
+
+    public function testIsPost()
+    {
+        $request = new Request($this->container, array(), array(), array(), array(), array());
+        $this->assertFalse($request->isPost());
+
+        $request = new Request($this->container, array('REQUEST_METHOD' => 'POST'), array(), array(), array(), array());
+        $this->assertTrue($request->isPost());
+    }
+
+    public function testIsAjax()
+    {
+        $request = new Request($this->container, array(), array(), array(), array(), array());
+        $this->assertFalse($request->isAjax());
+
+        $request = new Request($this->container, array('HTTP_X_REQUESTED_WITH' => 'XMLHttpRequest'), array(), array(), array(), array());
+        $this->assertTrue($request->isAjax());
+    }
+
+    public function testIsHTTPS()
+    {
+        $request = new Request($this->container, array(), array(), array(), array());
+        $this->assertFalse($request->isHTTPS());
+
+        $request = new Request($this->container, array('HTTPS' => ''), array(), array(), array(), array());
+        $this->assertFalse($request->isHTTPS());
+
+        $request = new Request($this->container, array('HTTPS' => 'off'), array(), array(), array(), array());
+        $this->assertFalse($request->isHTTPS());
+
+        $request = new Request($this->container, array('HTTPS' => 'on'), array(), array(), array(), array());
+        $this->assertTrue($request->isHTTPS());
+
+        $request = new Request($this->container, array('HTTPS' => '1'), array(), array(), array(), array());
+        $this->assertTrue($request->isHTTPS());
+    }
+
+    public function testGetCookie()
+    {
+        $request = new Request($this->container, array(), array(), array(), array(), array());
+        $this->assertEmpty($request->getCookie('mycookie'));
+
+        $request = new Request($this->container, array(), array(), array(), array(), array('mycookie' => 'miam'));
+        $this->assertEquals('miam', $request->getCookie('mycookie'));
+    }
+
+    public function testGetHeader()
+    {
+        $request = new Request($this->container, array(), array(), array(), array(), array());
+        $this->assertEmpty($request->getHeader('X-Forwarded-For'));
+
+        $request = new Request($this->container, array('HTTP_X_FORWARDED_FOR' => 'test'), array(), array(), array(), array());
+        $this->assertEquals('test', $request->getHeader('X-Forwarded-For'));
+    }
+
+    public function testGetRemoteUser()
+    {
+        $request = new Request($this->container, array(), array(), array(), array(), array());
+        $this->assertEmpty($request->getRemoteUser());
+
+        $request = new Request($this->container, array(REVERSE_PROXY_USER_HEADER => 'test'), array(), array(), array(), array());
+        $this->assertEquals('test', $request->getRemoteUser());
+    }
+
+    public function testGetQueryString()
+    {
+        $request = new Request($this->container, array(), array(), array(), array(), array());
+        $this->assertEmpty($request->getQueryString());
+
+        $request = new Request($this->container, array('QUERY_STRING' => 'k=v'), array(), array(), array(), array());
+        $this->assertEquals('k=v', $request->getQueryString());
+    }
+
+    public function testGetUri()
+    {
+        $request = new Request($this->container, array(), array(), array(), array(), array());
+        $this->assertEmpty($request->getUri());
+
+        $request = new Request($this->container, array('REQUEST_URI' => '/blah'), array(), array(), array(), array());
+        $this->assertEquals('/blah', $request->getUri());
+    }
+
+    public function testGetUserAgent()
+    {
+        $request = new Request($this->container, array(), array(), array(), array(), array());
+        $this->assertEquals('Unknown', $request->getUserAgent());
+
+        $request = new Request($this->container, array('HTTP_USER_AGENT' => 'My browser'), array(), array(), array(), array());
+        $this->assertEquals('My browser', $request->getUserAgent());
+    }
+
+    public function testGetIpAddress()
+    {
+        $request = new Request($this->container, array(), array(), array(), array(), array());
+        $this->assertEquals('Unknown', $request->getIpAddress());
+
+        $request = new Request($this->container, array('HTTP_X_FORWARDED_FOR' => '192.168.0.1,127.0.0.1'), array(), array(), array(), array());
+        $this->assertEquals('192.168.0.1', $request->getIpAddress());
+
+        $request = new Request($this->container, array('REMOTE_ADDR' => '192.168.0.1'), array(), array(), array(), array());
+        $this->assertEquals('192.168.0.1', $request->getIpAddress());
+
+        $request = new Request($this->container, array('REMOTE_ADDR' => ''), array(), array(), array(), array());
+        $this->assertEquals('Unknown', $request->getIpAddress());
+    }
+}
diff --git a/tests/units/Core/Http/RouteTest.php b/tests/units/Core/Http/RouteTest.php
new file mode 100644
index 00000000..5e44ad00
--- /dev/null
+++ b/tests/units/Core/Http/RouteTest.php
@@ -0,0 +1,79 @@
+<?php
+
+require_once __DIR__.'/../../Base.php';
+
+use Kanboard\Core\Http\Route;
+
+class RouteTest extends Base
+{
+    public function testFindParams()
+    {
+        $route = new Route($this->container);
+        $route->enable();
+
+        $this->assertEquals(array('p1' => true, 'p2' => true), $route->findParams(array('something', ':p1', ':p2')));
+        $this->assertEquals(array('p1' => true), $route->findParams(array('something', ':p1', '')));
+        $this->assertEquals(array('p1' => true), $route->findParams(array('something', ':p1', 'something else')));
+    }
+
+    public function testFindRoute()
+    {
+        $route = new Route($this->container);
+        $route->enable();
+
+        $route->addRoute('/mycontroller/myaction', 'mycontroller', 'myaction');
+        $this->assertEquals(
+            array('controller' => 'mycontroller', 'action' => 'myaction', 'plugin' => ''),
+            $route->findRoute('/mycontroller/myaction')
+        );
+
+        $route->addRoute('/a/b/c', 'mycontroller', 'myaction', 'myplugin');
+        $this->assertEquals(
+            array('controller' => 'mycontroller', 'action' => 'myaction', 'plugin' => 'myplugin'),
+            $route->findRoute('/a/b/c')
+        );
+
+        $this->assertEquals(
+            array('controller' => 'app', 'action' => 'index', 'plugin' => ''),
+            $route->findRoute('/notfound')
+        );
+
+        $route->addRoute('/a/b/:c', 'mycontroller', 'myaction', 'myplugin');
+        $this->assertEquals(
+            array('controller' => 'mycontroller', 'action' => 'myaction', 'plugin' => 'myplugin'),
+            $route->findRoute('/a/b/myvalue')
+        );
+
+        $this->assertEquals('myvalue', $this->container['request']->getStringParam('c'));
+
+        $route->addRoute('/a/:p1/b/:p2', 'mycontroller', 'myaction');
+        $this->assertEquals(
+            array('controller' => 'mycontroller', 'action' => 'myaction', 'plugin' => ''),
+            $route->findRoute('/a/v1/b/v2')
+        );
+
+        $this->assertEquals('v1', $this->container['request']->getStringParam('p1'));
+        $this->assertEquals('v2', $this->container['request']->getStringParam('p2'));
+    }
+
+    public function testFindUrl()
+    {
+        $route = new Route($this->container);
+        $route->enable();
+        $route->addRoute('a/b', 'controller1', 'action1');
+        $route->addRoute('a/:myvar1/b/:myvar2', 'controller2', 'action2');
+        $route->addRoute('/something', 'controller1', 'action1', 'myplugin');
+        $route->addRoute('/myplugin/myroute', 'controller1', 'action2', 'myplugin');
+        $route->addRoute('/foo/:myvar', 'controller1', 'action3', 'myplugin');
+
+        $this->assertEquals('a/1/b/2', $route->findUrl('controller2', 'action2', array('myvar1' => 1, 'myvar2' => 2)));
+        $this->assertEquals('', $route->findUrl('controller2', 'action2', array('myvar1' => 1)));
+        $this->assertEquals('a/b', $route->findUrl('controller1', 'action1'));
+        $this->assertEquals('', $route->findUrl('controller1', 'action2'));
+
+        $this->assertEquals('myplugin/myroute', $route->findUrl('controller1', 'action2', array(), 'myplugin'));
+        $this->assertEquals('something', $route->findUrl('controller1', 'action1', array(), 'myplugin'));
+        $this->assertEquals('foo/123', $route->findUrl('controller1', 'action3', array('myvar' => 123), 'myplugin'));
+        $this->assertEquals('foo/123', $route->findUrl('controller1', 'action3', array('myvar' => 123, 'plugin' => 'myplugin')));
+    }
+}
diff --git a/tests/units/Core/Http/RouterTest.php b/tests/units/Core/Http/RouterTest.php
new file mode 100644
index 00000000..0b200ab5
--- /dev/null
+++ b/tests/units/Core/Http/RouterTest.php
@@ -0,0 +1,203 @@
+<?php
+
+namespace Kanboard\Controller {
+
+    class FakeController {
+        public function beforeAction() {}
+        public function myAction() {}
+    }
+}
+
+namespace Kanboard\Plugin\Myplugin\Controller {
+
+    class FakeController {
+        public function beforeAction() {}
+        public function myAction() {}
+    }
+}
+
+namespace {
+
+    require_once __DIR__.'/../../Base.php';
+
+    use Kanboard\Core\Helper;
+    use Kanboard\Core\Http\Route;
+    use Kanboard\Core\Http\Router;
+    use Kanboard\Core\Http\Request;
+
+    class RouterTest extends Base
+    {
+        public function testSanitize()
+        {
+            $dispatcher = new Router($this->container);
+
+            $this->assertEquals('PloP', $dispatcher->sanitize('PloP', 'default'));
+            $this->assertEquals('default', $dispatcher->sanitize('', 'default'));
+            $this->assertEquals('default', $dispatcher->sanitize('123-AB', 'default'));
+            $this->assertEquals('default', $dispatcher->sanitize('R&D', 'default'));
+            $this->assertEquals('Test123', $dispatcher->sanitize('Test123', 'default'));
+            $this->assertEquals('Test_123', $dispatcher->sanitize('Test_123', 'default'));
+            $this->assertEquals('userImport', $dispatcher->sanitize('userImport', 'default'));
+        }
+
+        public function testGetPath()
+        {
+            $dispatcher = new Router($this->container);
+
+            $this->container['helper'] = new Helper($this->container);
+            $this->container['request'] = new Request($this->container, array('PHP_SELF' => '/index.php', 'REQUEST_URI' => '/a/b/c', 'REQUEST_METHOD' => 'GET'));
+            $this->assertEquals('a/b/c', $dispatcher->getPath());
+
+            $this->container['helper'] = new Helper($this->container);
+            $this->container['request'] = new Request($this->container, array('PHP_SELF' => '/index.php', 'REQUEST_URI' => '/a/b/something?test=a', 'QUERY_STRING' => 'test=a', 'REQUEST_METHOD' => 'GET'));
+            $this->assertEquals('a/b/something', $dispatcher->getPath());
+
+            $this->container['helper'] = new Helper($this->container);
+            $this->container['request'] = new Request($this->container, array('PHP_SELF' => '/a/index.php', 'REQUEST_URI' => '/a/b/something?test=a', 'QUERY_STRING' => 'test=a', 'REQUEST_METHOD' => 'GET'));
+            $this->assertEquals('b/something', $dispatcher->getPath());
+        }
+
+        public function testDispatcherWithControllerNotFound()
+        {
+            $this->container['request'] = new Request($this->container, array(
+                    'PHP_SELF' => '/kanboard/index.php',
+                    'REQUEST_URI' => '/kanboard/?controller=FakeControllerNotFound&action=myAction&myvar=value1',
+                    'QUERY_STRING' => 'controller=FakeControllerNotFound&action=myAction&myvar=value1',
+                    'REQUEST_METHOD' => 'GET'
+                ),
+                array(
+                    'controller' => 'FakeControllerNotFound',
+                    'action' => 'myAction',
+                    'myvar' => 'value1',
+                )
+            );
+
+            $this->setExpectedException('RuntimeException', 'Controller not found');
+
+            $dispatcher = new Router($this->container);
+            $dispatcher->dispatch();
+        }
+
+        public function testDispatcherWithActionNotFound()
+        {
+            $this->container['request'] = new Request($this->container, array(
+                    'PHP_SELF' => '/kanboard/index.php',
+                    'REQUEST_URI' => '/kanboard/?controller=FakeController&action=myActionNotFound&myvar=value1',
+                    'QUERY_STRING' => 'controller=FakeController&action=myActionNotFound&myvar=value1',
+                    'REQUEST_METHOD' => 'GET'
+                ),
+                array(
+                    'controller' => 'FakeController',
+                    'action' => 'myActionNotFound',
+                    'myvar' => 'value1',
+                )
+            );
+
+            $this->setExpectedException('RuntimeException', 'Action not implemented');
+
+            $dispatcher = new Router($this->container);
+            $dispatcher->dispatch();
+        }
+
+        public function testDispatcherWithNoUrlRewrite()
+        {
+            $this->container['request'] = new Request($this->container, array(
+                    'PHP_SELF' => '/kanboard/index.php',
+                    'REQUEST_URI' => '/kanboard/?controller=FakeController&action=myAction&myvar=value1',
+                    'QUERY_STRING' => 'controller=FakeController&action=myAction&myvar=value1',
+                    'REQUEST_METHOD' => 'GET'
+                ),
+                array(
+                    'controller' => 'FakeController',
+                    'action' => 'myAction',
+                    'myvar' => 'value1',
+                )
+            );
+
+            $dispatcher = new Router($this->container);
+            $this->assertInstanceOf('\Kanboard\Controller\FakeController', $dispatcher->dispatch());
+            $this->assertEquals('FakeController', $dispatcher->getController());
+            $this->assertEquals('myAction', $dispatcher->getAction());
+            $this->assertEquals('', $dispatcher->getPlugin());
+            $this->assertEquals('value1', $this->container['request']->getStringParam('myvar'));
+        }
+
+        public function testDispatcherWithNoUrlRewriteAndPlugin()
+        {
+            $this->container['request'] = new Request($this->container, array(
+                    'PHP_SELF' => '/kanboard/index.php',
+                    'REQUEST_URI' => '/kanboard/?controller=FakeController&action=myAction&myvar=value1&plugin=myplugin',
+                    'QUERY_STRING' => 'controller=FakeController&action=myAction&myvar=value1&plugin=myplugin',
+                    'REQUEST_METHOD' => 'GET'
+                ),
+                array(
+                    'controller' => 'FakeController',
+                    'action' => 'myAction',
+                    'myvar' => 'value1',
+                    'plugin' => 'myplugin',
+                )
+            );
+
+            $dispatcher = new Router($this->container);
+            $this->assertInstanceOf('\Kanboard\Plugin\Myplugin\Controller\FakeController', $dispatcher->dispatch());
+            $this->assertEquals('FakeController', $dispatcher->getController());
+            $this->assertEquals('myAction', $dispatcher->getAction());
+            $this->assertEquals('Myplugin', $dispatcher->getPlugin());
+            $this->assertEquals('value1', $this->container['request']->getStringParam('myvar'));
+        }
+
+        public function testDispatcherWithUrlRewrite()
+        {
+            $this->container['request'] = new Request($this->container, array(
+                    'PHP_SELF' => '/kanboard/index.php',
+                    'REQUEST_URI' => '/kanboard/my/route/123?myvar=value1',
+                    'QUERY_STRING' => 'myvar=value1',
+                    'REQUEST_METHOD' => 'GET'
+                ),
+                array(
+                    'myvar' => 'value1',
+                )
+            );
+
+            $this->container['route'] = new Route($this->container);
+            $this->container['route']->enable();
+            $dispatcher = new Router($this->container);
+
+            $this->container['route']->addRoute('/my/route/:param', 'FakeController', 'myAction');
+
+            $this->assertInstanceOf('\Kanboard\Controller\FakeController', $dispatcher->dispatch());
+            $this->assertEquals('FakeController', $dispatcher->getController());
+            $this->assertEquals('myAction', $dispatcher->getAction());
+            $this->assertEquals('', $dispatcher->getPlugin());
+            $this->assertEquals('value1', $this->container['request']->getStringParam('myvar'));
+            $this->assertEquals('123', $this->container['request']->getStringParam('param'));
+        }
+
+        public function testDispatcherWithUrlRewriteWithPlugin()
+        {
+            $this->container['request'] = new Request($this->container, array(
+                    'PHP_SELF' => '/kanboard/index.php',
+                    'REQUEST_URI' => '/kanboard/my/plugin/route/123?myvar=value1',
+                    'QUERY_STRING' => 'myvar=value1',
+                    'REQUEST_METHOD' => 'GET'
+                ),
+                array(
+                    'myvar' => 'value1',
+                )
+            );
+
+            $this->container['route'] = new Route($this->container);
+            $this->container['route']->enable();
+            $dispatcher = new Router($this->container);
+
+            $this->container['route']->addRoute('/my/plugin/route/:param', 'fakeController', 'myAction', 'Myplugin');
+
+            $this->assertInstanceOf('\Kanboard\Plugin\Myplugin\Controller\FakeController', $dispatcher->dispatch());
+            $this->assertEquals('FakeController', $dispatcher->getController());
+            $this->assertEquals('myAction', $dispatcher->getAction());
+            $this->assertEquals('Myplugin', $dispatcher->getPlugin());
+            $this->assertEquals('value1', $this->container['request']->getStringParam('myvar'));
+            $this->assertEquals('123', $this->container['request']->getStringParam('param'));
+        }
+    }
+}