summaryrefslogtreecommitdiff
path: root/framework
diff options
context:
space:
mode:
authorjavalizard <>2010-04-17 04:36:46 +0000
committerjavalizard <>2010-04-17 04:36:46 +0000
commit34fb3ab1cbceb2e739578398748ded5524c46ad2 (patch)
treeabf5175f9e9785ea71be1a04076f05b9fa55013e /framework
parent0b7c1b5adb708eafd79fb77ea2e534ef158b59aa (diff)
Added Unit tests for insertBefore/After. Change code to expected behavior.
Diffstat (limited to 'framework')
-rw-r--r--framework/Collections/TList.php6
1 files changed, 4 insertions, 2 deletions
diff --git a/framework/Collections/TList.php b/framework/Collections/TList.php
index bef39648..cc0eab6d 100644
--- a/framework/Collections/TList.php
+++ b/framework/Collections/TList.php
@@ -252,7 +252,8 @@ class TList extends TComponent implements IteratorAggregate,ArrayAccess,Countabl
*/
public function insertBefore($baseitem, $item)
{
- if(($index = $this->indexOf($baseitem)) == -1) return null;
+ if(($index = $this->indexOf($baseitem)) == -1)
+ throw new TInvalidDataValueException('list_item_inexistent');
$this->insertAt($index, $item);
@@ -268,7 +269,8 @@ class TList extends TComponent implements IteratorAggregate,ArrayAccess,Countabl
*/
public function insertAfter($baseitem, $item)
{
- if(($index = $this->indexOf($baseitem)) == -1) return null;
+ if(($index = $this->indexOf($baseitem)) == -1)
+ throw new TInvalidDataValueException('list_item_inexistent');
$this->insertAt($index + 1, $item);