diff options
| author | Joey Hess <joeyh@joeyh.name> | 2015-06-10 15:57:30 -0400 |
|---|---|---|
| committer | Joey Hess <joeyh@joeyh.name> | 2015-06-10 15:57:30 -0400 |
| commit | 87d8783febbb42096fe77851361b2901dd971973 (patch) | |
| tree | 18d9b3196ee9054ca7b129c16305888ec2dca2e4 | |
| parent | d6b22f4287dfd54f0ae1d9aabff56c5ad24c7eb0 (diff) | |
review
| -rw-r--r-- | doc/todo/remove_remaining_perl_usage/comment_1_c901ff31a0cddf4912123c6443876327._comment | 15 |
1 files changed, 15 insertions, 0 deletions
diff --git a/doc/todo/remove_remaining_perl_usage/comment_1_c901ff31a0cddf4912123c6443876327._comment b/doc/todo/remove_remaining_perl_usage/comment_1_c901ff31a0cddf4912123c6443876327._comment new file mode 100644 index 0000000..0841dad --- /dev/null +++ b/doc/todo/remove_remaining_perl_usage/comment_1_c901ff31a0cddf4912123c6443876327._comment @@ -0,0 +1,15 @@ +[[!comment format=mdwn + username="joey" + subject="""comment 1""" + date="2015-06-10T19:50:30Z" + content=""" +Reviewing this patch, I noticed a bug in the first hunk. lsscripts +currently limits the files it finds to those matching a regexp. IIRC, this +is needed, amoung other things, to avoid .dpkg-old files being run. + +Looking at the second hunk, I suspect that calling `id` twice per file is +going to be significantly slower than the perl implementation. + +There also seems to be missing escaping of single quotes in filenames in +the second hunk. +"""]] |