Recurring tasks (#847): move hardcoded conditions to event subscriber + refactoring

1 files changed, 1 insertions, 10 deletions

diff --git a/app/Model/TaskStatus.php b/app/Model/TaskStatus.php
index 1ae8bfeb..30a65e1e 100644
--- a/app/Model/TaskStatus.php
+++ b/app/Model/TaskStatus.php
@@ -89,9 +89,7 @@ class TaskStatus extends Base
      */
     private function changeStatus($task_id, $status, $date_completed, $event)
     {
-        $task = $this->taskFinder->getById($task_id);
-
-        if (!$task['id']) {
+        if (! $this->taskFinder->exists($task_id)) {
             return false;
         }
 
@@ -109,13 +107,6 @@ class TaskStatus extends Base
                 $event,
                 new TaskEvent(array('task_id' => $task_id) + $this->taskFinder->getById($task_id))
             );
-
-            if ($status == Task::STATUS_CLOSED
-                && $task['recurrence_status'] == Task::RECURE_STATUS_PENDING
-                && $task['recurrence_trigger'] == Task::RECURE_TRIGGER_CLOSE)
-            {
-                $this->taskDuplication->createRecurrence($task_id);
-            }
         }
 
         return $result;