ProjectPermissionController: make sure groups don't exist before creating them

Adding logic to check for a group by external ID, before trying to create it.

1 files changed, 7 insertions, 1 deletions

diff --git a/app/Controller/ProjectPermissionController.php b/app/Controller/ProjectPermissionController.php
index f3ca6ed9..cbcdf77d 100644
--- a/app/Controller/ProjectPermissionController.php
+++ b/app/Controller/ProjectPermissionController.php
@@ -147,7 +147,13 @@ class ProjectPermissionController extends BaseController
         $values = $this->request->getValues();
 
         if (empty($values['group_id']) && ! empty($values['external_id'])) {
-            $values['group_id'] = $this->groupModel->create($values['name'], $values['external_id']);
+            $group = $this->groupModel->getByExternalId($values['external_id']);
+            if ($group) {
+                $values['group_id'] = $group['id'];
+            }
+            else {
+                $values['group_id'] = $this->groupModel->create($values['name'], $values['external_id']);
+            }
         }
 
         if ($this->projectGroupRoleModel->addGroup($project['id'], $values['group_id'], $values['role'])) {